From patchwork Mon Jul 16 13:39:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Rebbagondla X-Patchwork-Id: 10526813 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4472C60348 for ; Mon, 16 Jul 2018 13:36:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34601287BD for ; Mon, 16 Jul 2018 13:36:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 28D6C287E5; Mon, 16 Jul 2018 13:36:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0D41287BD for ; Mon, 16 Jul 2018 13:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728742AbeGPODw (ORCPT ); Mon, 16 Jul 2018 10:03:52 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34974 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728037AbeGPODv (ORCPT ); Mon, 16 Jul 2018 10:03:51 -0400 Received: by mail-pf0-f196.google.com with SMTP id q7-v6so25192705pff.2 for ; Mon, 16 Jul 2018 06:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/Oik1rc71tehlMoYcTtBRZRTwsYpwJCn4NqvgZv9+tU=; b=HU7v3G3CWA2vto5GX0uDShlTLvHPI74YO1b1ajNrzQugYFM0VYrgAAtKMCqX6w65zI AALxDdY2XPROKqlJFaCMIEeMK6TM2eoQUf+TXP3YNRyF1RcWk+24Czsbva+aXq9Zcyg8 cFurgVsgRymN2cNQRc71I6wIU+x3+y3QsyqYyvDblfE8fE+6sSPOl41KD+rSTT32OGjN gzUC38G4GMXNWxWp8Qo6oUV5vIeFg/HWjcFWGQQx9q59EmMSdRoQen+Riw0GoFMvFZL8 Npp171lXVrmLy6ayV+JOIlDNqTWeWHgWjYsmKW71gaCoCcal7Gs24QXKud6W0326lWfL fNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/Oik1rc71tehlMoYcTtBRZRTwsYpwJCn4NqvgZv9+tU=; b=IGER5MT/IyYHYd9xTyL4plAu7hR9lzFwcYeYiw8aGuyWUTEZkB4UfjVgad6nT5cvHL CbMCQZRFYfpuCWXyr5f2rrzRF9PzkkAR5YOwdx2zcXE5zWk5QECnHqSZzXoYckRo2ivN dwwvAQ2JNREpQOZv5BRSN6LAVN0XWDPkbjWlZVqlYmjuAvlvBdhzS7Qdb9ZuJUe66Mfu mBufy7ZlspihOXk8Ft6UgRsUmrciydbSCDaJFvTyW4luYwsE6362VX67UGjmgPqM3TQC HA9cyG7yy189F4TN7D+qBFBGomBSXzLCa34zb9FZ6cXyIy2vOC9P+F6JFi9s+Qceu3Qf TECA== X-Gm-Message-State: AOUpUlEWB6fOd8wbGjvCzZA645Zxmde4YkDsVpqQXXPYBfvI5lkmd8K0 bQpRBEvIxReUVAcv5Z7KUzrijHagueA= X-Google-Smtp-Source: AAOMgpeM0KUQux6eK+5Qr5ugACReKUlF32NQ6FqaKOJzaN6XcPjEsvLu/GXOTySpm39OxiV8DdcLpQ== X-Received: by 2002:a63:b047:: with SMTP id z7-v6mr15604844pgo.335.1531748182599; Mon, 16 Jul 2018 06:36:22 -0700 (PDT) Received: from cpu459.localdomain ([27.59.226.48]) by smtp.gmail.com with ESMTPSA id t3-v6sm53756167pfk.161.2018.07.16.06.36.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jul 2018 06:36:21 -0700 (PDT) From: Siva Rebbagondla To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Sushant Kumar Mishra , Siva Rebbagondla , Amol Hanwate Subject: [PATCH 5/6] rsi: fill rx_params only once. Date: Mon, 16 Jul 2018 19:09:36 +0530 Message-Id: <1531748377-29215-6-git-send-email-siva8118@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1531748377-29215-1-git-send-email-siva8118@gmail.com> References: <1531748377-29215-1-git-send-email-siva8118@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Amol Hanwate rx_params are getting updated two times in driver, which is not required. Hence, removing duplicate updation of rx_params from rsi_prepare_skb(). Signed-off-by: Amol Hanwate Signed-off-by: Siva Rebbagondla --- drivers/net/wireless/rsi/rsi_91x_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_main.c b/drivers/net/wireless/rsi/rsi_91x_main.c index 1485a0c..34a5d9c 100644 --- a/drivers/net/wireless/rsi/rsi_91x_main.c +++ b/drivers/net/wireless/rsi/rsi_91x_main.c @@ -122,7 +122,6 @@ static struct sk_buff *rsi_prepare_skb(struct rsi_common *common, u8 extended_desc) { struct ieee80211_tx_info *info; - struct skb_info *rx_params; struct sk_buff *skb = NULL; u8 payload_offset; struct ieee80211_vif *vif; @@ -149,10 +148,6 @@ static struct sk_buff *rsi_prepare_skb(struct rsi_common *common, vif = rsi_get_vif(common->priv, wh->addr1); info = IEEE80211_SKB_CB(skb); - rx_params = (struct skb_info *)info->driver_data; - rx_params->rssi = rsi_get_rssi(buffer); - rx_params->channel = rsi_get_connected_channel(vif); - return skb; }