| Message ID | 1535707647-191888-1-git-send-email-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rsi: remove set but not used variable 'header_size' | expand |
On 2018/8/31 17:27, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt': > drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning: > variable 'header_size' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/wireless/rsi/rsi_91x_hal.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c > index 01edf96..c4fb319 100644 > --- a/drivers/net/wireless/rsi/rsi_91x_hal.c > +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c > @@ -285,7 +285,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) > struct skb_info *tx_params; > struct ieee80211_bss_conf *bss; > int status = -EINVAL; > - u8 header_size; > > if (!skb) > return 0; > @@ -298,7 +297,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) > vif = info->control.vif; > bss = &vif->bss_conf; > tx_params = (struct skb_info *)info->driver_data; tx_params also can be removed. Will send V2. > - header_size = tx_params->internal_hdr_size; > > if (((vif->type == NL80211_IFTYPE_STATION) || > (vif->type == NL80211_IFTYPE_P2P_CLIENT)) && > > > . >
On 2018/9/1 15:16, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt': > drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning: > variable 'header_size' set but not used [-Wunused-but-set-variable] > > 'tx_params' only used for 'header_size' dereferencedï¼Oso also sorry..., there is some messy code, Also missing changelog, I'll fix. > can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c > index 01edf96..182b066 100644 > --- a/drivers/net/wireless/rsi/rsi_91x_hal.c > +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c > @@ -282,10 +282,8 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) > struct rsi_hw *adapter = common->priv; > struct ieee80211_vif *vif; > struct ieee80211_tx_info *info; > - struct skb_info *tx_params; > struct ieee80211_bss_conf *bss; > int status = -EINVAL; > - u8 header_size; > > if (!skb) > return 0; > @@ -297,8 +295,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) > goto err; > vif = info->control.vif; > bss = &vif->bss_conf; > - tx_params = (struct skb_info *)info->driver_data; > - header_size = tx_params->internal_hdr_size; > > if (((vif->type == NL80211_IFTYPE_STATION) || > (vif->type == NL80211_IFTYPE_P2P_CLIENT)) && > > > . >
diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c index 01edf96..c4fb319 100644 --- a/drivers/net/wireless/rsi/rsi_91x_hal.c +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c @@ -285,7 +285,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) struct skb_info *tx_params; struct ieee80211_bss_conf *bss; int status = -EINVAL; - u8 header_size; if (!skb) return 0; @@ -298,7 +297,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) vif = info->control.vif; bss = &vif->bss_conf; tx_params = (struct skb_info *)info->driver_data; - header_size = tx_params->internal_hdr_size; if (((vif->type == NL80211_IFTYPE_STATION) || (vif->type == NL80211_IFTYPE_P2P_CLIENT)) &&
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt': drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning: variable 'header_size' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/rsi/rsi_91x_hal.c | 2 -- 1 file changed, 2 deletions(-)