| Message ID | 1536226714-17201-1-git-send-email-sgruszka@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | mt76: fix return value of mt76x02_wait_for_mac | expand |
On 2018-09-06 11:38, Stanislaw Gruszka wrote: > We need to return bool value in mt76x02_wait_for_mac. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Fixes: 2735a6dd7df3 ("mt76: unify wait_for_mac") > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Merged, thanks. - Felix
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.h b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.h index 1a5da35702e6..a8bb3fede8d5 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.h +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.h @@ -165,7 +165,7 @@ static inline bool mt76x02_wait_for_mac(struct mt76_dev *dev) for (i = 0; i < 500; i++) { if (test_bit(MT76_REMOVED, &dev->state)) - return -EIO; + return false; switch (dev->bus->rr(dev, MAC_CSR0)) { case 0:
We need to return bool value in mt76x02_wait_for_mac. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Fixes: 2735a6dd7df3 ("mt76: unify wait_for_mac") Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)