| Message ID | 1536240014-10349-1-git-send-email-pillair@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: Fix tx status flag setting for management frames | expand |
Hi All, Please ignore this patchset. I have added the Tested HW/FW info and sent the v2 version for this patchset. Thanks, Rakesh Pillai. On 2018-09-06 18:50, Rakesh Pillai wrote: > The tx_status for management frames is being filled > incorrectly in the flags of skb_cb. This incorrect > flag setting causes the upper layers to consider that > the particular frame was not transmitted properly, > leading to improper behavior. > > Set the IEEE80211_TX_STAT_ACK flag in the info flags > of skb_cb, to indicate the successful transmission of > the management frame. > > Fixes: dc405152bb64d4ae01c9ac669de25b2d1fb6fc2d > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > drivers/net/wireless/ath/ath10k/wmi.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c > b/drivers/net/wireless/ath/ath10k/wmi.c > index fd612d2..1dced0d 100644 > --- a/drivers/net/wireless/ath/ath10k/wmi.c > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -2336,7 +2336,12 @@ static int wmi_process_mgmt_tx_comp(struct > ath10k *ar, u32 desc_id, > dma_unmap_single(ar->dev, pkt_addr->paddr, > msdu->len, DMA_FROM_DEVICE); > info = IEEE80211_SKB_CB(msdu); > - info->flags |= status; > + > + if (status) > + info->flags &= ~IEEE80211_TX_STAT_ACK; > + else > + info->flags |= IEEE80211_TX_STAT_ACK; > + > ieee80211_tx_status_irqsafe(ar->hw, msdu); > > ret = 0;
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index fd612d2..1dced0d 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2336,7 +2336,12 @@ static int wmi_process_mgmt_tx_comp(struct ath10k *ar, u32 desc_id, dma_unmap_single(ar->dev, pkt_addr->paddr, msdu->len, DMA_FROM_DEVICE); info = IEEE80211_SKB_CB(msdu); - info->flags |= status; + + if (status) + info->flags &= ~IEEE80211_TX_STAT_ACK; + else + info->flags |= IEEE80211_TX_STAT_ACK; + ieee80211_tx_status_irqsafe(ar->hw, msdu); ret = 0;
The tx_status for management frames is being filled incorrectly in the flags of skb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior. Set the IEEE80211_TX_STAT_ACK flag in the info flags of skb_cb, to indicate the successful transmission of the management frame. Fixes: dc405152bb64d4ae01c9ac669de25b2d1fb6fc2d Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> --- drivers/net/wireless/ath/ath10k/wmi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)