From patchwork Fri Jan 25 06:30:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Rebbagondla X-Patchwork-Id: 10780617 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1CA04746 for ; Fri, 25 Jan 2019 06:30:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B3922F418 for ; Fri, 25 Jan 2019 06:30:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3F2D2F42F; Fri, 25 Jan 2019 06:30:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A01EE2F418 for ; Fri, 25 Jan 2019 06:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfAYGa0 (ORCPT ); Fri, 25 Jan 2019 01:30:26 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36933 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbfAYGaZ (ORCPT ); Fri, 25 Jan 2019 01:30:25 -0500 Received: by mail-pg1-f193.google.com with SMTP id c25so3789270pgb.4 for ; Thu, 24 Jan 2019 22:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wKLTsv8WQv34PB5hXhNvtyTRQ5sUzkKGfvWrDqTNJ50=; b=KIcVgE1K+pr7Z37teLi8EYv3vFwHmzgQTD1D1FKa5Aon8uMehexbLzNPxNuS5ZWttv XKocSsbu0jEghnGlQF9MbhHd20lV0K7dvWuoi1lFbATBMjwAoostsyM2g9V5R76fGlDa ElbnekffoqutRv/D9EoNVaXnVKM2z4vvCCoRU6LU4ZciP17Z5MllY4s1yX2/L2iJPcl5 GHQGqsyqKJ01DifQtcWJ+l6rYhk7bdJdLEQkROPbjH/JqujwKR5Zf01k8cxn9Bes61WZ wOOpvV8M66iQczXyxLP0Bvox5L+fk1CfhCwV8fCoHKgh4I2YBW8i/43SaCZI5cKj5VN4 aUcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wKLTsv8WQv34PB5hXhNvtyTRQ5sUzkKGfvWrDqTNJ50=; b=jX95m4jqExE20eXgxN69njKnF5BeVrNbIGhq//dBmzU4AObkF/sNMzfZ/+ESdC+KGv aBCbRCfvoWYoR72XfwY4Aliy0IavFE/GLWdBeveaTTa3llRLqyxb3qUHbv3YlORN/Sye 7nTqhy+nKO2kYayQiegRtu6T5eSlu8UQXe33/QvbN7GGeYjClw10Up83P/leB5Nz74f5 XUBTKlvCLWkWTU8MHeo76G4kTMjUqq5wc/wmycwYjYaL17zWV/sUJ3L+Sgrc2qfJRSPz 5lvcaZL0BgZQuBTaENdHP/AXapY+ihESufHt0Iai8Wq6ha0bJMeDwhX66FkNII+OtYC2 a5Kg== X-Gm-Message-State: AJcUukfEC03RlIx/bfM3HvEGD5c2DBo7iKdZwwNZfvd9rSxy24cSNcjF g7Sd+U0efL7l8XBn6p7Bog0= X-Google-Smtp-Source: ALg8bN4uh6N/vGnYj6e77ASQ156CDYfeDLH4RIGoxQMPKL63Za/IRg3PMiiLKbEG6yqPBgQgsVZfXQ== X-Received: by 2002:a63:6984:: with SMTP id e126mr8985881pgc.143.1548397824671; Thu, 24 Jan 2019 22:30:24 -0800 (PST) Received: from cpu459.localdomain ([203.196.161.90]) by smtp.gmail.com with ESMTPSA id x19sm37384793pfk.14.2019.01.24.22.30.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 22:30:24 -0800 (PST) From: Siva Rebbagondla To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Rishikesh Basu , Siva Rebbagondla , Ganapathiraju Kondraju , krishna.pedda@redpinesignals.com Subject: [PATCH 3/5] rsi: fix wowlan wakeup issue for hibernate(S4) Date: Fri, 25 Jan 2019 12:00:00 +0530 Message-Id: <1548397802-12180-4-git-send-email-siva8118@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1548397802-12180-1-git-send-email-siva8118@gmail.com> References: <1548397802-12180-1-git-send-email-siva8118@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Siva Rebbagondla At SDIO restore ieee80211_restart_hw() is getting called to restart all MAC operations. This step is not required. Returning 1 from mac80211_resume() will serve this purpose. Signed-off-by: Siva Rebbagondla --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 8 ++++++-- drivers/net/wireless/rsi/rsi_91x_sdio.c | 1 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c index aded1ae..8d1282f 100644 --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c @@ -1938,8 +1938,12 @@ static int rsi_mac80211_resume(struct ieee80211_hw *hw) rsi_dbg(INFO_ZONE, "%s: mac80211 resume\n", __func__); - if (common->hibernate_resume) - return 0; + if (common->hibernate_resume) { + /* Device need a complete restart of all MAC operations. + * returning 1 will serve this purpose. + */ + return 1; + } mutex_lock(&common->mutex); rsi_send_wowlan_request(common, 0, 0); diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c index 59ff778..3375d64 100644 --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1395,7 +1395,6 @@ static int rsi_restore(struct device *dev) common->iface_down = true; adapter->sc_nvifs = 0; - ieee80211_restart_hw(adapter->hw); common->wow_flags = 0; common->iface_down = false;