| Message ID | 1555406865-21514-1-git-send-email-wgong@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: add support for simulate crash on SDIO chip | expand |
On Tue, Apr 16, 2019 at 5:28 PM Wen Gong <wgong@codeaurora.org> wrote: > > The command to simulate firmware crash: > echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash > > It will send WMI_FORCE_FW_HANG_ASSERT to firmware, then it will trigger > CPU interrupt status register for SDIO chip, ath10k driver need to > configure it while enable SDIO interrupt, otherwise ath10k driver will > not get the assert error info. > > After this change, it will success for simulate firmware crash. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-00007-QCARMSWP-1. > > Signed-off-by: Wen Gong <wgong@codeaurora.org> > --- > drivers/net/wireless/ath/ath10k/hw.h | 1 + > drivers/net/wireless/ath/ath10k/sdio.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h > index 7131499..60521ed 100644 > --- a/drivers/net/wireless/ath/ath10k/hw.h > +++ b/drivers/net/wireless/ath/ath10k/hw.h > @@ -1095,6 +1095,7 @@ struct ath10k_hw_ops { > #define MBOX_CPU_INT_STATUS_ENABLE_ADDRESS 0x00000819 > #define MBOX_CPU_INT_STATUS_ENABLE_BIT_LSB 0 > #define MBOX_CPU_INT_STATUS_ENABLE_BIT_MASK 0x000000ff > +#define MBOX_CPU_STATUS_ENABLE_ASSERT_MASK 0x00000001 > #define MBOX_ERROR_STATUS_ENABLE_ADDRESS 0x0000081a > #define MBOX_ERROR_STATUS_ENABLE_RX_UNDERFLOW_LSB 1 > #define MBOX_ERROR_STATUS_ENABLE_RX_UNDERFLOW_MASK 0x00000002 > diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c > index fae56c6..78a2f3b 100644 > --- a/drivers/net/wireless/ath/ath10k/sdio.c > +++ b/drivers/net/wireless/ath/ath10k/sdio.c > @@ -850,6 +850,8 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar) > > out: > mutex_unlock(&irq_data->mtx); > + ath10k_err(ar, "firmware crashed!\n"); > + queue_work(ar->workqueue, &ar->restart_work); Err, so you consider _any_ CPU interrupt to be caused by the FW crashing? Is that correct? If so, please at least add a comment. Otherwise, maybe you should run this only if MBOX_CPU_STATUS_ENABLE_ASSERT_MASK is set in cpu_int_status? > return ret; > } > > @@ -1495,8 +1497,10 @@ static int ath10k_sdio_hif_enable_intrs(struct ath10k *ar) > regs->int_status_en |= > FIELD_PREP(MBOX_INT_STATUS_ENABLE_MBOX_DATA_MASK, 1); > > - /* Set up the CPU Interrupt status Register */ > - regs->cpu_int_status_en = 0; > + /* Set up the CPU Interrupt Status Register, enable CPU sourced interrupt #0 > + * #0 is used for report assertion from target > + */ > + regs->cpu_int_status_en = FIELD_PREP(MBOX_CPU_STATUS_ENABLE_ASSERT_MASK, 1); > > /* Set up the Error Interrupt status Register */ > regs->err_int_status_en = > -- > 1.9.1 >
> -----Original Message----- > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Nicolas > Boichat > Sent: Monday, April 29, 2019 1:21 PM > To: Wen Gong <wgong@codeaurora.org> > Cc: Claire Chang <tientzu@chromium.org>; linux-wireless@vger.kernel.org; > ath10k@lists.infradead.org > Subject: [EXT] Re: [PATCH] ath10k: add support for simulate crash on SDIO > chip > > Err, so you consider _any_ CPU interrupt to be caused by the FW > crashing? Is that correct? If so, please at least add a comment. > > Otherwise, maybe you should run this only if > MBOX_CPU_STATUS_ENABLE_ASSERT_MASK is set in cpu_int_status? > > > return ret; > > } > > Hi Nicolas, New patch has uploaded for the change https://patchwork.kernel.org/patch/10921341/ [v2] ath10k: add support for simulate crash on SDIO chip https://patchwork.kernel.org/patch/10955189/ [v3] ath10k: add support for firmware crash recovery on SDIO chip
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h index 7131499..60521ed 100644 --- a/drivers/net/wireless/ath/ath10k/hw.h +++ b/drivers/net/wireless/ath/ath10k/hw.h @@ -1095,6 +1095,7 @@ struct ath10k_hw_ops { #define MBOX_CPU_INT_STATUS_ENABLE_ADDRESS 0x00000819 #define MBOX_CPU_INT_STATUS_ENABLE_BIT_LSB 0 #define MBOX_CPU_INT_STATUS_ENABLE_BIT_MASK 0x000000ff +#define MBOX_CPU_STATUS_ENABLE_ASSERT_MASK 0x00000001 #define MBOX_ERROR_STATUS_ENABLE_ADDRESS 0x0000081a #define MBOX_ERROR_STATUS_ENABLE_RX_UNDERFLOW_LSB 1 #define MBOX_ERROR_STATUS_ENABLE_RX_UNDERFLOW_MASK 0x00000002 diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index fae56c6..78a2f3b 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -850,6 +850,8 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar) out: mutex_unlock(&irq_data->mtx); + ath10k_err(ar, "firmware crashed!\n"); + queue_work(ar->workqueue, &ar->restart_work); return ret; } @@ -1495,8 +1497,10 @@ static int ath10k_sdio_hif_enable_intrs(struct ath10k *ar) regs->int_status_en |= FIELD_PREP(MBOX_INT_STATUS_ENABLE_MBOX_DATA_MASK, 1); - /* Set up the CPU Interrupt status Register */ - regs->cpu_int_status_en = 0; + /* Set up the CPU Interrupt Status Register, enable CPU sourced interrupt #0 + * #0 is used for report assertion from target + */ + regs->cpu_int_status_en = FIELD_PREP(MBOX_CPU_STATUS_ENABLE_ASSERT_MASK, 1); /* Set up the Error Interrupt status Register */ regs->err_int_status_en =
The command to simulate firmware crash: echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash It will send WMI_FORCE_FW_HANG_ASSERT to firmware, then it will trigger CPU interrupt status register for SDIO chip, ath10k driver need to configure it while enable SDIO interrupt, otherwise ath10k driver will not get the assert error info. After this change, it will success for simulate firmware crash. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00007-QCARMSWP-1. Signed-off-by: Wen Gong <wgong@codeaurora.org> --- drivers/net/wireless/ath/ath10k/hw.h | 1 + drivers/net/wireless/ath/ath10k/sdio.c | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-)