From patchwork Mon Apr 22 02:47:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wright Feng X-Patchwork-Id: 10910585 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF3DA1575 for ; Mon, 22 Apr 2019 02:47:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD359286B9 for ; Mon, 22 Apr 2019 02:47:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A1AF286D3; Mon, 22 Apr 2019 02:47:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11CBC286B9 for ; Mon, 22 Apr 2019 02:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbfDVCrb (ORCPT ); Sun, 21 Apr 2019 22:47:31 -0400 Received: from mail-eopbgr690137.outbound.protection.outlook.com ([40.107.69.137]:62390 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726284AbfDVCrb (ORCPT ); Sun, 21 Apr 2019 22:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cypress.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/tW2+ebD7I3OnlCUqqhJPFOGb9SA6FzaeQFrxzsyQGA=; b=NAf0RcDkaatGAJnmLOgzwvMH0NdJEUXai04FBkT8lMKT4Kk65Sz6vMbmlgFPW6BFYP6Mf7vonACdf4Cg59dkaUIX28tNqMZ5ED7zq/i5J8cD/Y6QYKLdSSNTW1IsD5ufCrfo/mcBKkoF+jjuOvLGZQWsOS64OKEtx6kSfuf2IRQ= Received: from MN2PR06MB5806.namprd06.prod.outlook.com (20.179.145.207) by MN2PR06MB6192.namprd06.prod.outlook.com (20.178.247.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 02:47:28 +0000 Received: from MN2PR06MB5806.namprd06.prod.outlook.com ([fe80::1ca6:d3b:6b7a:65cb]) by MN2PR06MB5806.namprd06.prod.outlook.com ([fe80::1ca6:d3b:6b7a:65cb%5]) with mapi id 15.20.1813.017; Mon, 22 Apr 2019 02:47:28 +0000 From: Wright Feng To: "arend.vanspriel@broadcom.com" , "franky.lin@broadcom.com" , "hante.meuleman@broadcom.com" , "kvalo@codeaurora.org" , Chi-Hsien Lin CC: Wright Feng , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" Subject: [PATCH] brcmfmac: remove the duplicate line of sending mail box interrupt Thread-Topic: [PATCH] brcmfmac: remove the duplicate line of sending mail box interrupt Thread-Index: AQHU+LW5CM9dcu+U8kq8oKEmsooSEw== Date: Mon, 22 Apr 2019 02:47:28 +0000 Message-ID: <1555901236-145920-1-git-send-email-wright.feng@cypress.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR03CA0032.namprd03.prod.outlook.com (2603:10b6:a02:a8::45) To MN2PR06MB5806.namprd06.prod.outlook.com (2603:10b6:208:127::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wright.Feng@cypress.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.1.0 x-originating-ip: [12.110.209.245] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51c87ee6-c396-44f1-b49b-08d6c6ccdb99 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:MN2PR06MB6192; x-ms-traffictypediagnostic: MN2PR06MB6192: x-microsoft-antispam-prvs: x-forefront-prvs: 00159D1518 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(39860400002)(366004)(136003)(346002)(396003)(189003)(199004)(71190400001)(6636002)(71200400001)(110136005)(54906003)(6486002)(2906002)(6436002)(97736004)(66066001)(6116002)(2501003)(305945005)(7736002)(316002)(3846002)(14454004)(6512007)(25786009)(72206003)(478600001)(53936002)(44832011)(66446008)(86362001)(486006)(66556008)(476003)(6506007)(102836004)(386003)(73956011)(50226002)(5660300002)(64756008)(66476007)(66946007)(4744005)(36756003)(99286004)(81156014)(81166006)(186003)(14444005)(8676002)(2616005)(26005)(8936002)(256004)(68736007)(52116002)(2201001)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR06MB6192;H:MN2PR06MB5806.namprd06.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: cypress.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qXKVCnX0IoRco0OJy0ciMYFQYeIjWhySmNHFzdeN0a3C/91Xcz0HiqXxsEC93eEvwlrtloRKQgTtAIGPgMVmLE417Oh6n8JIuJZD6Wk+numAaydgjpeMlmPXpn55Wi3nwtrwWNlGRyPv8myYS3xqNaRQ93zDxpGmY5tNRH6ROKUU62C2qBQnVhTwOrZwB6QyAy7gUIqxKdb+jjGJ+kX0g9vvusKhoKuNA1T4ZbfUF7BkW1jckf13cj4Cr4JkO6XITlGxsAVxeQ+IFsjtACMMiQU6aEoWUahujfgnO0W1PdRIDHMN6hbknsbsb0YK6hyFg8bWihKR+GHEIXoqk+qwJwZYZ3SJ9BIonnlnaY11RF/5ZgEcyw4EgPaEOkDoAbIoyrTx/IR6XFIjc456m/P89a4rM8xxaojlfeF1O6jVst4= MIME-Version: 1.0 X-OriginatorOrg: cypress.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51c87ee6-c396-44f1-b49b-08d6c6ccdb99 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2019 02:47:28.2627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 011addfc-2c09-450d-8938-e0bbc2dd2376 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR06MB6192 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The line is duplicate so remove it from pcie.c. We don't need to send host to dongle mail box interrupt twice after writing data. Signed-off-by: Wright Feng --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index fd3968f..ca619a9 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -698,7 +698,6 @@ brcmf_pcie_send_mb_data(struct brcmf_pciedev_info *devinfo, u32 htod_mb_data) brcmf_pcie_write_tcm32(devinfo, addr, htod_mb_data); pci_write_config_dword(devinfo->pdev, BRCMF_PCIE_REG_SBMBX, 1); - pci_write_config_dword(devinfo->pdev, BRCMF_PCIE_REG_SBMBX, 1); return 0; }