Message ID | 1562079961-15527-2-git-send-email-sgruszka@redhat.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Felix Fietkau |
Headers | show |
Series | mt76: usb: alignment and endianes improvements | expand |
On Tue, Jul 02, 2019 at 05:05:59PM +0200, Stanislaw Gruszka wrote: > In contrast to mt76_wr() which we use to program registers, > on mt76_wr_copy() we should not change endian of the data. > > Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer") > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> > --- > drivers/net/wireless/mediatek/mt76/usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c > index 87ecbe290f99..db90ec6b8775 100644 > --- a/drivers/net/wireless/mediatek/mt76/usb.c > +++ b/drivers/net/wireless/mediatek/mt76/usb.c > @@ -165,11 +165,11 @@ static void mt76u_copy(struct mt76_dev *dev, u32 offset, > > mutex_lock(&usb->usb_ctrl_mtx); > for (i = 0; i < DIV_ROUND_UP(len, 4); i++) { > - put_unaligned_le32(val[i], usb->data); > + put_unaligned(val[i], usb->data); This is bug as put_unaligned() use size based second argument pointer type, correct version should looks like this: put_unaligned(val[i], (u32 *) usb->data); Stanislaw
diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index 87ecbe290f99..db90ec6b8775 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -165,11 +165,11 @@ static void mt76u_copy(struct mt76_dev *dev, u32 offset, mutex_lock(&usb->usb_ctrl_mtx); for (i = 0; i < DIV_ROUND_UP(len, 4); i++) { - put_unaligned_le32(val[i], usb->data); + put_unaligned(val[i], usb->data); ret = __mt76u_vendor_request(dev, MT_VEND_MULTI_WRITE, USB_DIR_OUT | USB_TYPE_VENDOR, 0, offset + i * 4, usb->data, - sizeof(__le32)); + sizeof(u32)); if (ret < 0) break; }
In contrast to mt76_wr() which we use to program registers, on mt76_wr_copy() we should not change endian of the data. Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer") Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> --- drivers/net/wireless/mediatek/mt76/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)