| Message ID | 1565167700-22501-2-git-send-email-yhchuang@realtek.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | None | expand |
On 8/7/2019 10:48 AM, yhchuang@realtek.com wrote: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > Add WoW firmware to support entering Wake on WirelessLAN mode > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > --- > > v1 -> v2 > * update WHENCE file for new added firmware > > WHENCE | 1 + > rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes > 2 files changed, 1 insertion(+) > create mode 100755 rtw88/rtw8822c_wow_fw.bin Just wondering: Is this a good approach? What firmware should distros pick? Is there a trade-off affecting other wifi functionality when using WoW firmware? Regards, Arend
> From: Arend Van Spriel [mailto:arend.vanspriel@broadcom.com] > > On 8/7/2019 10:48 AM, yhchuang@realtek.com wrote: > > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > > > Add WoW firmware to support entering Wake on WirelessLAN mode > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > > --- > > > > v1 -> v2 > > * update WHENCE file for new added firmware > > > > WHENCE | 1 + > > rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes > > 2 files changed, 1 insertion(+) > > create mode 100755 rtw88/rtw8822c_wow_fw.bin > > Just wondering: Is this a good approach? What firmware should distros > pick? Is there a trade-off affecting other wifi functionality when using > WoW firmware? > If distros want to use WOW, they should pick both. For Realtek devices such as RTL8822CE, it needs to "change/re-download" the wow firmware to suspend with WOW functionalities. When resume, switch back to normal firmware to run "normally". I think the reason is the firmware size restriction. For newer devices, maybe there is a larger space for firmware, and we don't need to swap the FW like this :) Yan-Hsuan
On 8/7/2019 11:53 AM, Tony Chuang wrote: >> From: Arend Van Spriel [mailto:arend.vanspriel@broadcom.com] >> >> On 8/7/2019 10:48 AM, yhchuang@realtek.com wrote: >>> From: Yan-Hsuan Chuang <yhchuang@realtek.com> >>> >>> Add WoW firmware to support entering Wake on WirelessLAN mode >>> >>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> >>> --- >>> >>> v1 -> v2 >>> * update WHENCE file for new added firmware >>> >>> WHENCE | 1 + >>> rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes >>> 2 files changed, 1 insertion(+) >>> create mode 100755 rtw88/rtw8822c_wow_fw.bin >> >> Just wondering: Is this a good approach? What firmware should distros >> pick? Is there a trade-off affecting other wifi functionality when using >> WoW firmware? >> > > If distros want to use WOW, they should pick both. > > For Realtek devices such as RTL8822CE, it needs to "change/re-download" > the wow firmware to suspend with WOW functionalities. When resume, > switch back to normal firmware to run "normally". > > I think the reason is the firmware size restriction. For newer devices, > maybe there is a larger space for firmware, and we don't need to swap > the FW like this :) Interesting approach and I would mention this in the commit message or add a README in rtw88 folder explaining it. Not sure whether distros look at commit messages. Regards, Arend
On Wed, Aug 7, 2019 at 6:15 AM Arend Van Spriel <arend.vanspriel@broadcom.com> wrote: > > > > On 8/7/2019 11:53 AM, Tony Chuang wrote: > >> From: Arend Van Spriel [mailto:arend.vanspriel@broadcom.com] > >> > >> On 8/7/2019 10:48 AM, yhchuang@realtek.com wrote: > >>> From: Yan-Hsuan Chuang <yhchuang@realtek.com> > >>> > >>> Add WoW firmware to support entering Wake on WirelessLAN mode > >>> > >>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > >>> --- > >>> > >>> v1 -> v2 > >>> * update WHENCE file for new added firmware > >>> > >>> WHENCE | 1 + > >>> rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes > >>> 2 files changed, 1 insertion(+) > >>> create mode 100755 rtw88/rtw8822c_wow_fw.bin > >> > >> Just wondering: Is this a good approach? What firmware should distros > >> pick? Is there a trade-off affecting other wifi functionality when using > >> WoW firmware? > >> > > > > If distros want to use WOW, they should pick both. > > > > For Realtek devices such as RTL8822CE, it needs to "change/re-download" > > the wow firmware to suspend with WOW functionalities. When resume, > > switch back to normal firmware to run "normally". > > > > I think the reason is the firmware size restriction. For newer devices, > > maybe there is a larger space for firmware, and we don't need to swap > > the FW like this :) > > Interesting approach and I would mention this in the commit message or > add a README in rtw88 folder explaining it. Not sure whether distros > look at commit messages. A README would indeed be nice. Can you do a v3 with that included? josh
diff --git a/WHENCE b/WHENCE index 112ffd8..41494ab 100644 --- a/WHENCE +++ b/WHENCE @@ -2791,6 +2791,7 @@ Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <yhchuang@realtek.com> File: rtw88/rtw8822b_fw.bin File: rtw88/rtw8822c_fw.bin +File: rtw88/rtw8822c_wow_fw.bin Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details. diff --git a/rtw88/rtw8822c_wow_fw.bin b/rtw88/rtw8822c_wow_fw.bin new file mode 100755 index 0000000000000000000000000000000000000000..628c7ee59067225c9cbbc87a629ff5fc1dc7c1b0