| Message ID | 1593194502-13164-2-git-send-email-pillair@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8f1553694551f36441e6c4e66e4ccc24ae891994 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: Add chain-1 voltage regulator voting | expand |
Hi, On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Overall though: aren't you missing a whole lot of CCs? Have you tried using get_maintainer? > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 65ee68e..b7188d3 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -65,7 +65,8 @@ Optional properties: > the length can vary between hw versions. > - <supply-name>-supply: handle to the regulator device tree node > optional "supply-name" are "vdd-0.8-cx-mx", > - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". > + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" > + and "vdd-3.3-ch1". nit that could probably be fixed by maintainer when applying: missing comma at the end of "vdd-3.3-ch0" I will also note that this file is in dire need of being converted to yaml. Pretty soon I think people are going to start disallowing changes to the bindings that haven't been converted to yaml so you probably want to get a jump start on it so future patches aren't stalled. In any case: Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Fri, 26 Jun 2020 23:31:41 +0530, Rakesh Pillai wrote: > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
Rakesh Pillai <pillair@codeaurora.org> wrote: > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> 2 patches applied to ath-next branch of ath.git, thanks. 8f1553694551 dt: bindings: Add new regulator as optional property for WCN3990 9e69fe31ca9a ath10k: Add support for chain1 regulator supply voting
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 65ee68e..b7188d3 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -65,7 +65,8 @@ Optional properties: the length can vary between hw versions. - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" are "vdd-0.8-cx-mx", - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" + and "vdd-3.3-ch1". - memory-region: Usage: optional Value type: <phandle> @@ -204,6 +205,7 @@ wifi@18000000 { vdd-1.8-xo-supply = <&vreg_l7a_1p8>; vdd-1.3-rfa-supply = <&vreg_l17a_1p3>; vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; + vdd-3.3-ch1-supply = <&vreg_l26a_3p3>; memory-region = <&wifi_msa_mem>; iommus = <&apps_smmu 0x0040 0x1>; qcom,msa-fixed-perm;
Add an additional regulator supply as an optional property for WCN3990. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)