| Message ID | 1595586052-16081-4-git-send-email-loic.poulain@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1c20560607e6e142af76b9bd57e275b9053958a1 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wcn36xx misc fixes | expand |
Ramon Fried <ramon.fried@gmail.com> writes: > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org> > wrote: > > Increase the short/long retry limit to 15 in order to impove TX > robustness in noisy/busy environment. 15 is the default value > defined in the downstream driver. Observed number of ack timeout > is reduced with this change. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > --- > drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c > b/drivers/net/wireless/ath/wcn36xx/smd.c > index 59f9f53..908cc6c 100644 > --- a/drivers/net/wireless/ath/wcn36xx/smd.c > +++ b/drivers/net/wireless/ath/wcn36xx/smd.c > @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] > = { > WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000), > WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64), > WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347), > - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6), > - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6), > + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15), > + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15), > WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000), > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5), > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10), > -- > 2.7.4 > > > > > These set of patches fixed my connectivity issues with TP-Link DECO > routers. > Acked-By: Ramon Fried <rfried.dev@gmail.com> HTML emails are dropped by the list, please use text/plain only.
Yes. small glitch. sorry. On Fri, Jul 24, 2020 at 4:12 PM Kalle Valo <kvalo@codeaurora.org> wrote: > > Ramon Fried <ramon.fried@gmail.com> writes: > > > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org> > > wrote: > > > > Increase the short/long retry limit to 15 in order to impove TX > > robustness in noisy/busy environment. 15 is the default value > > defined in the downstream driver. Observed number of ack timeout > > is reduced with this change. > > > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > --- > > drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c > > b/drivers/net/wireless/ath/wcn36xx/smd.c > > index 59f9f53..908cc6c 100644 > > --- a/drivers/net/wireless/ath/wcn36xx/smd.c > > +++ b/drivers/net/wireless/ath/wcn36xx/smd.c > > @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] > > = { > > WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000), > > WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64), > > WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347), > > - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6), > > - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6), > > + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15), > > + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15), > > WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000), > > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5), > > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10), > > -- > > 2.7.4 > > > > > > > > > > These set of patches fixed my connectivity issues with TP-Link DECO > > routers. > > Acked-By: Ramon Fried <rfried.dev@gmail.com> > > HTML emails are dropped by the list, please use text/plain only. > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 59f9f53..908cc6c 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = { WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000), WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64), WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347), - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6), - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6), + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15), + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15), WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000), WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5), WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
Increase the short/long retry limit to 15 in order to impove TX robustness in noisy/busy environment. 15 is the default value defined in the downstream driver. Observed number of ack timeout is reduced with this change. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)