diff mbox series

mt76: Fixed kernel test robot warning

Message ID 1607542617-4005-1-git-send-email-jrdr.linux@gmail.com (mailing list archive)
State Accepted
Commit 7f469b6dc484cd5b2ea61763607892626afc2b21
Delegated to: Kalle Valo
Headers show
Series mt76: Fixed kernel test robot warning | expand

Commit Message

Souptick Joarder Dec. 9, 2020, 7:36 p.m. UTC 
Kernel test robot throws below warning ->

   drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':
>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
>> set but not used [-Wunused-but-set-variable]
     499 |  struct mt76_queue *q;
         |                     ^

This patch will silence this warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/net/wireless/mediatek/mt76/tx.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kalle Valo Dec. 10, 2020, 7:16 a.m. UTC | #1 
Souptick Joarder <jrdr.linux@gmail.com> writes:

> Kernel test robot throws below warning ->
>
>    drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule':
>>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
>>> set but not used [-Wunused-but-set-variable]
>      499 |  struct mt76_queue *q;
>          |                     ^
>
> This patch will silence this warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

I would like to take this directly to wireless-drivers-next, ok?

I'll also change the title to:

mt76: remove unused variable q
Souptick Joarder Dec. 11, 2020, 6:51 a.m. UTC | #2 
On Thu, Dec 10, 2020 at 12:46 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Souptick Joarder <jrdr.linux@gmail.com> writes:
>
> > Kernel test robot throws below warning ->
> >
> >    drivers/net/wireless/mediatek/mt76/tx.c: In function
> > 'mt76_txq_schedule':
> >>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
> >>> set but not used [-Wunused-but-set-variable]
> >      499 |  struct mt76_queue *q;
> >          |                     ^
> >
> > This patch will silence this warning.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> I would like to take this directly to wireless-drivers-next, ok?

Ok.
>
> I'll also change the title to:
>
> mt76: remove unused variable q
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Kalle Valo Dec. 11, 2020, 6:28 p.m. UTC | #3 
Souptick Joarder <jrdr.linux@gmail.com> wrote:

> Kernel test robot reported warning:
> 
>    drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule':
> >> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
> >> set but not used [-Wunused-but-set-variable]
>      499 |  struct mt76_queue *q;
>          |                     ^
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

7f469b6dc484 mt76: remove unused variable q
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
index 1e20afb..25627e7 100644
--- a/drivers/net/wireless/mediatek/mt76/tx.c
+++ b/drivers/net/wireless/mediatek/mt76/tx.c
@@ -504,14 +504,11 @@  void mt76_tx_complete_skb(struct mt76_dev *dev, u16 wcid_idx, struct sk_buff *sk
 
 void mt76_txq_schedule(struct mt76_phy *phy, enum mt76_txq_id qid)
 {
-	struct mt76_queue *q;
 	int len;
 
 	if (qid >= 4)
 		return;
 
-	q = phy->q_tx[qid];
-
 	rcu_read_lock();
 
 	do {