| Message ID | 1620171478-35679-4-git-send-email-bbhatt@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | BHI/BHIe improvements for MHI power purposes | expand |
On 5/4/2021 5:37 PM, Bhaumik Bhatt wrote: > Make controller driver specify the MMIO register region length > for range checking of BHI or BHIe space. This can help validate > that offsets are in acceptable memory region or not and avoid any > boot-up issues due to BHI or BHIe memory accesses. > > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org> > --- > include/linux/mhi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index 944aa3a..f6901db 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -293,6 +293,7 @@ struct mhi_controller_config { > * @mhi_dev: MHI device instance for the controller > * @debugfs_dentry: MHI controller debugfs directory > * @regs: Base address of MHI MMIO register space (required) > + * @reg_len: Length of the MHI MMIO region (required) I believe this should be moved so that it matches the ordering of the struct fields below. With the adjustment, you can add my reviewed tag to this. > * @bhi: Points to base of MHI BHI register space > * @bhie: Points to base of MHI BHIe register space > * @wake_db: MHI WAKE doorbell register address > @@ -386,6 +387,7 @@ struct mhi_controller { > size_t rddm_size; > size_t sbl_size; > size_t seg_len; > + size_t reg_len; > struct image_info *fbc_image; > struct image_info *rddm_image; > struct mhi_chan *mhi_chan; >
diff --git a/include/linux/mhi.h b/include/linux/mhi.h index 944aa3a..f6901db 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -293,6 +293,7 @@ struct mhi_controller_config { * @mhi_dev: MHI device instance for the controller * @debugfs_dentry: MHI controller debugfs directory * @regs: Base address of MHI MMIO register space (required) + * @reg_len: Length of the MHI MMIO region (required) * @bhi: Points to base of MHI BHI register space * @bhie: Points to base of MHI BHIe register space * @wake_db: MHI WAKE doorbell register address @@ -386,6 +387,7 @@ struct mhi_controller { size_t rddm_size; size_t sbl_size; size_t seg_len; + size_t reg_len; struct image_info *fbc_image; struct image_info *rddm_image; struct mhi_chan *mhi_chan;
Make controller driver specify the MMIO register region length for range checking of BHI or BHIe space. This can help validate that offsets are in acceptable memory region or not and avoid any boot-up issues due to BHI or BHIe memory accesses. Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org> --- include/linux/mhi.h | 2 ++ 1 file changed, 2 insertions(+)