diff mbox series

[RFC,2/4] wifi: cfg80211: RU puncturing bitmap

Message ID 1670006154-6092-3-git-send-email-quic_msinada@quicinc.com (mailing list archive)
State RFC
Delegated to: Johannes Berg
Headers show
Series Static RU Puncturing | expand

Commit Message

Muna Sinada Dec. 2, 2022, 6:35 p.m. UTC 
From: Aloka Dixit <quic_alokad@quicinc.com>

RU puncturing bitmap consists of 16 bits, each bit corresponding to
a 20 MHz channel in the operating bandwidth. Lowest bit corresponds to
the lowest frequency. Bit set to 1 indicates that the channel is
punctured otherwise it is active.

Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
Co-developed-by: Muna Sinada <quic_msinada@quicinc.com>
Signed-off-by: Muna Sinada <quic_msinada@quicinc.com>
---
 include/net/cfg80211.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Johannes Berg Jan. 19, 2023, 3:34 p.m. UTC | #1 
On Fri, 2022-12-02 at 10:35 -0800, Muna Sinada wrote:
> 
> + * @ru_punct_bitmap: RU puncturing bitmap. Each bit represents a 20 MHz channel
> + *	with lowest bit corresponding to the lowest frequency. Bit set to 1
> + *	indicates that the channel is punctured, otherwise the channel is active
> + * @ru_punct_bitmap_supp_he: Indicates whether RU puncturing bitmap validation
> + *	should include OFDMA bitmaps.

Why _supp_he and not _supp_ofdma? Is it restricted to HE? What about
EHT?

I'm also not really sure what that kernel-doc means for the _supp_he
part?


Also this patch is basically empty - please squash appropriately.

johannes
diff mbox series

Patch

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index cb856b06a3ac..b4ca8c2118ff 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -698,6 +698,11 @@  static inline void wiphy_read_of_freq_limits(struct wiphy *wiphy)
  *	belonging to that MU-MIMO groupID; %NULL if not changed
  * @vht_mumimo_follow_addr: MU-MIMO follow address, used for monitoring
  *	MU-MIMO packets going to the specified station; %NULL if not changed
+ * @ru_punct_bitmap: RU puncturing bitmap. Each bit represents a 20 MHz channel
+ *	with lowest bit corresponding to the lowest frequency. Bit set to 1
+ *	indicates that the channel is punctured, otherwise the channel is active
+ * @ru_punct_bitmap_supp_he: Indicates whether RU puncturing bitmap validation
+ *	should include OFDMA bitmaps.
  */
 struct vif_params {
 	u32 flags;
@@ -705,6 +710,8 @@  struct vif_params {
 	u8 macaddr[ETH_ALEN];
 	const u8 *vht_mumimo_groups;
 	const u8 *vht_mumimo_follow_addr;
+	u16 ru_punct_bitmap;
+	bool ru_punct_bitmap_supp_he;
 };
 
 /**
@@ -5732,6 +5739,12 @@  static inline void wiphy_unlock(struct wiphy *wiphy)
  * @links: array of %IEEE80211_MLD_MAX_NUM_LINKS elements containing @addr
  *	@ap and @client for each link
  * @valid_links: bitmap describing what elements of @links are valid
+ * @ru_punct_bitmap: (private) RU puncturing bitmap. Each bit represents a
+ *	20 MHz channel with lowest bit corresponding to the lowest frequency.
+ *	Bit set to 1 indicates that the channel is punctured, otherwise the
+ *	channel is active
+ * @ru_punct_bitmap_supp_he: (private) Indicates whether RU puncturing bitmap
+ *	validation should include OFDMA bitmaps.
  */
 struct wireless_dev {
 	struct wiphy *wiphy;
@@ -5846,6 +5859,9 @@  struct wireless_dev {
 		};
 	} links[IEEE80211_MLD_MAX_NUM_LINKS];
 	u16 valid_links;
+
+	u16 ru_punct_bitmap;
+	bool ru_punct_bitmap_supp_he;
 };
 
 static inline const u8 *wdev_address(struct wireless_dev *wdev)