From patchwork Thu Aug 6 08:52:42 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Roskin X-Patchwork-Id: 39559 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n768rW0p011871 for ; Thu, 6 Aug 2009 08:53:32 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754413AbZHFIx2 (ORCPT ); Thu, 6 Aug 2009 04:53:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753113AbZHFIx2 (ORCPT ); Thu, 6 Aug 2009 04:53:28 -0400 Received: from c60.cesmail.net ([216.154.195.49]:1746 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbZHFIx2 (ORCPT ); Thu, 6 Aug 2009 04:53:28 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 06 Aug 2009 04:53:11 -0400 Received: from ct.roinet.com (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 98CB034C6A; Thu, 6 Aug 2009 05:05:32 -0400 (EDT) Subject: [PATCH] cfg80211: fix disassociation warning due to misuse of wdev->current_bss To: Johannes Berg , linux-wireless@vger.kernel.org, John Linville From: Pavel Roskin Date: Thu, 06 Aug 2009 04:52:42 -0400 Message-ID: <20090806085242.23637.82992.stgit@ct.roinet.com> User-Agent: StGit/0.15-rc1-11-g9876 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org WARN_ON was triggered at mlme.c:213 when dissociating from an AP. wdev->current_bss->pub.bssid should be used in place of wdev->current_bss for BSSID comparison. Signed-off-by: Pavel Roskin Reviewed-by: Johannes Berg --- net/wireless/mlme.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c index 525e8e2..b44b6c0 100644 --- a/net/wireless/mlme.c +++ b/net/wireless/mlme.c @@ -198,7 +198,7 @@ static void __cfg80211_send_disassoc(struct net_device *dev, return; if (wdev->current_bss && - memcmp(wdev->current_bss, bssid, ETH_ALEN) == 0) { + memcmp(wdev->current_bss->pub.bssid, bssid, ETH_ALEN) == 0) { for (i = 0; i < MAX_AUTH_BSSES; i++) { if (wdev->authtry_bsses[i] || wdev->auth_bsses[i]) continue;