From patchwork Sun Nov 22 18:16:47 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jussi Kivilinna X-Patchwork-Id: 62069 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nAMIGoLn000960 for ; Sun, 22 Nov 2009 18:16:50 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980AbZKVSQn (ORCPT ); Sun, 22 Nov 2009 13:16:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753234AbZKVSQn (ORCPT ); Sun, 22 Nov 2009 13:16:43 -0500 Received: from sirokuusama.dnainternet.net ([83.102.40.133]:46164 "EHLO sirokuusama.dnainternet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbZKVSQm (ORCPT ); Sun, 22 Nov 2009 13:16:42 -0500 Received: from localhost (localhost [127.0.0.1]) by sirokuusama.dnainternet.net (Postfix) with ESMTP id B77552C8D5; Sun, 22 Nov 2009 20:16:47 +0200 (EET) X-Virus-Scanned: DNA Postiturva at dnainternet.net X-Spam-Flag: NO X-Spam-Score: 1.218 X-Spam-Level: * X-Spam-Status: No, score=1.218 tagged_above=-9999 required=6 tests=[AWL=-1.484, HELO_LH_HOME=2.602, RDNS_DYNAMIC=0.1] Received: from sirokuusama.dnainternet.net ([83.102.40.133]) by localhost (sirokuusama.dnainternet.net [127.0.0.1]) (amavisd-new, port 10041) with ESMTP id qbAAZbPDI-2h; Sun, 22 Nov 2009 20:16:47 +0200 (EET) Received: from kirsikkapuu.dnainternet.net (kirsikkapuu.dnainternet.net [83.102.40.214]) by sirokuusama.dnainternet.net (Postfix) with ESMTP id 7F8EC2C8B8; Sun, 22 Nov 2009 20:16:47 +0200 (EET) Received: from fate.lan (dyn2-85-23-163-235.psoas.suomi.net [85.23.163.235]) by kirsikkapuu.dnainternet.net (Postfix) with ESMTP id 6C3697F008; Sun, 22 Nov 2009 20:16:47 +0200 (EET) From: Jussi Kivilinna Subject: [PATCH 2/2] rndis_wlan: disable stall workaround To: "John W. Linville" Cc: linux-wireless@vger.kernel.org Date: Sun, 22 Nov 2009 20:16:47 +0200 Message-ID: <20091122181647.24641.86877.stgit@fate.lan> In-Reply-To: <20091122181642.24641.73461.stgit@fate.lan> References: <20091122181642.24641.73461.stgit@fate.lan> User-Agent: StGIT/0.14.2 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c index 8b09b04..2ecbedb 100644 --- a/drivers/net/wireless/rndis_wlan.c +++ b/drivers/net/wireless/rndis_wlan.c @@ -83,11 +83,11 @@ MODULE_PARM_DESC(roamdelta, "set roaming tendency: 0=aggressive, 1=moderate, " "2=conservative (default: moderate)"); -static int modparam_workaround_interval = 500; +static int modparam_workaround_interval; module_param_named(workaround_interval, modparam_workaround_interval, int, 0444); MODULE_PARM_DESC(workaround_interval, - "set stall workaround interval in msecs (default: 500)"); + "set stall workaround interval in msecs (0=disabled) (default: 0)"); /* various RNDIS OID defs */ @@ -2550,7 +2550,7 @@ static void rndis_device_poller(struct work_struct *work) /* Workaround transfer stalls on poor quality links. * TODO: find right way to fix these stalls (as stalls do not happen * with ndiswrapper/windows driver). */ - if (priv->last_qual <= 25) { + if (priv->param_workaround_interval > 0 && priv->last_qual <= 25) { /* Decrease stats worker interval to catch stalls. * faster. Faster than 400-500ms causes packet loss, * Slower doesn't catch stalls fast enough.