From patchwork Tue Sep 6 15:04:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Roskin X-Patchwork-Id: 1126572 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p86F4nnK028902 for ; Tue, 6 Sep 2011 15:04:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813Ab1IFPEe (ORCPT ); Tue, 6 Sep 2011 11:04:34 -0400 Received: from c60.cesmail.net ([216.154.195.49]:46143 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754780Ab1IFPE3 (ORCPT ); Tue, 6 Sep 2011 11:04:29 -0400 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 06 Sep 2011 11:04:27 -0400 Received: from mj (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 3F8F734C93; Tue, 6 Sep 2011 11:12:08 -0400 (EDT) Date: Tue, 6 Sep 2011 11:04:22 -0400 From: Pavel Roskin To: Justin Piszcz Cc: linux-wireless@vger.kernel.org, Alan Piszcz Subject: Re: 3.0.0: carl9170: drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]() Message-ID: <20110906110422.326f95c5@mj> In-Reply-To: References: X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 06 Sep 2011 15:04:49 +0000 (UTC) On Mon, 5 Sep 2011 17:53:06 -0400 (EDT) Justin Piszcz wrote: > Hello, > > Saw this on one of my Linux machines with a Linux (community > supported USB stick): > > [88927.073741] ------------[ cut here ]------------ > [88927.073762] WARNING: at drivers/net/wireless/ath/carl9170/tx.c:351 I'm dropping LKML from cc, no need to write there if there is a specialized mailing list. It looks like the bitmap code in carl9170 needs reviewing. I spotted one error immediately. bitmap_zero() takes the number of bits, not the number of long integers. Chances are not very high that it would help in your case, but here's the patch. I hope to give carl9170 some good testing before submitting that patch formally. carl9170: fix bitmap initialization From: Pavel Roskin bitmap_zero() takes the number of bits, not the long integers used to keep them. Signed-off-by: Pavel Roskin --- drivers/net/wireless/ath/carl9170/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c index af351ec..2f68747 100644 --- a/drivers/net/wireless/ath/carl9170/main.c +++ b/drivers/net/wireless/ath/carl9170/main.c @@ -1411,7 +1411,7 @@ static int carl9170_op_ampdu_action(struct ieee80211_hw *hw, sta_info->stats[tid].req = false; if (tid_info) { - bitmap_zero(tid_info->bitmap, CARL9170_BAW_SIZE); + bitmap_zero(tid_info->bitmap, CARL9170_BAW_BITS); tid_info->state = CARL9170_TID_STATE_IDLE; } rcu_read_unlock();