From patchwork Thu Jul 11 13:19:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Copeland X-Patchwork-Id: 2826340 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BDD40C0AB2 for ; Thu, 11 Jul 2013 13:21:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7FE6E2018A for ; Thu, 11 Jul 2013 13:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C3C320190 for ; Thu, 11 Jul 2013 13:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932071Ab3GKNUw (ORCPT ); Thu, 11 Jul 2013 09:20:52 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:45860 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755185Ab3GKNUv (ORCPT ); Thu, 11 Jul 2013 09:20:51 -0400 Received: by mail-ie0-f175.google.com with SMTP id a11so10500954iee.6 for ; Thu, 11 Jul 2013 06:20:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent:x-gm-message-state; bh=OTVBQ3cx319fogI9zAnJ641pJKQP9CidO7Rd7CzJNL4=; b=DxsA5jzXKDpyo2elAjf/fzicy1JwIcy+Ur+bSw1cW7Gk1Gx4SfAtRBWgIP6m0//MKX ETK/hkBfq0hM1+vYfAcoHEQPbQV2rpW16LUquszwB4LA9Yb1gT0N/jBMz049hGKe8FDc vCL8+bYiAE/MIO5Uu3CVWQGq+NnkuYgI4CPIV2C9qjV5HGikCBP52BWCLtiJJ6stiXHx 1jR9ooW6YwZBJgrQmdVM6kJmEhYKYuD2fqZiV5uol52/7R5317bAYD7ERVO8zFauDkC/ 32vcw/vB9u6NyHXHL1F8sl0aSpWHwZ+bu3C9PJ6cYpKAcxSjbEXfhCaBh42niQyBV66y Jndw== X-Received: by 10.50.79.167 with SMTP id k7mr13288992igx.56.1373548849955; Thu, 11 Jul 2013 06:20:49 -0700 (PDT) Received: from hash.lan (CPE0018e7fe5281-CM78cd8ec60a0d.cpe.net.cable.rogers.com. [99.242.255.161]) by mx.google.com with ESMTPSA id d14sm9905297igz.6.2013.07.11.06.20.48 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Jul 2013 06:20:48 -0700 (PDT) Received: from bob by hash.lan with local (Exim 4.80) (envelope-from ) id 1UxGmJ-0008GA-Sg; Thu, 11 Jul 2013 09:19:23 -0400 Date: Thu, 11 Jul 2013 09:19:13 -0400 From: Bob Copeland To: linux-wireless@vger.kernel.org, linville@tuxdriver.com Cc: ath5k-devel@lists.ath5k.org, mickflemm@gmail.com Subject: [PATCH] ath5k: fix extra set bit in multicast mask Message-ID: <20130711131913.GA31660@localhost> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQlYzofZmZu1um8Z3WayWrjI0GsYhHAb3Jrrp9oCsNEyu59ibu1Yc8lU1o8ng2DzhBCxi4WX Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Bit 32 was always set which looks to have been accidental, according to git history. Signed-off-by: Bob Copeland --- Just found this while reading old code -- I could maybe see bit 0 being special, but bit 32 seemed odd. Then looked back through the history and looks like it was accidentally added when prepare_multicast() was introduced; prior both were initialized to 0. drivers/net/wireless/ath/ath5k/mac80211-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath5k/mac80211-ops.c b/drivers/net/wireless/ath/ath5k/mac80211-ops.c index 06f86f4..f5f1bc7 100644 --- a/drivers/net/wireless/ath/ath5k/mac80211-ops.c +++ b/drivers/net/wireless/ath/ath5k/mac80211-ops.c @@ -325,7 +325,7 @@ ath5k_prepare_multicast(struct ieee80211_hw *hw, struct netdev_hw_addr *ha; mfilt[0] = 0; - mfilt[1] = 1; + mfilt[1] = 0; netdev_hw_addr_list_for_each(ha, mc_list) { /* calculate XOR of eight 6-bit values */