| Message ID | 20141114221221.GA35541@dtor-ws (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 11/14/14 23:12, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. Whoops, that is bad. Thanks for catching this. It probably needs to go to stable as well for 3.17 kernel. +Cc: stable@vger.kernel.org # v3.17 +Acked-by: Arend van Spriel <arend@broadcom.com> > Signed-off-by: Dmitry Torokhov<dtor@chromium.org> > --- > > Not tested, found by casual code inspection. > > drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b/drivers/net/wireless/brcm80211/brcmfmac/of.c > index eb3fce82..c824570 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/of.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/of.c > @@ -40,8 +40,8 @@ void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev) > return; > > irq = irq_of_parse_and_map(np, 0); > - if (irq< 0) { > - brcmf_err("interrupt could not be mapped: err=%d\n", irq); > + if (!irq) { > + brcmf_err("interrupt could not be mapped\n"); > devm_kfree(dev, sdiodev->pdata); > return; > } -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b/drivers/net/wireless/brcm80211/brcmfmac/of.c index eb3fce82..c824570 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/of.c @@ -40,8 +40,8 @@ void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev) return; irq = irq_of_parse_and_map(np, 0); - if (irq < 0) { - brcmf_err("interrupt could not be mapped: err=%d\n", irq); + if (!irq) { + brcmf_err("interrupt could not be mapped\n"); devm_kfree(dev, sdiodev->pdata); return; }
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov <dtor@chromium.org> --- Not tested, found by casual code inspection. drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)