From patchwork Tue May 12 10:01:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gujulan Elango, Hari Prasath (H.)" X-Patchwork-Id: 6387051 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 890E2BEEE1 for ; Tue, 12 May 2015 10:01:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6AE39203DF for ; Tue, 12 May 2015 10:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60DA32037E for ; Tue, 12 May 2015 10:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbbELKBX (ORCPT ); Tue, 12 May 2015 06:01:23 -0400 Received: from mail-db3on0142.outbound.protection.outlook.com ([157.55.234.142]:24857 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751214AbbELKBV convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2015 06:01:21 -0400 Received: from AM3PR06MB1297.eurprd06.prod.outlook.com (25.163.186.139) by AM3PR06MB449.eurprd06.prod.outlook.com (10.242.112.140) with Microsoft SMTP Server (TLS) id 15.1.160.19; Tue, 12 May 2015 10:01:19 +0000 Received: from AM3PR06MB1297.eurprd06.prod.outlook.com ([25.163.186.139]) by AM3PR06MB1297.eurprd06.prod.outlook.com ([25.163.186.139]) with mapi id 15.01.0160.009; Tue, 12 May 2015 10:01:19 +0000 From: "Gujulan Elango, Hari Prasath (H.)" To: "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" CC: "Larry.Finger@lwfinger.net" , "Jes.Sorensen@redhat.com" , "joe@perches.com" , "linux-wireless@vger.kernel.org" , "Babu, Viswanathan (V.)" Subject: [PATCH] staging: rtl8723au: remove redundant initialization Thread-Topic: [PATCH] staging: rtl8723au: remove redundant initialization Thread-Index: AQHQjJqXREsCfMUyDEqxB+5MS0MT5A== Date: Tue, 12 May 2015 10:01:18 +0000 Message-ID: <20150512095535.GA5332@IND12F0122> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [74.112.164.116] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR06MB449; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:AM3PR06MB449; BCL:0; PCL:0; RULEID:; SRVR:AM3PR06MB449; x-forefront-prvs: 0574D4712B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(106116001)(33716001)(87936001)(92566002)(2501003)(229853001)(86362001)(5001920100001)(77156002)(5001770100001)(19580405001)(33656002)(189998001)(5001960100002)(107886002)(19580395003)(62966003)(40100003)(46102003)(122556002)(102836002)(2900100001)(2860100001)(54356999)(2656002)(50986999)(66066001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM3PR06MB449; H:AM3PR06MB1297.eurprd06.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; Content-ID: <8F3A615C1AE93F40AFE2459D769086D9@eurprd06.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2015 10:01:18.8685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR06MB449 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The variable pHalData is initialized twice in this same function with same value.So removing one of them. Signed-off-by: Hari Prasath Gujulan Elango Acked-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c index 11e1108..9733aa6 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c @@ -55,7 +55,7 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen, u8 h2c_box_num; u32 msgbox_addr; u32 msgbox_ex_addr; - struct hal_data_8723a *pHalData = GET_HAL_DATA(padapter); + struct hal_data_8723a *pHalData; u32 h2c_cmd = 0; u16 h2c_cmd_ex = 0; int ret = _FAIL;