diff mbox

ath9k: fix misleading indent

Message ID 20160721163107.686-1-me@bobcopeland.com (mailing list archive)
State Accepted
Commit 4c51e7db87b753ce16c35ed0111eb273fe1a5135
Delegated to: Kalle Valo
Headers show

Commit Message

Bob Copeland July 21, 2016, 4:31 p.m. UTC 
Fixes smatch warning:

ath9k_vif_iter_set_beacon() warn if statement not indented

Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
 drivers/net/wireless/ath/ath9k/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julian Calaby July 22, 2016, 4:49 a.m. UTC | #1 
Hi All,

On Fri, Jul 22, 2016 at 2:31 AM, Bob Copeland <me@bobcopeland.com> wrote:
> Fixes smatch warning:
>
> ath9k_vif_iter_set_beacon() warn if statement not indented
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>

Looks right to me.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

> ---
>  drivers/net/wireless/ath/ath9k/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Kalle Valo Aug. 19, 2016, 10:06 a.m. UTC | #2 
Bob Copeland <me@bobcopeland.com> wrote:
> Fixes smatch warning:
> 
> ath9k_vif_iter_set_beacon() warn if statement not indented
> 
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks, 1 patch applied to ath-next branch of ath.git:

4c51e7db87b7 ath9k: fix misleading indent
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 7594650..70ca746 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -919,7 +919,7 @@  static void ath9k_vif_iter_set_beacon(struct ath9k_vif_iter_data *iter_data,
 	} else {
 		if (iter_data->primary_beacon_vif->type != NL80211_IFTYPE_AP &&
 		    vif->type == NL80211_IFTYPE_AP)
-		iter_data->primary_beacon_vif = vif;
+			iter_data->primary_beacon_vif = vif;
 	}
 
 	iter_data->beacons = true;