From patchwork Wed Feb 15 22:29:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 9575207 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8214F60493 for ; Wed, 15 Feb 2017 22:30:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6FBF7284B4 for ; Wed, 15 Feb 2017 22:30:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6466228565; Wed, 15 Feb 2017 22:30:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E46732855D for ; Wed, 15 Feb 2017 22:30:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbdBOWaH (ORCPT ); Wed, 15 Feb 2017 17:30:07 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33121 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752701AbdBOWaF (ORCPT ); Wed, 15 Feb 2017 17:30:05 -0500 Received: by mail-lf0-f67.google.com with SMTP id x1so22189lff.0; Wed, 15 Feb 2017 14:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ljmed4Qncz1zVh/YQqDaviNpTZNLPg0zqpM8Up+4Zvw=; b=Y8C5wIZnLL2BTT2UFFK71w+eFLVirp+6Zj7cIY+h8jvN/kCtRiUEbcDMUIh5ebcZ8Q 4R1xkNkcGKf+/tw5bkRSHL0Tksk/eT6uxW/XjbLYGfHN8SxBVA9ueFBw6JRXP61J9Jbd /atibTdk+R6ZpA4x+fp4L65kbEjCo/5EZyeWmY+KXFNyOk6ucavkzn3ICpvBqFdLN+rY kOhF17kbjKspxhd4cgjMrupuU3ABmtSAdIHv+Ao8O0tNDbN4/KqMwfxPaz6WI7+OQbR4 WTZ7sGhsZgr+v+QVuuzvlGnS9FaU9xOP7LXsh1I+ESq/XRavXCyPxvBNruFJr8nl+d0L 2gjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ljmed4Qncz1zVh/YQqDaviNpTZNLPg0zqpM8Up+4Zvw=; b=INgLVOip2AyqgJqVdqRkcIFH2yQNfFBhjIY1q0Uoi0CGQSZ9aL7u12l1PxF0wWQ8jz 2SPISOwcEUrfoDJF/OcnG/pUCXivS7UMkU1WC7XHvbxukVwrNI8NlkThNU5OioFJw/eA anZsxlpHrVxOxVVqfAIRcsCvXk0Geitkl/QuOICUFQWnqfagvEmKWatKhCdEPGhYnRpI k2ar/al7Aet6t6vlmrCugGEoEsJDgLyQW2bmNR6eM15vR4jMUpgw1mLS6Y4KBgPglHxw M6oW0Elr6W6T41qKWnRCTMAHyFYyuURNFAPqtDr9+ld/BZQGXvokp0xFuxw+amFz5bIq P0Kg== X-Gm-Message-State: AMke39mqn+9cAij2LwOrhGjQ2mHT4PibuMVJ934AgMS4LPp8gIdAGBzA+MNsDCxNx+ANYA== X-Received: by 10.25.79.26 with SMTP id d26mr12935380lfb.38.1487197803097; Wed, 15 Feb 2017 14:30:03 -0800 (PST) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id p33sm1265189lfg.47.2017.02.15.14.30.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Feb 2017 14:30:02 -0800 (PST) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Ming Lei , "Luis R . Rodriguez" , Greg KH , Linux Kernel Mailing List Cc: Kalle Valo , Arend van Spriel , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH 1/2] firmware: add more flexible request_firmware_async function Date: Wed, 15 Feb 2017 23:29:47 +0100 Message-Id: <20170215222948.21030-1-zajec5@gmail.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rafał Miłecki So far we got only one function for loading firmware asynchronously: request_firmware_nowait. It didn't allow much customization of firmware loading process - there is only one bool uevent argument. Moreover this bool also controls user helper in an unclear way. Resolve this problem by adding a one flexible function and making old request_firmware_nowait a simple inline using new solution. This implementation: 1) Modifies only single bits on existing code 2) Doesn't require adjusting / rewriting current drivers 3) Adds new function for drivers that need more control over loading a firmware. Thanks to using flags more features can be added later. Signed-off-by: Rafał Miłecki --- This patch is based on top of [PATCH V2 RESEND] firmware: simplify defining and handling FW_OPT_FALLBACK applied on top of Linux 4.10-rc8. Ming/Luis/Greg: assuming this gets a positive review, could someone of you pick this patchset? Second patch modifies brcmfmac, I'll try to get a proper Ack for that one. Unless you want this to go through wireless tree, then let me know please. --- drivers/base/firmware_class.c | 25 ++++++------------------- include/linux/firmware.h | 34 +++++++++++++++++++++++++++++----- 2 files changed, 35 insertions(+), 24 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index d05be1732c8b..7b3f0a018dc3 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -182,18 +182,6 @@ static int __fw_state_check(struct fw_state *fw_st, enum fw_status status) #endif /* CONFIG_FW_LOADER_USER_HELPER */ -/* firmware behavior options */ -#define FW_OPT_UEVENT (1U << 0) -#define FW_OPT_NOWAIT (1U << 1) -#ifdef CONFIG_FW_LOADER_USER_HELPER -#define FW_OPT_USERHELPER (1U << 2) -#else -#define FW_OPT_USERHELPER 0 -#endif -#define FW_OPT_NO_WARN (1U << 3) -#define FW_OPT_NOCACHE (1U << 4) -#define FW_OPT_FALLBACK (1U << 5) - struct firmware_cache { /* firmware_buf instance will be added into the below list */ spinlock_t lock; @@ -1356,7 +1344,7 @@ static void request_firmware_work_func(struct work_struct *work) _request_firmware(&fw, fw_work->name, fw_work->device, NULL, 0, fw_work->opt_flags); fw_work->cont(fw, fw_work->context); - put_device(fw_work->device); /* taken in request_firmware_nowait() */ + put_device(fw_work->device); /* taken in request_firmware_async() */ module_put(fw_work->module); kfree_const(fw_work->name); @@ -1364,7 +1352,7 @@ static void request_firmware_work_func(struct work_struct *work) } /** - * request_firmware_nowait - asynchronous version of request_firmware + * request_firmware_async - asynchronous version of request_firmware * @module: module requesting the firmware * @uevent: sends uevent to copy the firmware image if this flag * is non-zero else the firmware copy must be done manually. @@ -1387,8 +1375,8 @@ static void request_firmware_work_func(struct work_struct *work) * - can't sleep at all if @gfp is GFP_ATOMIC. **/ int -request_firmware_nowait( - struct module *module, bool uevent, +request_firmware_async( + struct module *module, unsigned int opt_flags, const char *name, struct device *device, gfp_t gfp, void *context, void (*cont)(const struct firmware *fw, void *context)) { @@ -1407,8 +1395,7 @@ request_firmware_nowait( fw_work->device = device; fw_work->context = context; fw_work->cont = cont; - fw_work->opt_flags = FW_OPT_NOWAIT | FW_OPT_FALLBACK | - (uevent ? FW_OPT_UEVENT : FW_OPT_USERHELPER); + fw_work->opt_flags = FW_OPT_NOWAIT | opt_flags; if (!try_module_get(module)) { kfree_const(fw_work->name); @@ -1421,7 +1408,7 @@ request_firmware_nowait( schedule_work(&fw_work->work); return 0; } -EXPORT_SYMBOL(request_firmware_nowait); +EXPORT_SYMBOL(request_firmware_async); #ifdef CONFIG_PM_SLEEP static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain); diff --git a/include/linux/firmware.h b/include/linux/firmware.h index b1f9f0ccb8ac..1f2bf14aa441 100644 --- a/include/linux/firmware.h +++ b/include/linux/firmware.h @@ -8,6 +8,18 @@ #define FW_ACTION_NOHOTPLUG 0 #define FW_ACTION_HOTPLUG 1 +/* firmware behavior options */ +#define FW_OPT_UEVENT (1U << 0) +#define FW_OPT_NOWAIT (1U << 1) +#ifdef CONFIG_FW_LOADER_USER_HELPER +#define FW_OPT_USERHELPER (1U << 2) +#else +#define FW_OPT_USERHELPER 0 +#endif +#define FW_OPT_NO_WARN (1U << 3) +#define FW_OPT_NOCACHE (1U << 4) +#define FW_OPT_FALLBACK (1U << 5) + struct firmware { size_t size; const u8 *data; @@ -41,8 +53,8 @@ struct builtin_fw { #if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE)) int request_firmware(const struct firmware **fw, const char *name, struct device *device); -int request_firmware_nowait( - struct module *module, bool uevent, +int request_firmware_async( + struct module *module, unsigned int opt_flags, const char *name, struct device *device, gfp_t gfp, void *context, void (*cont)(const struct firmware *fw, void *context)); int request_firmware_direct(const struct firmware **fw, const char *name, @@ -58,8 +70,8 @@ static inline int request_firmware(const struct firmware **fw, { return -EINVAL; } -static inline int request_firmware_nowait( - struct module *module, bool uevent, +static inline int request_firmware_async( + struct module *module, unsigned int opt_flags, const char *name, struct device *device, gfp_t gfp, void *context, void (*cont)(const struct firmware *fw, void *context)) { @@ -82,6 +94,18 @@ static inline int request_firmware_into_buf(const struct firmware **firmware_p, { return -EINVAL; } - #endif + +static inline int request_firmware_nowait( + struct module *module, bool uevent, + const char *name, struct device *device, gfp_t gfp, void *context, + void (*cont)(const struct firmware *fw, void *context)) +{ + unsigned int opt_flags = FW_OPT_FALLBACK | + (uevent ? FW_OPT_UEVENT : FW_OPT_USERHELPER); + + return request_firmware_async(module, opt_flags, name, device, gfp, + context, cont); +} + #endif