diff mbox

wireless: ipw2200: remove redundant check of rc < 0

Message ID 20170227234019.19081-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 889cdff72b85cc553d7820de071887593690b7d2
Delegated to: Kalle Valo
Headers show

Commit Message

Colin King Feb. 27, 2017, 11:40 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The check for rc < 0 is always false so the check is redundant
and can be removed.

Detected with CoverityScan, CID#101143 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kalle Valo March 20, 2017, 5:16 p.m. UTC | #1 
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The check for rc < 0 is always false so the check is redundant
> and can be removed.
> 
> Detected with CoverityScan, CID#101143 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied to wireless-drivers-next.git, thanks.

889cdff72b85 ipw2200: remove redundant check of rc < 0
diff mbox

Patch

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 5ef3c5c..bbc579b 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -3539,9 +3539,6 @@  static int ipw_load(struct ipw_priv *priv)
 	fw_img = &fw->data[le32_to_cpu(fw->boot_size) +
 			   le32_to_cpu(fw->ucode_size)];
 
-	if (rc < 0)
-		goto error;
-
 	if (!priv->rxq)
 		priv->rxq = ipw_rx_queue_alloc(priv);
 	else