| Message ID | 20170321144339.1709-1-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 21-3-2017 15:43, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > For quite some time now brcmfmac supports 802.11ac chipsets and it's > not limited to embedded devices only. There are even standalone PCIe > cards based on BCM43602 or BCM4366. minor comments below. Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > drivers/net/wireless/broadcom/brcm80211/Kconfig | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/Kconfig b/drivers/net/wireless/broadcom/brcm80211/Kconfig > index d93561f6ef97..817cb28f518f 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/Kconfig > +++ b/drivers/net/wireless/broadcom/brcm80211/Kconfig > @@ -18,14 +18,14 @@ config BRCMSMAC > module, the driver will be called brcmsmac.ko. > > config BRCMFMAC > - tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" > + tristate "Broadcom IEEE802.11n WLAN driver" You still mention 11n. Let's drop the 'n' here or IEEE802.11n entirely like below. Would like to keep the term FullMAC though. Regards, Arend
On 2017-03-22 20:38, Arend Van Spriel wrote: > On 21-3-2017 15:43, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> For quite some time now brcmfmac supports 802.11ac chipsets and it's >> not limited to embedded devices only. There are even standalone PCIe >> cards based on BCM43602 or BCM4366. > > minor comments below. > > Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >> --- >> drivers/net/wireless/broadcom/brcm80211/Kconfig | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/Kconfig >> b/drivers/net/wireless/broadcom/brcm80211/Kconfig >> index d93561f6ef97..817cb28f518f 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/Kconfig >> +++ b/drivers/net/wireless/broadcom/brcm80211/Kconfig >> @@ -18,14 +18,14 @@ config BRCMSMAC >> module, the driver will be called brcmsmac.ko. >> >> config BRCMFMAC >> - tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" >> + tristate "Broadcom IEEE802.11n WLAN driver" > > You still mention 11n. Let's drop the 'n' here or IEEE802.11n entirely > like below. Would like to keep the term FullMAC though. No idea how I missed that. Even commit message says we support 802.11ac now ;)
diff --git a/drivers/net/wireless/broadcom/brcm80211/Kconfig b/drivers/net/wireless/broadcom/brcm80211/Kconfig index d93561f6ef97..817cb28f518f 100644 --- a/drivers/net/wireless/broadcom/brcm80211/Kconfig +++ b/drivers/net/wireless/broadcom/brcm80211/Kconfig @@ -18,14 +18,14 @@ config BRCMSMAC module, the driver will be called brcmsmac.ko. config BRCMFMAC - tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" + tristate "Broadcom IEEE802.11n WLAN driver" depends on CFG80211 select BRCMUTIL ---help--- - This module adds support for embedded wireless adapters based on - Broadcom IEEE802.11n FullMAC chipsets. It has to work with at least - one of the bus interface support. If you choose to build a module, - it'll be called brcmfmac.ko. + This module adds support for wireless adapters based on Broadcom + FullMAC chipsets. It has to work with at least one of the bus + interface support. If you choose to build a module, it'll be called + brcmfmac.ko. config BRCMFMAC_PROTO_BCDC bool