From patchwork Sat Apr 22 10:14:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Priestley X-Patchwork-Id: 9694339 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73D0B601E9 for ; Sat, 22 Apr 2017 10:15:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DDCC26490 for ; Sat, 22 Apr 2017 10:15:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5248F285E7; Sat, 22 Apr 2017 10:15:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 08A0026490 for ; Sat, 22 Apr 2017 10:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1043804AbdDVKPY (ORCPT ); Sat, 22 Apr 2017 06:15:24 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36227 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1043799AbdDVKPX (ORCPT ); Sat, 22 Apr 2017 06:15:23 -0400 Received: by mail-wm0-f68.google.com with SMTP id u65so8868339wmu.3; Sat, 22 Apr 2017 03:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HASzp/LfXMarbt3C9JdnYH2P/ZrsVy/S7Pt7t6KVLoo=; b=BBIQGjrbZyfUsGomQWvGUEeRpYlhhkNCzF6KsHervkesEKBYs1GubQEN0SAsWuqgO+ zgIzm/8fpXkh2TMkRdTzOz4reQE/RTewyxgyZK867TMo4ZB38D1mkXhNzfVtJ+dgtViw z6h89HT9KXgcvyuZ8IFyltWzorgwWO2pOo7T0hINH1+gc8JXmDizyZjlEcCKC/RKl8pH 68I0FiSrVhYA+fZsd9BkLkiaZbcN2+FBPE5Jj09YM90VXDSpMT2gkyUwmNdfJH1Mwpr/ VKCClvV0tHi2VupChmoEf+KeMXt9w0Yk061QHAp0CrfbMBLHzsEtmKHObOWbEPQ6xI0V Xh8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HASzp/LfXMarbt3C9JdnYH2P/ZrsVy/S7Pt7t6KVLoo=; b=KEvL71YO/rZYORoL5+fBkmJl0FhN9i6J+kqeWsSrmScDBJCykhZ5QDO+5T7pVlJw1y UherX8l9o5OmF0M2MTH4Lg7hwbeb1rJNR7zIhw5sQx5XSducKX7sn/F9ljNy96NmaRm3 swkkhxwE4F8/IWiu+OcbuP5VYnlttz2a+ivTT77TLjDTr1vSn02SCRcP08V3O32QjbCi /9CmdsB1WNL245UywTAnjGwhHuGcXxzVYSfALzb6NnDXNmdn6aC7goqIWrQLu80tat/F vvVFpUz0l85LUcHZ9Eg8MZVwQIhlL5dJKe9w7VeIuBjbTfh3P6KHwdU6oQtfVU6/IAzw hfJw== X-Gm-Message-State: AN3rC/6DfYNPQDgkM3/9Ht7O2cml0acT11jBUXQJX0FVO9io9GjpPGOH nIgcdBYHRhFaQg== X-Received: by 10.28.153.194 with SMTP id b185mr2394118wme.101.1492856121508; Sat, 22 Apr 2017 03:15:21 -0700 (PDT) Received: from localhost.localdomain (94.197.121.138.threembb.co.uk. [94.197.121.138]) by smtp.gmail.com with ESMTPSA id k63sm5414010wmf.9.2017.04.22.03.15.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Apr 2017 03:15:20 -0700 (PDT) From: Malcolm Priestley To: gregkh@linuxfoundation.org Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Malcolm Priestley , "# v4 . 9+" Subject: [PATCH 1/2] staging: vt6656: use off stack for out buffer USB transfers. Date: Sat, 22 Apr 2017 11:14:57 +0100 Message-Id: <20170422101458.4566-1-tvboxspy@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since 4.9 mandated USB buffers be heap allocated this causes the driver to fail. Since there is a wide range of buffer sizes use kmemdup to create allocated buffer. Signed-off-by: Malcolm Priestley Cc: # v4.9+ --- drivers/staging/vt6656/usbpipe.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c index 9ad8503d2589..ea5a7c65ad1b 100644 --- a/drivers/staging/vt6656/usbpipe.c +++ b/drivers/staging/vt6656/usbpipe.c @@ -47,15 +47,25 @@ int vnt_control_out(struct vnt_private *priv, u8 request, u16 value, u16 index, u16 length, u8 *buffer) { int status = 0; + u8 *usb_buffer; if (test_bit(DEVICE_FLAGS_DISCONNECTED, &priv->flags)) return STATUS_FAILURE; mutex_lock(&priv->usb_lock); + usb_buffer = kmemdup(buffer, length, GFP_KERNEL); + if (!usb_buffer) { + mutex_unlock(&priv->usb_lock); + return -ENOMEM; + } + status = usb_control_msg(priv->usb, - usb_sndctrlpipe(priv->usb, 0), request, 0x40, value, - index, buffer, length, USB_CTL_WAIT); + usb_sndctrlpipe(priv->usb, 0), + request, 0x40, value, + index, usb_buffer, length, USB_CTL_WAIT); + + kfree(usb_buffer); mutex_unlock(&priv->usb_lock);