From patchwork Thu May 25 00:11:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9747231 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CC50160246 for ; Thu, 25 May 2017 00:12:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE45D205F8 for ; Thu, 25 May 2017 00:12:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B23CD26E54; Thu, 25 May 2017 00:12:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42F4E205F8 for ; Thu, 25 May 2017 00:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164742AbdEYALq (ORCPT ); Wed, 24 May 2017 20:11:46 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:35185 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164717AbdEYALm (ORCPT ); Wed, 24 May 2017 20:11:42 -0400 Received: by mail-pf0-f177.google.com with SMTP id n23so150181971pfb.2 for ; Wed, 24 May 2017 17:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2VrqLvKYNJQJBKgw5npOiJ3YRoGtJy2+nBJfHdYZmDY=; b=KC+Dhz4A/MKUaTb5h+QJ9zpEgtLDRolbnHAahLtgRugM7zb5Ztzogc2w4OBasr0tOd XQ7jCjyxThwXsjEJJsR910n0xeivZ23la9GoNI8uk/aEcX4Yq8AkUi9JLCePbC0+jgxl rWHPGeD49r0+9nES6u/HHt/oyQfpxvaM/fies= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2VrqLvKYNJQJBKgw5npOiJ3YRoGtJy2+nBJfHdYZmDY=; b=OyzP3J2+erEpMzRfuDc79Wig//ybQ9Dh1N3JZLGpm6lSJGYC5zpngMmp6FEOJwsX8s /cAsLUm0JKxqlwb5bqjTrhDJlmdZn2SKWfnd/7tMcxulS2Z4xPha2IArOyz87Hzsq7qV UOH+G/KGz4gscOyXO839IRzeg4pqSrYH6JdVmdShgUJGXqyfNvfVmOXZpIhoyxt44HzM J/7Ljk8u32EwMHnNQNn6MwQYtVPsYaEQF12YsQ1E3EJEiUAqGSS9PHdehYobkUDMDYMI YlFfyWLvqlSBf7bT5n0+ms89fKxgRj4qzgPDY0B5Txpdg1CS5PUKNheEOtA9nFTKLj6/ +Y6g== X-Gm-Message-State: AODbwcBkBTZe9PO5nxJqP39LovsKz5wBXoJ7XMt/CSUGJ8rxsGG1viT8 +7JoO6bVbpTv5eXb X-Received: by 10.98.5.130 with SMTP id 124mr22523702pff.209.1495671101364; Wed, 24 May 2017 17:11:41 -0700 (PDT) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id s23sm9823692pfg.81.2017.05.24.17.11.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 May 2017 17:11:40 -0700 (PDT) From: Brian Norris To: Ganapathi Bhat , Nishant Sarmukadam Cc: , Dmitry Torokhov , Amitkumar Karwar , Kalle Valo , linux-wireless@vger.kernel.org, Brian Norris Subject: [PATCH 09/14] mwifiex: pcie: remove redundant synchronize_irq() Date: Wed, 24 May 2017 17:11:14 -0700 Message-Id: <20170525001119.64791-9-briannorris@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog In-Reply-To: <20170525001119.64791-1-briannorris@chromium.org> References: <20170525001119.64791-1-briannorris@chromium.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP free_irq() already calls synchronize_irq() in a non-racy manner. Calling synchronize_irq() here is redundant. Signed-off-by: Brian Norris --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 3d5c29d79609..7d5a4f2a9a22 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -3209,9 +3209,6 @@ static void mwifiex_unregister_dev(struct mwifiex_adapter *adapter) if (card->msix_enable) { for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++) - synchronize_irq(card->msix_entries[i].vector); - - for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++) free_irq(card->msix_entries[i].vector, &card->msix_ctx[i]);