From patchwork Wed Jun 21 17:15:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9802343 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 65FF660329 for ; Wed, 21 Jun 2017 17:16:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BDB8285E8 for ; Wed, 21 Jun 2017 17:16:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 409CB28610; Wed, 21 Jun 2017 17:16:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEB5E285E8 for ; Wed, 21 Jun 2017 17:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753226AbdFURQA (ORCPT ); Wed, 21 Jun 2017 13:16:00 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34074 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdFURPt (ORCPT ); Wed, 21 Jun 2017 13:15:49 -0400 Received: by mail-oi0-f66.google.com with SMTP id b6so2189973oia.1 for ; Wed, 21 Jun 2017 10:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=OqdgSFRAncIWRT5vHHMmcDvv6DCx6UKuuclBvEEZLAs=; b=kMMJ/B4nHTAbgx+zwfTtrwue/JncTO9dB5TByS+UPq0hRr5BKW224GOH8AGRPFBri8 +ehVp6W+LtAlasQrwk8rjAePUObFLrfG/AS2bOg8tMQ3k96sNAUKY96z2o5pogPmjVV7 NIBYnq1NEPLZY2QSHdqJgcTIAR5svFI9wE3B7v52WpAlX0nbMqPPvhRnrcJq515AHxrU dOkFZmB2VrMubzqazbf63d1zcl+BuSNLa4AmYTJpAdGEKfStWyAdrX1W4xQ0Q7uB27XL J36mR3qVLuZNYL3wFSbE+NMVpdxl+Iorcc7NonFEORj0k4Nh5sh32YBYT73EgSQXihbh LBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=OqdgSFRAncIWRT5vHHMmcDvv6DCx6UKuuclBvEEZLAs=; b=YiOeYD7UZaWi2k7Cr6X0PLHwUX/Dgo2sCd3d8NMEAZgF/JQpArxyfESkRbJsGBOHml 24yLgsmnDcZah6eYSLZPvovyM6I3MOUV0lRADseLIshF3+ZAplcQOZU039Z/EzvxsHKw qrpjhSyyEO/1tGE9rWfLR8f1G9h4GzNZ8mc1n0IQYkgf31O9GLwjCHKb9p2E0yU2qIuB MZgOJSyf+MJzwRadAQthZPrsGClEqhVkHVF6z8yol5ada3ZeFlRMoBEtiDod+TL4TcyJ hcR/dlyiJrVS2U1dRqe6F87HnIQcQxhNqc7tRNbGunQexwLg+/7zRVw2r2QjAJ0GIXUZ i+rg== X-Gm-Message-State: AKS2vOznhe3WV/N2k62PTHx2r06CNL3vrseudxroMEMeWuPhvGfsxB49 vu936jfXqfcVdaQK X-Received: by 10.202.219.11 with SMTP id s11mr935077oig.208.1498065348869; Wed, 21 Jun 2017 10:15:48 -0700 (PDT) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id i38sm6785237ota.3.2017.06.21.10.15.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jun 2017 10:15:48 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih , Larry Finger , Yan-Hsuan Chuang , Birming Chiu , Shaofu , Steven Ting Subject: [PATCH v2 5/8] rtlwifi: Add return value to btc_set. Date: Wed, 21 Jun 2017 12:15:35 -0500 Message-Id: <20170621171538.4462-6-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170621171538.4462-1-Larry.Finger@lwfinger.net> References: <20170621171538.4462-1-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ping-Ke Shih We will use return value to handle error case. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c index d8fb2442f795..ffa7a517b665 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c @@ -534,6 +534,7 @@ static bool halbtc_set(void *void_btcoexist, u8 set_type, void *in_buf) bool *bool_tmp = (bool *)in_buf; u8 *u8_tmp = (u8 *)in_buf; u32 *u32_tmp = (u32 *)in_buf; + bool ret = true; if (!halbtc_is_bt_coexist_available(btcoexist)) return false; @@ -577,6 +578,7 @@ static bool halbtc_set(void *void_btcoexist, u8 set_type, void *in_buf) /* the following are some action which will be triggered */ case BTC_SET_ACT_GET_BT_RSSI: + ret = false; break; case BTC_SET_ACT_AGGREGATE_CTRL: halbtc_aggregation_check(btcoexist); @@ -622,7 +624,7 @@ static bool halbtc_set(void *void_btcoexist, u8 set_type, void *in_buf) break; } - return true; + return ret; } /************************************************************