diff mbox

[1/2] rtlwifi: fix static checker warning of uninitialized symbol.

Message ID 20170711013313.3478-2-Larry.Finger@lwfinger.net (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

Larry Finger July 11, 2017, 1:33 a.m. UTC 
From: Ping-Ke Shih <pkshih@realtek.com>

Patch 2635664e6e4a: ("rtlwifi: Add rx ampdu cfg for btcoexist.")
leads to the following static checker warning:

	drivers/net/wireless/realtek/rtlwifi/base.c:1664 rtl_rx_ampdu_apply()
	error: uninitialized symbol 'reject_agg'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 2635664e6e4a: ("rtlwifi: Add rx ampdu cfg for btcoexist.")
Cc: Stable <stable@vger.kernel.org> # v4.12+
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
 drivers/net/wireless/realtek/rtlwifi/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo July 28, 2017, 3:34 p.m. UTC | #1 
Larry Finger <Larry.Finger@lwfinger.net> wrote:

> From: Ping-Ke Shih <pkshih@realtek.com>
> 
> Patch 2635664e6e4a: ("rtlwifi: Add rx ampdu cfg for btcoexist.")
> leads to the following static checker warning:
> 
> 	drivers/net/wireless/realtek/rtlwifi/base.c:1664 rtl_rx_ampdu_apply()
> 	error: uninitialized symbol 'reject_agg'.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 2635664e6e4a: ("rtlwifi: Add rx ampdu cfg for btcoexist.")
> Cc: Stable <stable@vger.kernel.org> # v4.12+
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Failed to apply:

fatal: sha1 information is lacking or useless (drivers/net/wireless/realtek/rtlwifi/base.c).
error: could not build fake ancestor
Applying: rtlwifi: fix static checker warning of dereferencing freed memory
Patch failed at 0001 rtlwifi: fix static checker warning of dereferencing freed memory
The copy of the patch that failed is found in: .git/rebase-apply/patch

2 patches set to Changes Requested.

9833893 [1/2] rtlwifi: fix static checker warning of uninitialized symbol.
9833895 [2/2] rtlwifi: fix static checker warning of dereferencing freed memory
diff mbox

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index c145cfe27216..d7a1e2d2d529 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -1731,7 +1731,7 @@  int rtl_tx_agg_oper(struct ieee80211_hw *hw,
 void rtl_rx_ampdu_apply(struct rtl_priv *rtlpriv)
 {
 	struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
-	u8 reject_agg, ctrl_agg_size = 0, agg_size;
+	u8 reject_agg = 0, ctrl_agg_size = 0, agg_size = 0;
 
 	if (rtlpriv->cfg->ops->get_btc_status())
 		btc_ops->btc_get_ampdu_cfg(rtlpriv, &reject_agg,