From patchwork Tue Jul 11 01:33:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9833893 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 72BD260393 for ; Tue, 11 Jul 2017 01:33:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75D3623B32 for ; Tue, 11 Jul 2017 01:33:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A3742842B; Tue, 11 Jul 2017 01:33:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A243025F31 for ; Tue, 11 Jul 2017 01:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754626AbdGKBdb (ORCPT ); Mon, 10 Jul 2017 21:33:31 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33201 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbdGKBd3 (ORCPT ); Mon, 10 Jul 2017 21:33:29 -0400 Received: by mail-oi0-f66.google.com with SMTP id f134so13928323oig.0; Mon, 10 Jul 2017 18:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Wxh2mbQMbSepDFSWovrWYUBfliw/RsbWvoUy6B2TPGg=; b=A38HZXOnq4ewrkBFtARdZesgaTgMeqQOK23ZnOZSyrFatjlMeNV7NwSbb9mN/RbkNt 9E1/nTl43VcVMreBEW7uzsXaYqpIXLGnKPSzmI/rhNH5UQ2y7QD8CkF4O6Vd3v7WhBZ1 JMJCFZkKFQKahEn3L5dQ0MCl78gc8AHOggHxIG7ZaNBMNqqjbdgCsYbM5hxHOxAIbAGc 2EGPwrUigiPKDdQZoQZ67vRzFYpMd5U9zLVnEalQF19ZOcmBNqJc1yDVRFIpFHaRlKKJ 5u5JeZ1SHk7VmYKAqvJsgG56BbT9BX6bwDrGhliEIoosJbfNUP4bYjg2uJ/7tBwCA20h Bx8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Wxh2mbQMbSepDFSWovrWYUBfliw/RsbWvoUy6B2TPGg=; b=PYVf6nB1msnqti96gaEFQcib/BwpHkxL3czy0sq8JM6tiqnhfbJx94K3tqSB7RwTUm WAuYVaTe0BvRowkfheccngemcWkFjC40H0XGH43PlKnfJrK1648e4VtOKxotSpkMTMxo Z6CS6iu2yOG5MFCfyt7RvP1axgkTPHQHKj/AaHXcisCVBJ4x3fsjVk26JbPmKeUHYbYU xgkvfArw3LTkYrRusI9Q5pd6sxdE8+JGt12GJIU6TqRRRFWtWb80WYbplz/Za3lF7yLH dheH00nz8BSbcaWgC1yBO2tRqVhagK68DgusfNd9N6Cxt4g+2ivfd0aLTN/kKDzYKmcr 6qeg== X-Gm-Message-State: AIVw111y9N6aYUZua9XRilZ4rn2lFGZ1d1aZNLIMMkP75mHesU+OYJ5w RKcDH0msVnkZXA== X-Received: by 10.202.232.135 with SMTP id f129mr11377469oih.157.1499736808948; Mon, 10 Jul 2017 18:33:28 -0700 (PDT) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id t77sm20514221oif.38.2017.07.10.18.33.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Jul 2017 18:33:28 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih , Stable , Larry Finger Subject: [PATCH 1/2] rtlwifi: fix static checker warning of uninitialized symbol. Date: Mon, 10 Jul 2017 20:33:12 -0500 Message-Id: <20170711013313.3478-2-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170711013313.3478-1-Larry.Finger@lwfinger.net> References: <20170711013313.3478-1-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ping-Ke Shih Patch 2635664e6e4a: ("rtlwifi: Add rx ampdu cfg for btcoexist.") leads to the following static checker warning: drivers/net/wireless/realtek/rtlwifi/base.c:1664 rtl_rx_ampdu_apply() error: uninitialized symbol 'reject_agg'. Reported-by: Dan Carpenter Fixes: 2635664e6e4a: ("rtlwifi: Add rx ampdu cfg for btcoexist.") Cc: Stable # v4.12+ Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c index c145cfe27216..d7a1e2d2d529 100644 --- a/drivers/net/wireless/realtek/rtlwifi/base.c +++ b/drivers/net/wireless/realtek/rtlwifi/base.c @@ -1731,7 +1731,7 @@ int rtl_tx_agg_oper(struct ieee80211_hw *hw, void rtl_rx_ampdu_apply(struct rtl_priv *rtlpriv) { struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops; - u8 reject_agg, ctrl_agg_size = 0, agg_size; + u8 reject_agg = 0, ctrl_agg_size = 0, agg_size = 0; if (rtlpriv->cfg->ops->get_btc_status()) btc_ops->btc_get_ampdu_cfg(rtlpriv, &reject_agg,