From patchwork Fri Jul 21 14:51:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jo=C3=A3o_Paulo_Rechi_Vita?= X-Patchwork-Id: 9857129 X-Patchwork-Delegate: luca@coelho.fi Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34BBB60388 for ; Fri, 21 Jul 2017 14:56:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22C11287E6 for ; Fri, 21 Jul 2017 14:56:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17CAD287ED; Fri, 21 Jul 2017 14:56:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A027C287E6 for ; Fri, 21 Jul 2017 14:56:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbdGUOxL (ORCPT ); Fri, 21 Jul 2017 10:53:11 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36555 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbdGUOvy (ORCPT ); Fri, 21 Jul 2017 10:51:54 -0400 Received: by mail-pg0-f68.google.com with SMTP id y129so5592898pgy.3; Fri, 21 Jul 2017 07:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QvAk0P+8JP5N7j+JVGmdCCiX9fZCQqsqyxzpMYkKYiY=; b=N1eIXMrokm4Em8klREiN6Q5suRKRSSDGcO/0I06thoeImV9nyVUeOqomZcpERTWM/m DsATC7ktEAmqTbFWcG7vp4/SD566hoNAO7Djei1auDeHxUVmfTGH4uzn0PZpWi8elvBm VeuBniWJ0iboVOur19Ex7PbNFBoHuwQwwmLMPdJoyfeuIKS6eVAB1amLX1QMDNJEF1fq bz7haKMFZPojEBwLN+VgiwPUakY5GZxGt5eyEgwxw6VW+9TmG97VqZZziLUH7Nt47I5G MG5Kme6qPs5WZmTT5hrb3T93Uo17hKNgEWAWFkQv0xjX5a/7eNvbthOWY5duyExJRA8s SVyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QvAk0P+8JP5N7j+JVGmdCCiX9fZCQqsqyxzpMYkKYiY=; b=ROauc2xskMQu2LOdssKhybQP6PIJvXmahxXGXuk28RHjTB2kJH15jvARphwNwINDYc 2wgLHw9oozLDM9g3dLhEW3+Ml09NBrYGMPS4LccfEeiljpQt7fo7VTAFEaafjTYny25B YWmv7PVHCauAy977qEwzfxDo4Vvv9CNhOvG/iXvyecESwGZZsoj5opR/wmCgNOzfnmPE GMp91DF2yMLH+SLVJgnSucMfuu5JGFv8lZuxCWIfqXU/jSrjWcUHuqHqP49gEP8kXrt6 sViaGnmS2iMxhBw7Jrd2F/wkxEFQoZnZb23G4EVSh8NAX9z0BrEu/THSsF+AMBgLOOeC yRew== X-Gm-Message-State: AIVw113+DfiJXg7blX8Bbz/NDrpFYqWDuvHai6GDf5VA6dHS1FtGEbHr bJRBgdpSDRkNJw== X-Received: by 10.99.139.65 with SMTP id j62mr2766549pge.202.1500648713597; Fri, 21 Jul 2017 07:51:53 -0700 (PDT) Received: from kiddo.hsd1.wa.comcast.net ([2601:602:9602:62b7:5fdd:14b4:b6ec:ebb6]) by smtp.gmail.com with ESMTPSA id m8sm9156503pgs.24.2017.07.21.07.51.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jul 2017 07:51:52 -0700 (PDT) From: "=?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?=" X-Google-Original-From: =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= To: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo Cc: linux@endlessm.com, =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iwlwifi: Demote messages about fw flags size to info Date: Fri, 21 Jul 2017 07:51:47 -0700 Message-Id: <20170721145147.7572-1-jprvita@endlessm.com> X-Mailer: git-send-email 2.13.2 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These messages are not reporting a real error, just the fact that the firmware knows about more flags then the driver. Currently these messages are presented to the user during boot if there is no bootsplash covering the console, sometimes even if the boot splash is enabled but has not started yet by the time this message is shown. Demoting it to the info level helps having a clean boot process. Signed-off-by: João Paulo Rechi Vita --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index 6fdb5921e17f..557acd43d705 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -487,9 +487,9 @@ static int iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data, int i; if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) { - IWL_ERR(drv, - "api flags index %d larger than supported by driver\n", - api_index); + IWL_INFO(drv, + "api flags index %d larger than supported by driver\n", + api_index); /* don't return an error so we can load FW that has more bits */ return 0; } @@ -511,9 +511,9 @@ static int iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data, int i; if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) { - IWL_ERR(drv, - "capa flags index %d larger than supported by driver\n", - api_index); + IWL_INFO(drv, + "capa flags index %d larger than supported by driver\n", + api_index); /* don't return an error so we can load FW that has more bits */ return 0; }