From patchwork Tue Jul 25 01:13:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9861025 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18E7A6038C for ; Tue, 25 Jul 2017 01:20:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B9612837D for ; Tue, 25 Jul 2017 01:20:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00898285A2; Tue, 25 Jul 2017 01:20:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A79382837D for ; Tue, 25 Jul 2017 01:20:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757230AbdGYBRu (ORCPT ); Mon, 24 Jul 2017 21:17:50 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:34005 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756780AbdGYBOY (ORCPT ); Mon, 24 Jul 2017 21:14:24 -0400 Received: by mail-pf0-f174.google.com with SMTP id q85so53114763pfq.1 for ; Mon, 24 Jul 2017 18:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KynaMYoP156jxai8lrW2I+EluyTF4k+omtap9kGogb8=; b=Hh+dvH6/sQrHJOyKO2TWORP34hGK/BN822JTl3wv9F1Dm8ZM+fJBg1iXpXcLNXc+Bp CBoMAXu4zkS0AmYRxBuzpuayiGA5pASzS2UVsZr5ge6xF9Cij6rB5oxLMC8i8kWlcqHT WQpBXgj5dWKZC54uisdw+3L2Y7hCmI6mJWhPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KynaMYoP156jxai8lrW2I+EluyTF4k+omtap9kGogb8=; b=KqFUL1AvNRqwfFHt3FIaILQMhmdV7c42oi+aDAcd+eyrZJAJMdiM+MXrfjaS6xKH+b f7qPBoPrFM8RzyoGSIEWy+vES6pK64caMnp4DjH16Y0l2VYrLcBioES7YYm5dnR4dFfc F2uXefOxnMrem8JQdqwHW6C3zH8wlwxZGDniNf3QuZZHG9QlmJXA7AYi3vcESDRyf931 W+KSFTvFnxZHJSwZKnIovYwH0uEerTcx1BKzRBR4yyH7wfe8JV9KEam/HBSyOWsS9Vsl CMkCm2yD81Jg2taOPmtRvK4Yy9zwh2oOaWUwAiFY3Vgt/aAaXhiA1aN3DS/gdP4K7QE3 tBXw== X-Gm-Message-State: AIVw110XIsCqMPkOUJcrTrDks4w17jgXh4F5QpgVHchWOUIaaYTLCafz YryfwaRqvvQG5YEO X-Received: by 10.99.142.73 with SMTP id k70mr17511896pge.86.1500945263661; Mon, 24 Jul 2017 18:14:23 -0700 (PDT) Received: from ban.mtv.corp.google.com ([172.22.113.17]) by smtp.gmail.com with ESMTPSA id h123sm21497036pgc.36.2017.07.24.18.14.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 24 Jul 2017 18:14:23 -0700 (PDT) From: Brian Norris To: Ganapathi Bhat , Nishant Sarmukadam Cc: , Dmitry Torokhov , Amitkumar Karwar , Kalle Valo , linux-wireless@vger.kernel.org, Brian Norris Subject: [PATCH v2 14/20] mwifiex: pcie: remove unnecessary masks Date: Mon, 24 Jul 2017 18:13:30 -0700 Message-Id: <20170725011336.99993-15-briannorris@chromium.org> X-Mailer: git-send-email 2.14.0.rc0.284.gd933b75aa4-goog In-Reply-To: <20170725011336.99993-1-briannorris@chromium.org> References: <20170725011336.99993-1-briannorris@chromium.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After removing the interrupt loop in commit 5d5ddb5e0d9b ("mwifiex: pcie: don't loop/retry interrupt status checks"), we don't need to keep track of the cleared interrupts (actually, we didn't need to do that before, but we *really* don't need to now). Signed-off-by: Brian Norris --- new in v2 --- drivers/net/wireless/marvell/mwifiex/pcie.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 5c07edd4e094..2f4da08f127c 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -2460,28 +2460,24 @@ static int mwifiex_process_pcie_int(struct mwifiex_adapter *adapter) } if (pcie_ireg & HOST_INTR_DNLD_DONE) { - pcie_ireg &= ~HOST_INTR_DNLD_DONE; mwifiex_dbg(adapter, INTR, "info: TX DNLD Done\n"); ret = mwifiex_pcie_send_data_complete(adapter); if (ret) return ret; } if (pcie_ireg & HOST_INTR_UPLD_RDY) { - pcie_ireg &= ~HOST_INTR_UPLD_RDY; mwifiex_dbg(adapter, INTR, "info: Rx DATA\n"); ret = mwifiex_pcie_process_recv_data(adapter); if (ret) return ret; } if (pcie_ireg & HOST_INTR_EVENT_RDY) { - pcie_ireg &= ~HOST_INTR_EVENT_RDY; mwifiex_dbg(adapter, INTR, "info: Rx EVENT\n"); ret = mwifiex_pcie_process_event_ready(adapter); if (ret) return ret; } if (pcie_ireg & HOST_INTR_CMD_DONE) { - pcie_ireg &= ~HOST_INTR_CMD_DONE; if (adapter->cmd_sent) { mwifiex_dbg(adapter, INTR, "info: CMD sent Interrupt\n");