From patchwork Wed Sep 20 21:15:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9962615 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 185C9601D5 for ; Wed, 20 Sep 2017 21:15:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 05D4929255 for ; Wed, 20 Sep 2017 21:15:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB79429259; Wed, 20 Sep 2017 21:15:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 444B429255 for ; Wed, 20 Sep 2017 21:15:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdITVPN (ORCPT ); Wed, 20 Sep 2017 17:15:13 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33377 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdITVPM (ORCPT ); Wed, 20 Sep 2017 17:15:12 -0400 Received: by mail-io0-f194.google.com with SMTP id j26so2289285iod.0; Wed, 20 Sep 2017 14:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=y9Agu/aswJvwzVSe7zROC5nIkQ6bOr+j3Gf2iQyxJFs=; b=j6PQ+N2utDrP7SzG+b2v6vaNRTGmAvcLgNCICUKMhDEjAH8dkdaBd00zBr/KIH9R3C aG29crtWoF0JF15b2GZ5T2wUwLxZQ2f476SgALYH+bA/YR8dvFkNMbyIrR0kt900AzRO zJcIGlQ7hjM6rcFd+D+Ck2HOZLXQp49BscEYSaSoWJs/ceZNe7aKgiseCNkchx2LUdQM eb8Dn29DJ0oIzCvIEKLFQXYcpICVEvZ7Y+u58yiFx4Tsv8McPO/SEeohB0iu/yNQ9dYt rVBegkvd0CsiSwFrS5eBABp3QVYX/Viz12k3+gOoW/ifhO00BIBIYiK6kLmLukVVRois 9DaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=y9Agu/aswJvwzVSe7zROC5nIkQ6bOr+j3Gf2iQyxJFs=; b=N5aEaefC5apm2vkkXmVbjJLxcNV0EvaUt26k3hoB7wGDnNJRnRrNGh3fhd/dtxmc+d KlR3kOQ4wJG9t7A5X7dKMU78sFhkMp+ypmhXDTKA8l7QlUwm83+DiT9r/kdyubwYPdzR 9DN2tvWxiRUV+6vbSxKrFKCcckx6iR6obweFmImcqoNA7ZvFn7y+aqBY/W30PKQP1/Md 6wcTnjsuAvkKv+uVdYi6ryQBlJU8ZLjNFNdHGw6mFIoepvMiNcUtCkMG9g3o2XOD3wZX ETlNNu08EUMDco9twxXIbc2s3lxZ2AMi8K60k2jUemdG3mUrDn3Tmt/ANElpZb3Lp8H0 o28A== X-Gm-Message-State: AHPjjUjDax8rrn0CTfH81gap9DrpoVE3J+Zk08Mk0VH8vkCsRB7451nQ 7htmyZx6Qt9R3v7prWaRq1B+SQ== X-Google-Smtp-Source: AOwi7QAjqLE2xzleKmHbiLQsSdCxGMgtssDJcszeTKSIMIBaEjrxGG5y9fz7V3R2Nl/UGmRmaV0+ow== X-Received: by 10.202.180.10 with SMTP id d10mr28877oif.297.1505942111505; Wed, 20 Sep 2017 14:15:11 -0700 (PDT) Received: from linux-4v1g.suse (cpe-24-94-184-31.kc.res.rr.com. [24.94.184.31]) by smtp.gmail.com with ESMTPSA id m62sm2261973oib.39.2017.09.20.14.15.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 14:15:10 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger , Stable , Ping-Ke Shih Subject: [PATCH] rtlwifi: rtl8821ae: Fix connection lost problem Date: Wed, 20 Sep 2017 16:15:05 -0500 Message-Id: <20170920211505.26171-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.12.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi this change results in reduced stability for the wireless connection. This regression was located using bisection. Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues") Reported-and-tested-by: James Cameron Signed-off-by: Larry Finger Cc: Stable # 4.11+ Cc: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 3571ce4bd276..ac2ce86de506 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -1122,7 +1122,7 @@ static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr) } if (0 == tmp) { read_addr = REG_DBI_RDATA + addr % 4; - ret = rtl_read_byte(rtlpriv, read_addr); + ret = rtl_read_word(rtlpriv, read_addr); } return ret; }