| Message ID | 20171005094712.28627-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Samuel Ortiz |
| Headers | show |
On Thu, 5 Oct 2017 10:47:12 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The structure nci_ops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'nci_ops' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/nfc/fdp/fdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c > index ec50027b0d8b..d5784a47fc13 100644 > --- a/drivers/nfc/fdp/fdp.c > +++ b/drivers/nfc/fdp/fdp.c > @@ -726,7 +726,7 @@ static struct nci_driver_ops fdp_prop_ops[] = { > }, > }; > > -struct nci_ops nci_ops = { > +static struct nci_ops nci_ops = { > .open = fdp_nci_open, > .close = fdp_nci_close, > .send = fdp_nci_send, Why not static const? Yes this goes deeper. NFC needs to make all nfc ops const.
On Thu, Oct 05, 2017 at 10:47:12AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The structure nci_ops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'nci_ops' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/nfc/fdp/fdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied as well, thanks. Cheers, Samuel.
diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index ec50027b0d8b..d5784a47fc13 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -726,7 +726,7 @@ static struct nci_driver_ops fdp_prop_ops[] = { }, }; -struct nci_ops nci_ops = { +static struct nci_ops nci_ops = { .open = fdp_nci_open, .close = fdp_nci_close, .send = fdp_nci_send,