From patchwork Sun Oct 15 20:53:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 10007281 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4096D60216 for ; Sun, 15 Oct 2017 20:53:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 328AE252D5 for ; Sun, 15 Oct 2017 20:53:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27366205A4; Sun, 15 Oct 2017 20:53:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C30F7205A4 for ; Sun, 15 Oct 2017 20:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbdJOUxu (ORCPT ); Sun, 15 Oct 2017 16:53:50 -0400 Received: from mail-bn3nam01on0078.outbound.protection.outlook.com ([104.47.33.78]:11264 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751468AbdJOUxr (ORCPT ); Sun, 15 Oct 2017 16:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DyV+H1US3qV4Z5m0TWzHcbg7K2lXiLJ7yfQWK1u+f28=; b=h/Fyl4OEn77DbjR/vDJp7HK+3B/tz1YvOgOzWyCPnFnL63qw+zl/gCMYWGYbpN/tA9sxHfNcxt9k6Hkk9BBOfdAHztllJpjgMfcTKkUMz1CLVyALKrvPSsGaPSiZhFfTrsY1n9VvNpih8iW/qAuW6vvjncv7a4tcEEFKee9vN7Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sergey.matyukevich.os@quantenna.com; Received: from bars.quantenna.com (195.182.157.78) by SN1PR05MB1934.namprd05.prod.outlook.com (10.162.132.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Sun, 15 Oct 2017 20:53:44 +0000 From: Sergey Matyukevich To: linux-wireless@vger.kernel.org Cc: Igor Mitsyanko , Avinash Patil , Vasily Ulyanov , Sergey Matyukevich Subject: [PATCH 1/5] qtnfmac: modify full Tx queue error reporting Date: Sun, 15 Oct 2017 23:53:23 +0300 Message-Id: <20171015205327.9966-2-sergey.matyukevich.os@quantenna.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171015205327.9966-1-sergey.matyukevich.os@quantenna.com> References: <20171015205327.9966-1-sergey.matyukevich.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [195.182.157.78] X-ClientProxiedBy: VI1P189CA0029.EURP189.PROD.OUTLOOK.COM (10.165.188.42) To SN1PR05MB1934.namprd05.prod.outlook.com (10.162.132.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91847bd7-d098-43ad-11ce-08d5140ed3ec X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:SN1PR05MB1934; X-Microsoft-Exchange-Diagnostics: 1; SN1PR05MB1934; 3:mS8Bmosn2eM9ayieKd9sDU6Q0uPE1xs7W01xxlYTlGxGXQlv+uK2ycP5M6TDNtpGWv1AtWm/0PZxE67Ni83fXMep5R2gnAM3rdv9D5fvkMfKIE8Dgbq7NaYf8lqPpjv+MvaS519A9s1wvZvhGE8/zaPCatqyR5pqo3p9iJCnJUmErhUalzhG/7VxzEN1rBB0B7mpQizg6wOl7k0MP3fN8bghrujPtwt6hoka4PohO++QQP7qpiFp9MvIAnxxSVN6; 25:t5LMXcOP1C3auyKR17YBpxfO6VOCDPp5s+B+/uK6LWKkWT7d5ezL4OXRMGJ6zhC1+ogAtpul9aGQfCIY19Lj61a8D9nnAiPD0Rq2sFhFWr/ihXQwrQZWOBI992f/ECToK8FnAH8a/gvIcnQoxqof/ejtjpW07S2ffGZlJFQzQNL50SVr1KtlaUND7SGnWA0oUdPrlTVTVt8XQvDARcuMV9i0SdIbCHKr4u4yb+OPDVb/6mWj8rvXv32eWG18pSQ4KJ61XuLfEHCda/XV8JWkKv5pT4u4I5+KzouJLxD3k/fjo1vYRaN54T1pT7LdASYpjl2w7K7xKq04aL3rw7GMyQ==; 31:COPJYiK+Ux5c4aPsrwKSMiPh+NXZtXUvIXfwbJaf7aLZBgM1nMinz6QXXvLxiupegQ+ymd+M5PIBkizkbg540PxMxc/TAPXHeBEePeS0PLSI55RiadQSJCJoSgXtH3CDqFNVJhB3WrumP9PXpJhoIfxLbiZxqrB1Cdle8CdxVd031+v0sSDzS6QxVEJinkanoxHWRejpnM7ZXkEMUoK8O0V/yDcLtf+6z0M52RD9qms= X-MS-TrafficTypeDiagnostic: SN1PR05MB1934: X-Microsoft-Exchange-Diagnostics: 1; SN1PR05MB1934; 20:xjAh/eQf+g5dJq7KLZnjQXMQf/B2RXbwf+i6g40zx6Z0gXvTM1b2jVOJrcgEeRSKumGOHv3ZJFCTnSmHuTHuhRh/Ft9qRHcI5EfZmzWIbp+PRZ/HPfJOb4/2ewtZGwg3/O0xTNrMoq/p2NJ135rKOpv+wgPNW2j2Bdc5D/vU8579vebRPw/7ki5sJsadOZ5yXsg0kpHZAcRfCKVk3bMBhJXhOMhw+JVCE9wDj2059lADvYbHYtiJ2WQg9t6SWXR5k4DrTZOZmmsdwt/tlKpHYWr1ATkZ6Z9EiHta+eluNKyM1zDlkUtKVhcUa1kDW60e2Uywj/2Del6+c5ZglDAI45EgQQv5uoz6+W7KlHRIg8H59w4sDA0u5DU16dQvex4146KfZHZGI802FjNPpN21ZAz8ObYbihoVqH3fL84vGeweSmyPf65L85Pn/tAkrs0Do7Qfu/+1MzdsK3GchrELTd8FnF74jxSdM+ec1qmnfetg+U/SLtsONLPLthoBmLWV; 4:m8xhh/A5HO2mZG1Ww5fH/WWA3mC/9+yfQIkj3NehHf+RuMNUkrgChDu+yzLv8XQFw7UUm8WVVveDtMzy7HfqnHrx6I73BU41QSA1DsCYb0nwwXxuPiivE2Dj+3GC6/G2SWGdU9AH9pNRMhXfzEQXMiwAdew29nojqKOxhgsCYj39mhG7SG9S5rUORsCQybKZZCxvFRABx+7eJRdXrgmMcPO7o//bOwL6TnlFAuZRrAsg2q7Tx6F+kp2rOzu4K8rnoaQziDZ5ohWyMNpRKMki38Br/rBNMGXyRpVZZa7UpPs= X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(201703131423075)(201703061421075)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR05MB1934; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR05MB1934; X-Forefront-PRVS: 046164D5C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(199003)(4326008)(2906002)(5003940100001)(2361001)(2351001)(16586007)(53936002)(47776003)(69596002)(81156014)(5660300001)(106356001)(97736004)(105586002)(54906003)(8936002)(53416004)(50226002)(8676002)(81166006)(33646002)(6116002)(189998001)(101416001)(48376002)(1076002)(103116003)(66066001)(305945005)(2950100002)(86362001)(16526018)(68736007)(6916009)(6486002)(36756003)(3846002)(6666003)(25786009)(508600001)(50986999)(76176999)(7736002)(107886003)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR05MB1934; H:bars.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR05MB1934; 23:YUH5ZNs5aFKc2cP8Zmovkqbr1EZf3F7DiMb2pbegF?= =?us-ascii?Q?AgOrdsWjJ6jLcSTQg0vBviDg5pYaQYcZv4dU6mebjzexsLzK7TCHO/5f+Qqz?= =?us-ascii?Q?v7XmpRTO1vg/DIQTuMMbs7UmMDCdQN48qmv53OZ3tW6lBzp2Iu+qIbSSBX2Z?= =?us-ascii?Q?BvE7Pd3UxkGd6P1Y63bGbsBCTj77oq/ghWdjw9Yd5ldbk8kkhNVtdT6QyobB?= =?us-ascii?Q?oSk5bCPfonwYLu/uWLVPmJiTlzRODyqPHQ1hKaerxnBx7cNEr990Vn/c/1aP?= =?us-ascii?Q?UNE/wdE0oyPuqheSk3aq6oZKq+k92KKH+8oM5nG4qDJT33fm7hB1091Wqlai?= =?us-ascii?Q?d8xVZ8ylyR7TSg/EHoHA8Qk8vRKsQ0vlEvBMtoVvquyWQSbwrs8Iplh4fvt/?= =?us-ascii?Q?cdKsSMjOBe9/MQaoIhm8XUun1DyVDBon5VzjorLGZPddCHZKnKAqwP8PDktk?= =?us-ascii?Q?ZoxkUX4FQTG3Pu1cyx9lJjCO3p6YHI5MPuNd09dIPc2LQ1CYQjau3IJf968Y?= =?us-ascii?Q?3c3MV3mx7qjfwzBjc/lvp04h1GHzjucmRoQ9COQiWzBmmTEuyLsB515Ba5qj?= =?us-ascii?Q?shM+vUpMIJN763kQ/s8Dc3tOiK9fR0t0o2WYxH4S+EXnEOcuRJiLpUX7Ah1E?= =?us-ascii?Q?XiUyAix6U5iPIDjclr1MTDLUceWt0+m4+OOuil2Sl24JN6Cnn4CyPnobzq4n?= =?us-ascii?Q?CtrxnZCLYVDB49o523fRtYt8ZZkIC1Gxki+c0J9VLjITi36uhFmJIxe7wqJ9?= =?us-ascii?Q?UGKGOemo+f/xgo2qMR779o7mfhn7A6aAWaCkZUBrxbFCQrW+TjRYGROBfQWz?= =?us-ascii?Q?cvQFIpt+itpCcTIk4EviFKEctOaECjSBoatQXyhQkO5ASPRE85BKTRN5vGzW?= =?us-ascii?Q?k76J5GRZIvejGKdQSV6lIWnNLwluBgAQSzb58uUg9xdu0gCtbpNBxnPxWC0g?= =?us-ascii?Q?T1/kFCWjq60/9XPFvY2KrI0FHa7it4lwCef+tCjW1eBtZLfo88WSHzyCr08f?= =?us-ascii?Q?vT6/8ZZaHxqCzVsw5DFp3wlWeGXrHr/dCspas4HOIAP0XiR5B5j0mR3ltA7B?= =?us-ascii?Q?JWkBk5jZ+NZQyxED0fbkgf/ExycXfvQHhYiddt6rmUL5+eaXvyN5DjGLOsjn?= =?us-ascii?Q?oAbVSC2hz24ES6dkPrWqs/jIc3cbC2rO6bGbAodDzwcXNin9Cmm0w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR05MB1934; 6:wpAaRCYjZdLGWTr1lILFlgdovWX4ZfnDT2uMKwANYsmAvVWthXQvic3dbi8xArwtSC+7rWTnyVuImq2Kg1ILT9lnX54eGNMWLEH7dHBLAohkZ9+NqSn5Bt9T9dSnhWdHGYbYVhIWd+uw1SBvXs4n59h2JCGitUFmKqZ1JBWlFayo9Naw78TvXJ4sDqqZ1+SXmh83HrotBPEGKuj3hgpNJp/rHwvxDDs/cBk7/+t6eayboI2oZ6mCKfxSmZbLGQ/nmVIj8lPuQI7B1UCNTlUJgtyBkXdpkhu2MAfc7i8JAmritXjEOECT5Zeg+BKTM57YsR4uzZzEydOSn4IX2yaw2g==; 5:QDs/SnHYR7W7Uvh4VBlEzI/jYXlWIdVCu3h8svxdNhjzN099OZ/X8RCpyGoBwNSKGo6lq/ZZBaEYlQ71qsDRjolQ6Dld4R7uIqAexCeiBC3baMtGWVBI+TEbLfSn4XfvRpiKZy27JmUayp0sdFBDOrmwsykZ6LVFABEc9HcVDTo=; 24:J1uB1DdxvAbFvJx6VSmjq1L0MSnu7heC6BCbq2oDgRoe3l4LRv2n94fHn+V6F7wWTjNEb7Vv1RINRiOVRFDZEjJEZERTUxBD67W5dyAAVlE=; 7:asN074HimdQCCDpHPUVv+LoxqUkRE2yYmOR9YAJm/K17i5sNB4/8HzmGwYEC0r+YEgQBQTF2/1+qM2InyuZQswnh7eN1XDofPzuc+a9vFRjVy6Kc0ARDRau4AOQESVRGk6aQTJeWu246WORQV1vax4gvBIaIE36RL/Ktz8q0rM/LjqTJBuWJWgIQAfs1eEpiiHYwgrEgkMamivvsjm1098iMWm1U29u0IYHDjPBIMdM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2017 20:53:44.4103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR05MB1934 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Under heavy load it is normal that h/w Tx queue is almost full all the time and reclaim should be done before transmitting next packet. Warning still should be reported as well as s/w Tx queues should be stopped in the case when reclaim failed. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c index 502e72b7cdcc..a8f2c46f3a25 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c @@ -643,11 +643,11 @@ static int qtnf_tx_queue_ready(struct qtnf_pcie_bus_priv *priv) { if (!CIRC_SPACE(priv->tx_bd_w_index, priv->tx_bd_r_index, priv->tx_bd_num)) { - pr_err_ratelimited("reclaim full Tx queue\n"); qtnf_pcie_data_tx_reclaim(priv); if (!CIRC_SPACE(priv->tx_bd_w_index, priv->tx_bd_r_index, priv->tx_bd_num)) { + pr_warn_ratelimited("reclaim full Tx queue\n"); priv->tx_full_count++; return 0; }