From patchwork Mon Oct 30 10:13:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 10032277 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8ADB9600C5 for ; Mon, 30 Oct 2017 10:14:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79164285A0 for ; Mon, 30 Oct 2017 10:14:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6DA3A28818; Mon, 30 Oct 2017 10:14:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6925A286D2 for ; Mon, 30 Oct 2017 10:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932553AbdJ3KOO (ORCPT ); Mon, 30 Oct 2017 06:14:14 -0400 Received: from mail-bl2nam02on0070.outbound.protection.outlook.com ([104.47.38.70]:2209 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752554AbdJ3KOL (ORCPT ); Mon, 30 Oct 2017 06:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2dxO2Jbv8QdPdPBaJ5x9oPg59bVu9bxT8ngUyXMQgSg=; b=MOwz3Q3OYqG8SLsNwiov0aR/NKYwlCptWmv0KyC6ufFDPjMiJAdNO39KtG1Dp1gUB6OITNJF7LakK4v/C0P+N3o+xIGZoTkKpOIG5IdXyNMhVKk/JwDQEEohm7a8DD9PoZ5DIcA6wmXJaKrQvKD8+/WxRcNzKRuaKeVWZuAA/tY= Received: from bars.quantenna.com (195.182.157.78) by CY1PR05MB1930.namprd05.prod.outlook.com (10.162.216.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Mon, 30 Oct 2017 10:14:08 +0000 From: Sergey Matyukevich To: linux-wireless@vger.kernel.org Cc: Igor Mitsyanko , Avinash Patil , Vasily Ulyanov , Sergey Matyukevich Subject: [PATCH v2 1/5] qtnfmac: modify full Tx queue error reporting Date: Mon, 30 Oct 2017 13:13:46 +0300 Message-Id: <20171030101350.21251-2-sergey.matyukevich.os@quantenna.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171030101350.21251-1-sergey.matyukevich.os@quantenna.com> References: <20171030101350.21251-1-sergey.matyukevich.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [195.182.157.78] X-ClientProxiedBy: VI1PR08CA0130.eurprd08.prod.outlook.com (10.175.228.160) To CY1PR05MB1930.namprd05.prod.outlook.com (10.162.216.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21cef5b5-84d3-4189-5446-08d51f7ef645 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603238); SRVR:CY1PR05MB1930; X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1930; 3:Dpx2sOIlMRxjTCnmUSv1N1I7VFP5A9zaTCBricVC3unCZiiTJzPeYbTMj96naYi6yCOK/HFhy/N4o25VrqnGbwl7Wva0WBSRS7iazZkB9SIRxOdGwhNAv4+7GUhRUjwMeG2XTFwPidUs5vY4q1SEI8UIkoN7BJJ5c+3+//A+nwwqpmL+/5B6+TW4rLP1dXMcgozwfRFq4gKrpY8SZpyQAolZKmw5M7QCeuwQ5qYZF+gVldoxSPmezwLCPWNpKySv; 25:cXg8fnHzAtlxwsOiYbwe6oYR+W7/bJJ7POBboi57IaRAKpmZt132//R9y0NYlTw4UmLzSZ8ZfyEEh2EyalRRlo7F/JdEOdkK0gTF7dcR1W8iIkHK2/mmVW2JotEVyJyXDbWOtxmhmjgcTbD1l6nM1Hxa9q0wa7r3IzLAW1vv7WYC9IT6DOZdbFBrfA7x5z2iJAtOrwWTgU2ga7v8rnMKp4s3T4+JLbocDZZ5eYR0SehDHM/+so/CTtpI6SKMCW2H/Gxi00kVK1CklUhVlRPyWWDBlJSiUj98Jq97yNhUbOv9Enw5G0Ct2/thlt3O3GdKv+9fU1q+VYo6mEQ4k8JFpVe+WmoOfz7wfKUCkMtuEZ4=; 31:BNa86XTR4mC0ldjLoWCiYXZPUGGzzXrwzjbTvsh6keaTvmsqJr6GmyustniKCPFTqXyDOtH4vWOqp+cCmNvo5AwSpl5xLOwNSVHQNSrXWSOwRrd4VAoU2MY58vi9ciGPQJdrXHGEpsA8xZ+P/dNl8QNqU7oMqzwGmgtB0UUGQeMtTdy9We4wghS/YyID+Zg/1cV+4rspO8YQ6XX1xCCH7ZPe0Zi0SvqM7JxGzqASQ6o= X-MS-TrafficTypeDiagnostic: CY1PR05MB1930: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sergey.matyukevich.os@quantenna.com; X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1930; 20:aeLqh1sMgl4D7frHJnENOZIvjJvyIYILhE3RAFb813CHGwJtYeJWVe4tIAyIUQGgbsaqSd6JE99Uvc5v8KxcyUkDN8ztZ/znaMPvImRah0CbI45iBDtgJ4mVRCdECAvOzx9NVzs7N425/Sj4zKyCBvBsXyztXbJiGDT73Dv6X4J9ks4asu8ixuN6B/HLb+EFymUMiAJI9YQkx79g0frzLG4c2RlAaNzskqDKCZCnV11dfnrCerB9LnRHoqdcHFPvb7J/QTqAASIVIjesi02/ABCj0uEafAAmrT0p/lZxvud6wjKB+z0J+vw8t4Yi8oJQz5S8O42X7gL2FwM3PFWR/+wPMuVqJrIh1L77XDE+WqdA/U8Afr74ELzILrv3fofP1qmWkZrj9vIc/oA3Ke+8zXVGwaZ+JOEhe5GIjiIK88dYRR0OsI8T30T2zrfnqx+xJvA0dEW041mO+f1NFePmGjM2oZL+Dq8ls0OPAlts5bT6r3geujlvYeyhZKYdNxaz; 4:QyA5wKrTbR1vagmiVgKHaUzma/sB4+9k2SwvsA042nvNDvB+0neafT2FUxURKkBb2adW/A6OVFQRSp9QAD5ULKvKPdPBb4eCHBd5gXzaA0oB6tWI6sbpP6800mFsHZD1YS1dPYXlQSPiHD1yUU8TAOCcCp02ommUQ2eFhMQn5zXhYGAM5H8EHLmhsqONH+9y7x7taTZSWWFyqcAmqzpi2HcnYW3HFcmZtuOgkWegZGPz0Xg8YcmdR42FWkLypey38YkZBaNfafI6emp4EZwmrIIdDG3lr/pq9pgHCh8Yr646bc8h63g7afFgRQ3alxYR X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(3231020)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR05MB1930; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR05MB1930; X-Forefront-PRVS: 0476D4AB88 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39830400002)(346002)(376002)(199003)(189002)(53936002)(53416004)(2906002)(86362001)(50466002)(48376002)(305945005)(7736002)(4326008)(69596002)(8936002)(50986999)(107886003)(101416001)(76176999)(1076002)(25786009)(478600001)(8676002)(81156014)(103116003)(81166006)(36756003)(3846002)(68736007)(6486002)(6116002)(16526018)(50226002)(5003940100001)(2950100002)(54906003)(6666003)(6916009)(33646002)(16586007)(66066001)(47776003)(189998001)(5660300001)(97736004)(2351001)(2361001)(105586002)(316002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR05MB1930; H:bars.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR05MB1930; 23:NVD3WRNOfEOIeE3Rq8OVHSqsMVp74tbn1Mh0atUYq?= =?us-ascii?Q?UylcnOZvhDAabPMf78znVzDJiuKgjqOSM04EwT4xeE5G5Ki0aQcZ1DcGCm6F?= =?us-ascii?Q?7YBugrFaquCW8CIAa/6xiUqjmHdE25cUL+LBdYjM5Vq9mUssTpwgDtUHjy64?= =?us-ascii?Q?+SWwF7MLOwfNMhD4F7VeIYSdb9lCVGexIIiIrwitx66Uk3uI6a5d6+SwJRx1?= =?us-ascii?Q?8frkuVCgGzjYpQUX/eJxpydu+vluQifb1aR5SpJlFBgMEfa1KUB2Sj/52mLh?= =?us-ascii?Q?MswT2ICUuPAfzKW293hwRS3KTdt4OvTGChoo3eeswWOZwiQ1YTGH4JdYEteJ?= =?us-ascii?Q?jFhzftefF0+IWSBu+Puhr+dQoo2QOjQuuhKWY7WtIfNiKPGXuDTrJoh07mxW?= =?us-ascii?Q?JYE4AwjVFToZxSxpA6fxBSeFHe0CHUA7mnkowo768UsVscdxE2xtydphR0/1?= =?us-ascii?Q?a38wWYU6uAS7FFTdYSSWcdS1sbGXPhVEE3ubLDLXmjzEq75cC8k87M1wXWEf?= =?us-ascii?Q?htgw1x/znOOCCIDOb0elslKdoof4TVqil5DRWYReOypUjO7rIh5ZyXar7vID?= =?us-ascii?Q?aIw3r2tXH9BIkfwrwV1t1Yf/LW/juEtewOkxENn63wH3HTHo7iV7c2EjG6L6?= =?us-ascii?Q?MJ5nJUDBTRpEMLCWtrcausmnlIilTvSnphg+JDScTZMrNBjmVCiYbX4KniB0?= =?us-ascii?Q?csqwtOjRSMgeRWr9cCEZmInWqcbqjI9S0FKxacI6CFYkNMkekhd06uI1uCCQ?= =?us-ascii?Q?owE8mBm91L9FahIp8fjg9/7zZ95BmnymQcce79hIDeZqqL7aCycrv9DYgMSP?= =?us-ascii?Q?GpmsKF97QSK0YrkSPzH8LskeBxgPi4gigu8gz66kLU6IvSMCZ+yvc9hUzGI3?= =?us-ascii?Q?L+IPr2nsaSo0qFkJPPv75nFVBiH1Ds1PTiJzX9f1fk/DVPBjSv7wwKR43kXb?= =?us-ascii?Q?stz1YnZ+4zlPBbwSJFRhYotQgGiyAW0hEnmMMdm/JJXOFjCzdfoQM97BVlIa?= =?us-ascii?Q?fCTsR3QfBq3f0J+AesUZC83g8oh3tBP7a6ZIjkscpZFMPln7pzHxUZqUSMnj?= =?us-ascii?Q?+Vg5UJQAohzQjMN2OnBn2zpmQPTNV/iBXsmzBYian2bkrgOL/Mgah5HjGfy8?= =?us-ascii?Q?tZ1ZFcMJgdxFOS4QzFqTSZqdHpXjfUb3kqyCQZcwhW4mganQ3/BND0oa0lIM?= =?us-ascii?Q?QLby0i4Hxaar4IkHvIlrJQcuEapYzmIWE4z?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1930; 6:cto9c/CjwjG6Urq234EaXNDn8LsRV1QU81Pfw9q5dId/u6fwIMCOLqnYmhfizOtU2a08OurRspxUfVyl2+jwbamD6i2mgZhMK2WGes40BFDFUPR9EXraSR67f2UW3fUX0rweYhZ/ICm7s4zjZFRoo5zISlwGMXA7mbcaLt4O0FDQ4kKxdBrgil6VRUxEX2NiGLFeydCxXnc9rg1tXwmSSZqW0Ghsj4roeC9vCqOy0A3uZ7bFs2YikScmcZGdpUkQaTtJdPxAm6TB97mNdpXVELgHiGlePCeV0BxLgEqVwmxR7DQrAyzuTxYwFQkMKQjJqt4KCe8foxnBa47cKxw1T4Z4Ocl1sonD875rjjpnmpY=; 5:ZkS1h7U1uq8GpwE7bF3iZZZe8r3tXTIQmYvAVSb6EYi2T3bOcZvgFkm4S+qB/jgjuEorYjr4+HOrCtAtVqxiFBqIBQ7B0SSiXUGJx21/FbDEVbgyER7mYo0tsjdAxNEoMc/onRi0SIT4Y14eA9Ygndw2ShgyOQf83/+c5OkJR9s=; 24:MoApE7CGuaJz4B9jLvgEvgcgzHiagf9kcYEBWxEqFrYdSM0wQOpjky1IaEKQYlFMvZhB8+LBQzlu4RoNYbtl78HczRRtEGszs7ALY+fgGmE=; 7:uyqEjh9XrbVv1sEft4qBtW5umO4Q6nf1NDlyRiW2qvfHE4xA2u66Yh2R/kIjY1Wcy0NOnnz3y+0cGhRjdhb0RqVi7Ga7bmz1wHI1SutOrNmbpxK2CaaeXtwUb9aRSc8vpg6mP+lrivDdPgTIrfhx8gaIeldx4q2JX2+gsAIWnU61QgidHabpYQPzxfVECpnylwGL2krwZjZipUMmQ8+ErlQ7cggXEaH6lMgbkfA9tIIZMGJ+0XED+3WbHpYPYeUd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2017 10:14:08.6965 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21cef5b5-84d3-4189-5446-08d51f7ef645 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR05MB1930 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Under heavy load it is normal that h/w Tx queue is almost full all the time and reclaim should be done before transmitting next packet. Warning still should be reported as well as s/w Tx queues should be stopped in the case when reclaim failed. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c index 69131965a298..146e42a132e7 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c @@ -643,11 +643,11 @@ static int qtnf_tx_queue_ready(struct qtnf_pcie_bus_priv *priv) { if (!CIRC_SPACE(priv->tx_bd_w_index, priv->tx_bd_r_index, priv->tx_bd_num)) { - pr_err_ratelimited("reclaim full Tx queue\n"); qtnf_pcie_data_tx_reclaim(priv); if (!CIRC_SPACE(priv->tx_bd_w_index, priv->tx_bd_r_index, priv->tx_bd_num)) { + pr_warn_ratelimited("reclaim full Tx queue\n"); priv->tx_full_count++; return 0; }