From patchwork Mon Jan 22 12:46:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 10178449 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 604BE60224 for ; Mon, 22 Jan 2018 12:47:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EA4A281DB for ; Mon, 22 Jan 2018 12:47:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 532D428236; Mon, 22 Jan 2018 12:47:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFCC9281DB for ; Mon, 22 Jan 2018 12:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbeAVMrD (ORCPT ); Mon, 22 Jan 2018 07:47:03 -0500 Received: from mail-bl2nam02on0057.outbound.protection.outlook.com ([104.47.38.57]:39552 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751092AbeAVMrA (ORCPT ); Mon, 22 Jan 2018 07:47:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HYLIL+/pF+EwcKAbagRDmfzmgCrRiEvH/DCTwtS6Sj8=; b=sY7AZRNH2zdyPzthRCB0KP3Whv6msw6NDIPQUV9CD82PtQgr7/tZXBR4Qiie1zsbX3QWssvhLdVq3YNv59ogFlWXTHRWb6SyuUpj6J/nLR1fCGILofD8mVS+80UdKTd5NIRDRooe8daQkXdK53Yrlaj1hoSppjseZuZnl4MFF+4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sergey.matyukevich.os@quantenna.com; Received: from bars.quantenna.com (195.182.157.78) by CY1PR05MB1931.namprd05.prod.outlook.com (10.162.216.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.5; Mon, 22 Jan 2018 12:46:57 +0000 From: Sergey Matyukevich To: linux-wireless@vger.kernel.org Cc: Igor Mitsyanko , Avinash Patil , Vasily Ulyanov Subject: [PATCH 02/11] qtnfmac: fix warnings when mBSS setup is stopped Date: Mon, 22 Jan 2018 15:46:25 +0300 Message-Id: <20180122124634.8430-3-sergey.matyukevich.os@quantenna.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180122124634.8430-1-sergey.matyukevich.os@quantenna.com> References: <20180122124634.8430-1-sergey.matyukevich.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [195.182.157.78] X-ClientProxiedBy: VI1PR08CA0220.eurprd08.prod.outlook.com (10.170.234.157) To CY1PR05MB1931.namprd05.prod.outlook.com (10.162.216.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ab4c37b-51ba-4147-e1d9-08d561963a28 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:CY1PR05MB1931; X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1931; 3:CTagL545HcjevkenpF1uASOO+HCik8m/t3kYWEJ2Rvp6X+DZN+HgvYLFvNlvP7Rb5iXUtqfOqDmzfpv2UN1ScfJ3Km9XoP27hALucXFIjITvy+PKk3JWmMQ7rj1Kutn2FAnHn2SFVVCA04SH1tpxBda/1yQ8/L6JOAhhczM0btmf/uz+8pquO27fdSOGUyCuoFqyuqDwavWpxsUML3IxdmQQRcIj3O5lYnMinJK8cdn1LBObXiwCfy+MIpI2SIi+; 25:GDSdqHVqnketprjt5XXkSslwyQq7oaictoOvJxq006YDraux7zhwyrQRxy2xs5MT9qyOyTyNpywisZXB5xVrhbcqeCkmjgL4MGVNQQ0VqLNUD++LxzffaGNJuzx4b4rtP6ozm2yJGwN0+hEv9nWSnrteBNt7feGtoz7rrlGCSMoudiWk39q2ILl50vPSAReYauC6b6ehzY2i/y7y5/656Pf3bHycynnCZ8l6pAis1Iw73PT15aCi3uuoizX07DEqneswPcrTDjX56hbxWB6pQz3xp0UKh0iKaRhDiHDwutqTvdalZ2QIx6er3MoHqpBWJ9+nw1MGCYt8dlGfstP/Lynluwk1JZd6+l5KBo3ogUQ=; 31:3pwkdsTB6jHzzQeGEqSyJT6uzaJMjdO5rKZjMkYWYNy6mKN66QiY9JKRZGubE9KoLySAreJ6jX9rWL9a8zwOcPS9ucD1znXETvv6P+Y3P6fHbf2hSlzJlE/CuU36g2YPsc9sxe56y730cRsbE3vGIhMYjMWyqbb2WUC8UhybUANo1Yw1DsAtgJeCHKnhO8B4D81/LcbxieYX1mZW6We0VYkXegi5Qo58fXZSJEKKXjo= X-MS-TrafficTypeDiagnostic: CY1PR05MB1931: X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1931; 20:r5ki5jkRM+eOrIq485aLbRC/WIUurEe4ywlsbtMFyBepn4WLkRX+JX8mPRS3vpo7kz+yjf9TIZStZ1I0e83k4QGGktlILZedyAzj1RfHDAjVsQQYUDkA23ZMrvU5tY5bRv++3QAiW95b23mADYSRBxspsc+cmw9kyBqBCPfMIfYx5WyHGfmaoZLJS57KAm00y+OMZyNyAIvrL2SC71+o96euRGDzkIW8YxE0as4qgylpUNtNVPp5ErKVpUGRmgDpy7eJpqp/rgXnE0BSRDsopTbvTfyo3iD1oJ47nfdXEzgorFvos6mCHnTmjbdnIm66VADDAV7uNzpQgluXU2LLM0zr5BPo2HoN0FEOm1K8dbdJxTujUk7LJokETzC0Z8xIAa8T4WKF9A0WRW56u/rjgJyq9pNhuFfKSoHGmTDCRddoZeZmFpD/Lnhpc2wBKeF4t2MUf9a3FWCG7uCbD76WpPxfceGvop9mRYJ3Y51SD3WIhOtLl9NIrqZF6QKFoqcm; 4:v3kTiU2dJNGuz9eSa0jkL6+Noje8BNfSl2J5qeiTI2gqEeqKY6wyaSlAHOXRl76JvREsDXMemTwNuF9FXHbgS1PhDKUIGxB2cRY3AwMwOTLMpVm7Dzx2R1eDq0j1NIcSv/0pgTVY+8E9iAZ0yBqXGllH3tBZbfvtHWhklAe/wLV1lreTfPUk5Rp+J4b9dqUy1mc8w28gFFifxyaDdNXYeCzfHIkAYABj84uxfTYcyJbAd7HvBpRNKVi95Za/cUrrNo7zmM8RL7XgOSqjzybYcw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY1PR05MB1931; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR05MB1931; X-Forefront-PRVS: 0560A2214D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39840400004)(396003)(366004)(346002)(39380400002)(199004)(189003)(2351001)(25786009)(52116002)(1076002)(6116002)(26005)(59450400001)(2361001)(36756003)(4326008)(76176011)(107886003)(478600001)(8676002)(8936002)(50226002)(7736002)(81166006)(6916009)(6666003)(2950100002)(305945005)(2906002)(106356001)(105586002)(68736007)(6486002)(81156014)(53936002)(48376002)(66066001)(16526018)(47776003)(103116003)(97736004)(50466002)(5660300001)(3846002)(386003)(16586007)(316002)(51416003)(7696005)(53416004)(54906003)(69596002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR05MB1931; H:bars.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR05MB1931; 23:HdPx3jH0k8BZVfhJULuCfx0aMjopgm3SffoJZeqhS?= =?us-ascii?Q?rsRrW0R4ZqzfnEO4ctY5ImgiR6fSNBCW22dUInTckQeUw9ygUcFfDTPKxoM5?= =?us-ascii?Q?Ece1XXzItirvhW9VNt4IyocGhnFN7v/aYD3E5SWo7mCXmWki9IPodU4nCcc5?= =?us-ascii?Q?QUM0bN1uFxJf04u6rweZk8lzqtI+LQ8D9FyT4XxtNEB0+yDAxbRBCuD2AY7M?= =?us-ascii?Q?SmcUdrfQ1uTPf+p4TqYH6UUIhKQrFRKXcOsomqTenysr4wf4ouEit48wP6WN?= =?us-ascii?Q?Y50VUBeqIQf5Y8bPrBId5XssD0WJkVkQ9tR6hARRTtC8WQ0THALzhhP0B02b?= =?us-ascii?Q?oQpJyhhqMWVTqvYmhf2rp601Bd5nlzn5B8O1baIviX4ngR1ShmS6H8WWWAIZ?= =?us-ascii?Q?F4FnvBK68DblXiIYsK5BgZhNbi+1pTBeMoYQRk6dxZrku0VgmFEEx4nQ+UbF?= =?us-ascii?Q?sh55xlQUOkAbg8rW0c8MZWGL5Dm5R5mQMk3w7MIMyNJPNOmOyBP7wB4g/rLf?= =?us-ascii?Q?rUW2Y9TjRbpY+XDhEtvLeB5l9PMaxcNQckfJQeCOmm+70E35Zn3i0QfL98X+?= =?us-ascii?Q?Lmn2RYJS08aGyF9gFjvRplY9Mo7MGVTwydl9itrjUNVbuyNhU3XiJJQygSav?= =?us-ascii?Q?M4X55igyiRzKLOHztLsmGzXkpAdoZGAMm0MPVRMDxvUr784yxoi6DWin2M9b?= =?us-ascii?Q?kMvjt8b85MRfcFF4SCeWuyEnr2q3Q00G3k1Q+o14kmLXocM+WnCo0kCPm2/r?= =?us-ascii?Q?vgZg8s7v6vB2Rt7Sicp3nA2xCA+uT2hUyyjdgWRe56k4u8zB4wPTmcR6giVd?= =?us-ascii?Q?3GWGJ5z/rA4dwrzojvUlPt0KPuGEYPJ4/Ujt6EXvSvPuVJIq2M72WPExBwqn?= =?us-ascii?Q?C4I84bjSRF3qMKY/u3Uk3G6efQjB2Y+zngkbwIFY6h9v/uJuRW8m0rVJPQlm?= =?us-ascii?Q?AdgmIimXRN8l/+B0KtrqFVxALnlUkG5BAFntAJbXMpfIauF9KSo+xA6KF6pv?= =?us-ascii?Q?iQHxQQXIQ9WW7bZyl2DPIYZI7Tsl1T2PezT/yHFPfi8UKqkBAOp9myI4Rlpe?= =?us-ascii?Q?pq/J773Qdu68RQwSoJktOg6K7CnB1nMIkBt1LTxRN4YxvMorI/KfHAgb4RtV?= =?us-ascii?Q?Y3W0flaSABOU/fRUXHr6PScV2EZ0Uz1dy+/2naMboOwEDiT8uqE1zN6sCsSV?= =?us-ascii?Q?rqlwjpwo25WQi2twmCvNXC0dkR0ifWwQjGeEZeDBJo+fwzAJUOb4a/CM5xdn?= =?us-ascii?Q?cRjh3VtY99Do0b40j0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1931; 6:DAVxdYt63ooWhVD0zjGKIysT0B5t4L7iLh1ZWewfkhVV41Cpi1hKTG23C4WAC0QbOfRpb04CNU195VHEAK+sPhZ1T2UNBWEmsX1BX7S/ko7+TsPobuRgqckrc9rKsU0Z+hotnq5FR/CpmfY4l4WyWQUl6TY/08J+rwCHKX0kcK7ReQoIfsHd5cgfFZDbcGDP2BdsUXDHGnkQxQACtjwVEFo8IiaNsuGtAAHS7eF/Yt5iDH1QdIqPvadHt7WjZ2wqmZ90v8lnEMguS9VZdanU3Y9Ag0Y7H1Svx/ZvqUCzHTQkf5oAiW9RGrGex1ugOzG+bM+G03Yyvek8vRPFgX2V+vq7yLev5/LHBz+OhDacKj0=; 5:a0LX3zkdMRia5nssGXN9A0KfPwlQGYcZiRTOTZM+rwvB7Sk4Qycr2iVNJicDmxxImkqBlut2169h7pHAHCITcN7GykTR4jofHX5+3s83z4XzQz5RCucQ9wF1m9gd59H++25juDgYbALGtYmQIcXJg92P0P0hJFXgy/+y+1bvD/o=; 24:CxcSDBNM1CdXEpBgNO9Wn3xDcBqLbeqNjaRqhIXSWTsX9OveW5Bdm73pgcpiupqTrTlWvdXMXZf9VdikOj/BXZTsqBVuVdaHC1uszxQ9ykI=; 7:FV4qAyKkmrGqR7zL/OPmJIPrjbptGYDmVg/CmWEr8TAY5IB9ozA9GrhKyC86n6afoSf2Ygd7fttGTlzxXMD2CuxT0Qb9QQF6CMLkmPHmOclFVpgA9TouuiL+62ecLNrpzfYS1Sx/RRiuqiqPWlsFa2KmYOx68y50cG9YY1Pn0zqEZ8vpABmmPhyTF/xcBrICg7Hq4ge/zpGJmqUpekmturQp4LobuCK9CgPH3hZUibuhdmGlbquX8ZVSRvFxlkxW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2018 12:46:57.5601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ab4c37b-51ba-4147-e1d9-08d561963a28 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR05MB1931 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Vasily Ulyanov Virtual interface should be deleted after calling unregister_netdevice since this function ends up with sending updown_intf command to card. Signed-off-by: Vasily Ulyanov --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index abf10996c26a..c417a67b0291 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c @@ -120,10 +120,6 @@ int qtnf_del_virtual_intf(struct wiphy *wiphy, struct wireless_dev *wdev) qtnf_scan_done(vif->mac, true); - if (qtnf_cmd_send_del_intf(vif)) - pr_err("VIF%u.%u: failed to delete VIF\n", vif->mac->macid, - vif->vifid); - /* Stop data */ netif_tx_stop_all_queues(netdev); if (netif_carrier_ok(netdev)) @@ -132,6 +128,10 @@ int qtnf_del_virtual_intf(struct wiphy *wiphy, struct wireless_dev *wdev) if (netdev->reg_state == NETREG_REGISTERED) unregister_netdevice(netdev); + if (qtnf_cmd_send_del_intf(vif)) + pr_err("VIF%u.%u: failed to delete VIF\n", vif->mac->macid, + vif->vifid); + vif->netdev->ieee80211_ptr = NULL; vif->netdev = NULL; vif->wdev.iftype = NL80211_IFTYPE_UNSPECIFIED;