From patchwork Mon Jan 22 12:46:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 10178467 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 451BC60224 for ; Mon, 22 Jan 2018 12:47:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4380226224 for ; Mon, 22 Jan 2018 12:47:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37AAC28210; Mon, 22 Jan 2018 12:47:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7DF6281DB for ; Mon, 22 Jan 2018 12:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751091AbeAVMrW (ORCPT ); Mon, 22 Jan 2018 07:47:22 -0500 Received: from mail-bl2nam02on0084.outbound.protection.outlook.com ([104.47.38.84]:56768 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbeAVMrL (ORCPT ); Mon, 22 Jan 2018 07:47:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YeSXo4DbY+qPrXAvPoIgHGqRZQ/bAYP7LbW4VL3SvzU=; b=lAlszHd+P53m6XW8eeGTlwaikJT5h+5Ylw0d28E/Vyj0EZBmN55fDdHFDLxE8/1y/8t9b8W0Dy5q/yvSxd0E4MgEqpQVuQTcOh425dFqKoIF3nbqiGX1LMuxjMXg8apc+N2iDpjFmUTE+4jKgao8hMQXX0FtgBPtiuDEQNqZHwY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sergey.matyukevich.os@quantenna.com; Received: from bars.quantenna.com (195.182.157.78) by CY1PR05MB1931.namprd05.prod.outlook.com (10.162.216.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.5; Mon, 22 Jan 2018 12:47:08 +0000 From: Sergey Matyukevich To: linux-wireless@vger.kernel.org Cc: Igor Mitsyanko , Avinash Patil , Sergey Matyukevich Subject: [PATCH 08/11] qtnfmac: fix STA disconnect procedure Date: Mon, 22 Jan 2018 15:46:31 +0300 Message-Id: <20180122124634.8430-9-sergey.matyukevich.os@quantenna.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180122124634.8430-1-sergey.matyukevich.os@quantenna.com> References: <20180122124634.8430-1-sergey.matyukevich.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [195.182.157.78] X-ClientProxiedBy: VI1PR08CA0220.eurprd08.prod.outlook.com (10.170.234.157) To CY1PR05MB1931.namprd05.prod.outlook.com (10.162.216.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50418762-32d8-4ff9-ae1a-08d5619640a6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:CY1PR05MB1931; X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1931; 3:V6axU6B68lI8cJ0RKbclh4Xyg1F90JBXzIwejsVL8NbNcNp2NzkoEfdwcjHJslVFWs0WtSypzZcauasGQ5+YBfD9cc1jkeziZcuBpO8QRHL6RoSzAH+achm6Tb1wr/4sfTVLOvtAA3cyeAV2F0rchzHqb5wKnTpUIKqgfDnJOZdy9vdOcSLc5/NK43GZG6U+EThHHs6L9sz/tYzhmEjmWGDcQ9UMIUa+NHOcjiao9JUOPP50SgnWqr2A1nlSlnxw; 25:jswYe/H037PNJz/bEyRMvm6YCG5QAocpEVF0QG3ZSAL+DVtHyr20oc+HbtKEHXOr/cHi4xB4C8m/o0ld92a/LPQKWCEb5ybVjbvnSfP1UntWiCDNSWWQIes70WXXbe92WyW8ENvdHxbfWE4NfTyF+lyYuRhhNGL+Q33G9gVw25quJ8hvdtdLa8PjSznwzz98YmaTHLPd0A8wzXlURYAWUcn3Ye6+8WUrJJacPLqEtjk4ZI4YzNiKL+FwCB5IcjUyg2RaZtxkrnGl1H/52rTacko7rcSD0Z0izw3SJlIFvfbnmG4xPEkPJP1WbIYmVufSpji94UM2v5OeVyvVMI1DArH8XuIK5JlVopPIBwLtuKA=; 31:/Z38z3cB5bw+ORuk/4MNKdEt7LUrg67Ora+nAKUPR2ZnFeaXqfvTl/PpZ5jBZ/I1QlB+6lzW9jJEX7Bvs4optMzB//h1TCvbGowuBb51R72Y/li68237LBH4x+/kfuAzc6rUUkKcrTc9P/Bjk6h3x2o3ZOxalyxo+PO1Bb5ucfasyJnZ4WTDEJdimyPN+tSKKr72YvyJWbgyA59302eTPwDtPeCG0os/koogiiQ9U/8= X-MS-TrafficTypeDiagnostic: CY1PR05MB1931: X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1931; 20:8qIJANCOKjSfQz35oLfbsoZzu9cErhemJJkYFKQFBCKcIld3GqckAfqgU5bJpIjtF1DpSlo1hQAY4FJ2El1O6ORzOOiO3UGmoI+JLISvPRKiakwmFnafUBRX2m35JzPzL+7lzURdcJaRxFTuF4s4fqcOAWSLZKBsxWyzNt02S2aw8wxI5KwIyPQhRYMsZij/DL6m6y1oKk6svQ8l+HycSimSPn6Va9/HifkdPD5AjTavBo4cdQ/8M0bzn1YBW1vFtQ9yi1Qa48qf60nQREGLd0UC3rXZBE6SUn+DIMNJyUnI8JehiBDdvLVeeSHi8rmiZFcy5f2GoiocRWgOd0qN+IP9nsEUu80/Ll0LQ3qxjcSTEjFy2rIGX5IH77eKdOtfGuOgFZbi87WgfbXVzAGAp2QhXUeYt43EGs31ehI3soXmyjvxlDD5NZkHgoC/rYNaX1DFu5Ow40+O/TdItMkuoWRerDO2uHETSkqDMbWauBDWEXw0Pim/RYs8NP8GuAXg; 4:YTzHiyyWwq9mXpQe0P+j1mpuEjiTcX5UluHlltf3ETzkHJWh8PIqy84Xb38ZEsyKBM2sb2XoLbeCcLboON+nCF3NypmnQNSSScG1NH5ZO/B5YX/HX3C9ypOLiiSo/UIeNEc5JUx/9GkigUU5OgqppB2Z/Bqu/VVcnF7njuY/sph5aGLKAnXi1kCHmgJVUaBu8fqbTAb8fEyZMhFssLkU9zFNIfJUCzPOfRImbqNOxdQdOfxEeYH+O68QWzth3OQI5wK6hiF7fp4dt3f/52m4iA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY1PR05MB1931; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR05MB1931; X-Forefront-PRVS: 0560A2214D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(376002)(39840400004)(396003)(366004)(346002)(39380400002)(199004)(189003)(2351001)(25786009)(52116002)(1076002)(6116002)(26005)(59450400001)(2361001)(36756003)(4326008)(76176011)(107886003)(478600001)(8676002)(8936002)(50226002)(7736002)(81166006)(6916009)(6666003)(2950100002)(305945005)(2906002)(106356001)(105586002)(68736007)(6486002)(81156014)(53936002)(48376002)(66066001)(16526018)(47776003)(103116003)(97736004)(50466002)(5660300001)(3846002)(386003)(16586007)(316002)(51416003)(7696005)(53416004)(54906003)(69596002)(86362001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR05MB1931; H:bars.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR05MB1931; 23:2rHyJsLYTY9LGKYI26vPp3myAex3GLH7aDr58F0bI?= =?us-ascii?Q?nzXQal8NzDma21Mn93nP3m/Xea6WSszc3eE6hgUrz0fXyvAOsJzvPnAXE3xY?= =?us-ascii?Q?UDZ4K6CVe2jmBD1TlmEn2LKegmkkbbuGfx+cF5CX+funKIpoZ7rV2kbnUPX3?= =?us-ascii?Q?2VwDgSA3dfDxnkxqzpba+gOIyW8e4vwO6Qqc2g1HOnvlzmsxe6NqMrNoFdYw?= =?us-ascii?Q?vmosba1SXzlFinrNyn6LdGtlxhBYSvQqkH9F2a9LOZ+HORUFSD12hwiNUtBz?= =?us-ascii?Q?R+1lMYDIjFk7H4zUtw27Xne+5Ov3K5sP1wMY+AXrZYT72hD1Ypw4ogB3O7Wi?= =?us-ascii?Q?UDa/0LtZMo7VYX+0iM3wkYCbtgJSkDEbJRrzmzuKM/WKm+BUvntRaIa1oLSo?= =?us-ascii?Q?DpJdxLVhTiWz0tIeiGUfkaEw94dYPu2knwGumgh7q6dw0PN/wj4TFE24PPvX?= =?us-ascii?Q?fbxJ+W1UkFW0PVQ19m+Gx9wTD7VNsDyTac09yJ9BChpcn3Mu4GW7NPpGOodM?= =?us-ascii?Q?OrUetlYC+3RMIFlZCU/cpXqU1hN/Vnb0JMbpsbiX6c9ua8laC/ZiKVYBNBN2?= =?us-ascii?Q?h4WEYiBD7dao0l7B/0OgqIJPUwHYPJwF3MB9BXc7x+ZgTPlS4yJzq+ngGpxX?= =?us-ascii?Q?+wVKIXXFscVpv56i0BrZrWB1EovVb3ZhW4hE0LcYpAV9oFWORF6QhFwbbGMJ?= =?us-ascii?Q?Apc4tHUE/f6riGBl2EU0uUeKGOcYsYrw7e/GOrhPxQ4Lf9L1eipwQbnC3sl7?= =?us-ascii?Q?oUzld4kl4L4BAWYuIZB2kWykbLpHD1ac1bNM283xhTLlya7ICYp/uW5gzGJS?= =?us-ascii?Q?bgcngnl/qQs87OwMKtmxy2Kv1FxREnYJplMaBlcI4gSFZ+bU33hiAd8QZzQ7?= =?us-ascii?Q?1McQTmwbjAGdgogIn3jI9GcSAMO5TS0n2x03QCXieb0gnGDoGsEY/1CHmqVf?= =?us-ascii?Q?Q+bmC2z1zGYLPygiituds2+Dc+GTzMuCZ+WliLdTJLnOHDMWN7l2O6eUEGRn?= =?us-ascii?Q?1hbsG5iDyJ3y9dPf+igsnt0d2kBjvDUaHwq2HGZ667dOpkd46aObvHE+xkwP?= =?us-ascii?Q?hqdzwoISEFFNBtwD8zLp8xC6yMSwVk2d0c28UyoNsV9JEHlTrTnHJ4k033Ff?= =?us-ascii?Q?OOGtSB95SKhY5DPN/PPQGp8/DuH3sc4KxpcLXnNcXg/ffdZaA7xZojAQAvL4?= =?us-ascii?Q?aadbLCJ5zFBIMqxggIYuE/bH01obUXL/AGTwtmWW96kbyySd/m59S6bdw9Um?= =?us-ascii?Q?YZ9hfBNo6VgIedjaU65vHkDphCGqCU5SssmODnrGpsKcpvzc0FJJ6Ei1iYGI?= =?us-ascii?Q?Opy621Kt8xnxvPHg9g8a4wpmFJgHPkG1YShuV+ZyLh2Ig26Fgt/6w2AKxgl1?= =?us-ascii?Q?zwUeA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR05MB1931; 6:1SDfpq+WZOwcZAHZ+wW8rtfRTWb2qB9xsy4OefR7jZ/YUsbG5fn4d9O66bXDlvAgACpwTvrwwy/P8Rpx7rcE3a773OICXhfgL3t/t4oZhtS8qWZR0ClacJdTvwp+V7HcYqUKyqhRtgGuBjnsd9Ns1YY8PkflnEF/PzlKcUjW1ucQS3It3+c3Q13MwCZB1Egc562c+h68N1PGsYS5HWVIBaQ5l/W5PKgQMrfRKxrCnPk7hbhIgY+dfCU8LwVRPcpBU+7LGoPO81ut4tI2FgchFbjEZHhr4kjXSTpqdweUp6UP3AQf29BJxA+7PIRbAvgb+cr8m5oq9VI0gNAzmw8WPJFcpPoCqA3gCMjxgo3XRtw=; 5:r81Vn4mLoSe0e7D2NpFuZ3T4QfOjOoUT7lT77qpgVc05+EpsA2bekTRXlcEUPsIc07Yp9bhciym3LDwjpe82nEOhUMpA83/z4b6x4hpZE276HIWq8CLoRSOL0b/GkOGnB9zUN7udj1Sy45T6WocRmLHZHdoMHaGfQkjCMqY1wgs=; 24:Noi82uXkCe3QvVXd8Y929vTNQ4C1ZKbJvc0GK5E0vC9bSLW2QnoegF9dPMJ5BJqGb2OSLfHklWLLXkKd71JFpuWOj51GGs4XoeH7cD2s1Kw=; 7:oXGVlgVqNRZMoxbvaimfgwi635+kszRTfTbxjp36F7VMmevrFfH/HH321dsJkW28aVVf8tfw24eTgmpHNCbt+K4hlvvJNP8BJJa/1S2XAS5cnPuxhkFmNALvBRbtI8K6PEkqJDxVsswL1vqs3C037zih80b/tup8fsD1XW0hzmr7D5ufo00ti74zB10hCaUV5jWsnTC9FAZKxV8zBcshknHbsvEnhzkLVQFEhzo0qIWzhOBpLjhRLdbDsLmLjw2X SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2018 12:47:08.7478 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50418762-32d8-4ff9-ae1a-08d5619640a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR05MB1931 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP STA does not reconnect to the same AP after disconnect. The reason is that STA is marked as disconnected in cfg80211 disconnect callback. This is too early since in this case qtnfmac event handler skips cfg80211_disconnected call when processing disconnect event from the card. As a result, wdev is left in an inconsistent state. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index 91830fd41508..edebf23e8eae 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c @@ -679,7 +679,6 @@ qtnf_disconnect(struct wiphy *wiphy, struct net_device *dev, return ret; } - vif->sta_state = QTNF_STA_DISCONNECTED; return 0; }