| Message ID | 20180222202859.16679-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 78dc897b7ee67205423dbbc6b56be49fb18d15b5 |
| Delegated to: | Kalle Valo |
| Headers | show |
On Thu, Feb 22, 2018 at 02:28:59PM -0600, Larry Finger wrote: > In commit c713fb071edc ("rtlwifi: rtl8821ae: Fix connection lost problem > correctly") a problem in rtl8821ae that caused loss of signal was fixed. > That same problem has now been reported for rtl8723be. Accordingly, > the ASPM L1 latency has been increased from 0 to 7 to fix the instability. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> Tested-by: James Cameron <quozl@laptop.org> With both patches applied to v4.15 on OLPC NL3 with rtl8723be. Nice catch, well done! May explain some of our problems with rtl8723be that made me withdraw it from production of laptops.
Larry Finger <Larry.Finger@lwfinger.net> writes: > In commit c713fb071edc ("rtlwifi: rtl8821ae: Fix connection lost problem > correctly") a problem in rtl8821ae that caused loss of signal was fixed. > That same problem has now been reported for rtl8723be. Accordingly, > the ASPM L1 latency has been increased from 0 to 7 to fix the instability. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> > --- > Kalle, > > This patch should be sent to 4.16. Ok, I'll queue this for 4.16.
On 02/23/2018 03:18 AM, Kalle Valo wrote: > Larry Finger <Larry.Finger@lwfinger.net> writes: > >> In commit c713fb071edc ("rtlwifi: rtl8821ae: Fix connection lost problem >> correctly") a problem in rtl8821ae that caused loss of signal was fixed. >> That same problem has now been reported for rtl8723be. Accordingly, >> the ASPM L1 latency has been increased from 0 to 7 to fix the instability. >> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> Cc: Stable <stable@vger.kernel.org> >> --- >> Kalle, >> >> This patch should be sent to 4.16. > > Ok, I'll queue this for 4.16. Thanks, Larry
Larry Finger <Larry.Finger@lwfinger.net> wrote: > In commit c713fb071edc ("rtlwifi: rtl8821ae: Fix connection lost problem > correctly") a problem in rtl8821ae that caused loss of signal was fixed. > That same problem has now been reported for rtl8723be. Accordingly, > the ASPM L1 latency has been increased from 0 to 7 to fix the instability. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> > Tested-by: James Cameron <quozl@laptop.org> Patch applied to wireless-drivers.git, thanks. 78dc897b7ee6 rtlwifi: rtl8723be: Fix loss of signal
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c index f9ccd13c79f9..e7bbbc95cdb1 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c @@ -1125,7 +1125,8 @@ static void _rtl8723be_enable_aspm_back_door(struct ieee80211_hw *hw) /* Configuration Space offset 0x70f BIT7 is used to control L0S */ tmp8 = _rtl8723be_dbi_read(rtlpriv, 0x70f); - _rtl8723be_dbi_write(rtlpriv, 0x70f, tmp8 | BIT(7)); + _rtl8723be_dbi_write(rtlpriv, 0x70f, tmp8 | BIT(7) | + ASPM_L1_LATENCY << 3); /* Configuration Space offset 0x719 Bit3 is for L1 * BIT4 is for clock request
In commit c713fb071edc ("rtlwifi: rtl8821ae: Fix connection lost problem correctly") a problem in rtl8821ae that caused loss of signal was fixed. That same problem has now been reported for rtl8723be. Accordingly, the ASPM L1 latency has been increased from 0 to 7 to fix the instability. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Stable <stable@vger.kernel.org> --- Kalle, This patch should be sent to 4.16. Thanks, Larry --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)