From patchwork Thu Feb 22 20:28:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 10236349 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 16FFE60349 for ; Thu, 22 Feb 2018 20:29:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0ADEF28E15 for ; Thu, 22 Feb 2018 20:29:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F33E228E1A; Thu, 22 Feb 2018 20:29:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 522DA28E15 for ; Thu, 22 Feb 2018 20:29:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751180AbeBVU3O (ORCPT ); Thu, 22 Feb 2018 15:29:14 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:39531 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbeBVU3N (ORCPT ); Thu, 22 Feb 2018 15:29:13 -0500 Received: by mail-oi0-f65.google.com with SMTP id t185so4665888oif.6; Thu, 22 Feb 2018 12:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=eGHvtmwWQh7vAbtMZuJPz1muydan3A/aBFYn88jLFsI=; b=Mo5aY0Js77DRMcVdl3g13FsyXm1mZsMlvngacCFX4QBp6IeNJFam7VjWNActtBa6bU 0sHRjNUJeWRbHvWJAxiKebaUs+ZIkWrInTq7X3KPGg094U+nBUpvgR4OI8Im/+dcb3iw GvA7y8od95/uqCYtfNjSOaj+JjkQs431SU/aQkW7DxjPFocVLu5n5/oonc/9hjjtj4dM OpRC4cnvNFqD/NKC2sPIzsSmtECwConZs1H5xY4sR8ay5BLzq865MUTUvGA2d0nHBVYb /I4Ufw6/5KzmDWiVy92O6cnhNbNdPLTsCKAywkiBGpdNLw3XBfMWflaTs4+6MIG2nKGH sFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=eGHvtmwWQh7vAbtMZuJPz1muydan3A/aBFYn88jLFsI=; b=WCYoAOGzxsp5e4sUheIuWpU9atGB1BDGkEiSkASWeCxbGr57LKs/Bgx2zfFWj3n92r l04JvQhy0E5Mfgg9UT451gHcpqIBzgTIoJpBD3uhZUizEFwqNmZ/JFlfw0zVfOmL6GKt LVs0qCVh4fLfldWdTyp/aVT8xyX+Rgq8KIHXuhDOKQ+BSQ2fX8jSKLiP6c6GXtXvx9T/ SDpKqR/wUaT6CTGgaWC0LsU+/x/WXln2BoXN5fWqTzNbwFX93hYRfgEnp1Rga7l2FEFS Kxtcr/KCrKMz9mg7ddoRsBaZvwylbd1JpZVsYScvEwB69PbnDRNGVMkhyWJXlBnrVw8/ PYZQ== X-Gm-Message-State: APf1xPDfOQq8DtGv/esajLUcNGNPkm7OQkaBdRU9Dhv6sBNk6/0xYdOf CjVw0Gn95RmhSJPU0AHnzlA= X-Google-Smtp-Source: AH8x225r6cdBE+fo82eWMEIPNaVpvC0sGIziELCiS/VCrwMtQdZWDITv1jR+MUVed9BfMLE3Uqhwlg== X-Received: by 10.202.9.25 with SMTP id 25mr5774489oij.128.1519331352571; Thu, 22 Feb 2018 12:29:12 -0800 (PST) Received: from Larrylap.localdomain (cpe-24-31-251-255.kc.res.rr.com. [24.31.251.255]) by smtp.gmail.com with ESMTPSA id f30sm464161otd.38.2018.02.22.12.29.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Feb 2018 12:29:11 -0800 (PST) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger , Stable Subject: [PATCH] rtlwifi: rtl8723be: Fix loss of signal Date: Thu, 22 Feb 2018 14:28:59 -0600 Message-Id: <20180222202859.16679-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.16.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit c713fb071edc ("rtlwifi: rtl8821ae: Fix connection lost problem correctly") a problem in rtl8821ae that caused loss of signal was fixed. That same problem has now been reported for rtl8723be. Accordingly, the ASPM L1 latency has been increased from 0 to 7 to fix the instability. Signed-off-by: Larry Finger Cc: Stable Tested-by: James Cameron --- Kalle, This patch should be sent to 4.16. Thanks, Larry --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c index f9ccd13c79f9..e7bbbc95cdb1 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c @@ -1125,7 +1125,8 @@ static void _rtl8723be_enable_aspm_back_door(struct ieee80211_hw *hw) /* Configuration Space offset 0x70f BIT7 is used to control L0S */ tmp8 = _rtl8723be_dbi_read(rtlpriv, 0x70f); - _rtl8723be_dbi_write(rtlpriv, 0x70f, tmp8 | BIT(7)); + _rtl8723be_dbi_write(rtlpriv, 0x70f, tmp8 | BIT(7) | + ASPM_L1_LATENCY << 3); /* Configuration Space offset 0x719 Bit3 is for L1 * BIT4 is for clock request