From patchwork Tue Feb 27 13:31:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 10245249 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9900B60362 for ; Tue, 27 Feb 2018 13:32:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CCC4288DD for ; Tue, 27 Feb 2018 13:32:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 811AA288F3; Tue, 27 Feb 2018 13:32:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 061F1288DD for ; Tue, 27 Feb 2018 13:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbeB0NcU (ORCPT ); Tue, 27 Feb 2018 08:32:20 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57678 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbeB0NcT (ORCPT ); Tue, 27 Feb 2018 08:32:19 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5F3D460858; Tue, 27 Feb 2018 13:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519738339; bh=5SPjjnGmIav0aXMu+QyY/mQoBoal9fA/oSNycpYH0II=; h=From:To:Cc:Subject:Date:From; b=RKAioXYMv/L1AjPJaHfoq2eXp3TNOPvgbe61MSOYCt44i4JtV0qohF9Rzd6gdh9d/ T711DUeEPOCepaZWLsbz+h4FQlFuPLqrLg11atRHju8JabBt8BfVo5xY06m0sr3Vt6 0SqXx+f6ALVy7hgJKYyB1Fy2SdN0BpKmRgm8cUqc= Received: from lx-rfried.mea.qualcomm.com (unknown [185.23.60.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rfried@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 49834607E5; Tue, 27 Feb 2018 13:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519738338; bh=5SPjjnGmIav0aXMu+QyY/mQoBoal9fA/oSNycpYH0II=; h=From:To:Cc:Subject:Date:From; b=bqPAET4udY8yVZnUf+oZGFRzooOVYgS46kjgpxwjLOxgvIvZmQxaF8baR/RFP2um7 iwa6aEYzx/XbQAOZ6P7KoIim3DvK4eedWxWnWvmv9FyMwowPJdUJDGKrvmi5Un22Ti +HsZBphcnj4wN708qSYSJMmtbuKb4DFrtJB2jycQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 49834607E5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rfried@codeaurora.org From: Ramon Fried To: k.eugene.e@gmail.com, kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: Ramon Fried Subject: [PATCH v2] wcn36xx: reduce verbosity of drivers messages Date: Tue, 27 Feb 2018 15:31:49 +0200 Message-Id: <20180227133149.26805-1-rfried@codeaurora.org> X-Mailer: git-send-email 2.15.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Whenever the WLAN interface is started the FW version and caps are printed. The caps now will be displayed only in debug mode. Firmware version will be displayed only once on first startup of the interface. Signed-off-by: Ramon Fried --- v2: print the firwmare version as info but only onetime. drivers/net/wireless/ath/wcn36xx/main.c | 2 +- drivers/net/wireless/ath/wcn36xx/smd.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index ab5be6d2c691..8c2654075eb8 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -261,7 +261,7 @@ static void wcn36xx_feat_caps_info(struct wcn36xx *wcn) for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) { if (get_feat_caps(wcn->fw_feat_caps, i)) - wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i)); + wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i)); } } diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 2a4871ca9c72..3048722f0484 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -385,6 +385,7 @@ out: return ret; static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len) { + static bool first = true; struct wcn36xx_hal_mac_start_rsp_msg *rsp; if (len < sizeof(*rsp)) @@ -409,15 +410,17 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len) wcn->fw_minor = rsp->start_rsp_params.version.minor; wcn->fw_major = rsp->start_rsp_params.version.major; - wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n", - wcn->wlan_version, wcn->crm_version); - - wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n", - wcn->fw_major, wcn->fw_minor, - wcn->fw_version, wcn->fw_revision, - rsp->start_rsp_params.stations, - rsp->start_rsp_params.bssids); + if (first) { + first = false; + wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n", + wcn->wlan_version, wcn->crm_version); + wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n", + wcn->fw_major, wcn->fw_minor, + wcn->fw_version, wcn->fw_revision, + rsp->start_rsp_params.stations, + rsp->start_rsp_params.bssids); + } return 0; }