From patchwork Wed Feb 28 22:20:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 10249983 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 27E4160362 for ; Wed, 28 Feb 2018 22:20:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0955D28EE8 for ; Wed, 28 Feb 2018 22:20:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07CCD28EB0; Wed, 28 Feb 2018 22:20:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38D1B28F08 for ; Wed, 28 Feb 2018 22:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935293AbeB1WUV (ORCPT ); Wed, 28 Feb 2018 17:20:21 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:50250 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935290AbeB1WUU (ORCPT ); Wed, 28 Feb 2018 17:20:20 -0500 Received: by mail-wm0-f65.google.com with SMTP id w128so8019258wmw.0 for ; Wed, 28 Feb 2018 14:20:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nRAEVwR9Y1L15ZQSC5j6f8LwkVCNgNDwEPT6fkqUd6A=; b=dRyQh59PIGaJIMlNkfVno6UNqrubxFCvMAVLs0AAQ3ylEfQ5PNR+CO2ThlXGiAwq8G MOhFIYxncytSiNSSjC0xIx4CAEVsszwLBYub75KCqqPz+sRceDHMIsFyOxMc4g8wLZ6G N3pQbs2HdX9QKvkk0NBIIYuHMTu0xwK4YRrRWkJF7Y4XeMGuXwtPQ+h7RSnebnVD+57E fCCXm8Pck+ERFj/WT3PsxFM0k7WBce3dxNkTQCNoScij45Vzn8C4xmw6x4RgnCCG93kC vCQvaVPLwGFJeWIrzVcnEWcsH0IfSwdB7k568fgXk7DuT0EecZc8CnEO7cT01D6g+cxs CVhQ== X-Gm-Message-State: AElRT7E58lM7CgeFWUbMAuLGXFgTaICaOzsulSz/0dtn8Hpd+CuYfCuF aNYJQVaR0MVakwMMFmZ55+sTZWZy3yc= X-Google-Smtp-Source: AG47ELv07ADh2+AnFWzEKtS27o/9/hjpkHY+bnBMYqNXbR1Oa4BmciePE2kRm6jBAwp9hYhheZ9Big== X-Received: by 10.28.147.12 with SMTP id v12mr31703wmd.139.1519856419349; Wed, 28 Feb 2018 14:20:19 -0800 (PST) Received: from localhost.localdomain ([151.66.2.62]) by smtp.gmail.com with ESMTPSA id l8sm2929798wmf.39.2018.02.28.14.20.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Feb 2018 14:20:18 -0800 (PST) From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org Subject: [PATCH] mt76x2: remove unnecessary len variable in mt76x2_eeprom_load() Date: Wed, 28 Feb 2018 23:20:12 +0100 Message-Id: <20180228222012.503-1-lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.16.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Substitute unnecessary len variable in mt76x2_eeprom_load() with MT7662_EEPROM_SIZE macro since len is used just to store eeprom default size. Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c index 9c9bf3e785ba..5bb50027c1e8 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c @@ -222,11 +222,10 @@ static int mt76x2_eeprom_load(struct mt76x2_dev *dev) { void *efuse; - int len = MT7662_EEPROM_SIZE; bool found; int ret; - ret = mt76_eeprom_init(&dev->mt76, len); + ret = mt76_eeprom_init(&dev->mt76, MT7662_EEPROM_SIZE); if (ret < 0) return ret; @@ -234,14 +233,15 @@ mt76x2_eeprom_load(struct mt76x2_dev *dev) if (found) found = !mt76x2_check_eeprom(dev); - dev->mt76.otp.data = devm_kzalloc(dev->mt76.dev, len, GFP_KERNEL); - dev->mt76.otp.size = len; + dev->mt76.otp.data = devm_kzalloc(dev->mt76.dev, MT7662_EEPROM_SIZE, + GFP_KERNEL); + dev->mt76.otp.size = MT7662_EEPROM_SIZE; if (!dev->mt76.otp.data) return -ENOMEM; efuse = dev->mt76.otp.data; - if (mt76x2_get_efuse_data(dev, efuse, len)) + if (mt76x2_get_efuse_data(dev, efuse, MT7662_EEPROM_SIZE)) goto out; if (found) { @@ -249,7 +249,7 @@ mt76x2_eeprom_load(struct mt76x2_dev *dev) } else { /* FIXME: check if efuse data is complete */ found = true; - memcpy(dev->mt76.eeprom.data, efuse, len); + memcpy(dev->mt76.eeprom.data, efuse, MT7662_EEPROM_SIZE); } out: