From patchwork Thu Mar 1 21:01:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 10252519 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E53AD60211 for ; Thu, 1 Mar 2018 21:01:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2BBF285FB for ; Thu, 1 Mar 2018 21:01:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C763C28606; Thu, 1 Mar 2018 21:01:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F5EC285FB for ; Thu, 1 Mar 2018 21:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161774AbeCAVBl (ORCPT ); Thu, 1 Mar 2018 16:01:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:39466 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161716AbeCAVBk (ORCPT ); Thu, 1 Mar 2018 16:01:40 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7593BAC95; Thu, 1 Mar 2018 21:01:39 +0000 (UTC) Date: Thu, 1 Mar 2018 21:01:39 +0000 From: "Luis R. Rodriguez" To: cantabile Cc: "Luis R. Rodriguez" , Jakub Kicinski , linux-wireless@vger.kernel.org, Greg Kroah-Hartman , Andrew Morton Subject: Re: [PATCH] mt7601u: Fix system freeze after resuming from hibernation Message-ID: <20180301210139.GX14069@wotan.suse.de> References: <20180227165451.GS14069@wotan.suse.de> <20180227102253.04a3a01c@cakuba.netronome.com> <20180227204240.GW14069@wotan.suse.de> <498eb998-0dce-83c6-87c9-76cb83b148ea@gmail.com> <20180228184820.GL14069@wotan.suse.de> <20180301002813.GQ14069@wotan.suse.de> <9088ab38-5a88-f479-1225-5988f9890aaa@gmail.com> <20180301172920.GV14069@wotan.suse.de> <877eb47d-5750-c3ef-0238-bbfc73476ed2@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <877eb47d-5750-c3ef-0238-bbfc73476ed2@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Mar 01, 2018 at 10:11:01PM +0200, cantabile wrote: > On 01/03/18 19:29, Luis R. Rodriguez wrote: > > > > Correct? > > > > The above log is from "20180227-firmware-cache" kernel plus your suggested > change that makes it always upload the firmware: > > diff --git a/drivers/net/wireless/mediatek/mt7601u/mcu.c > b/drivers/net/wireless/mediatek/mt7601u/mcu.c > index 65a8004418ea..04cbffd225a1 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/mcu.c > +++ b/drivers/net/wireless/mediatek/mt7601u/mcu.c > @@ -421,7 +421,7 @@ static int mt7601u_load_firmware(struct mt7601u_dev > *dev) > MT_USB_DMA_CFG_TX_BULK_EN)); > > if (firmware_running(dev)) > - return 0; > + pr_info("Firmware already loaded but going to reload..."); > > ret = request_firmware(&fw, MT7601U_FIRMWARE, dev->dev); > if (ret) Huh, if you are using 20180227-firmware-cache, then your diff should instead be this no? > I recompiled the kernel with CONFIG_DEBUG_INFO=y, but the messages in > journalctl look pretty much the same as before. There are still question > marks in the call traces, there are no line numbers, and it still says > "verbose debug info unavailable". /proc/config.gz contains > CONFIG_DEBUG_INFO=y. What else do I need to do? Hrm, odd. CONFIG_FRAME_POINTER=y Maybe. > > But if the patches I posted help, I guess we already have a solution, The rest of > > these email exchanges are all just hypothetical exercises. > > > > Your patches definitely fix the problem I reported in my initial email. Ah OK :) Luis diff --git a/drivers/net/wireless/mediatek/mt7601u/mcu.c b/drivers/net/wireless/mediatek/mt7601u/mcu.c index b90456a4b4d7..04cbffd225a1 100644 --- a/drivers/net/wireless/mediatek/mt7601u/mcu.c +++ b/drivers/net/wireless/mediatek/mt7601u/mcu.c @@ -421,7 +421,7 @@ static int mt7601u_load_firmware(struct mt7601u_dev *dev) MT_USB_DMA_CFG_TX_BULK_EN)); if (firmware_running(dev)) - return request_firmware_cache(dev->dev, MT7601U_FIRMWARE); + pr_info("Firmware already loaded but going to reload..."); ret = request_firmware(&fw, MT7601U_FIRMWARE, dev->dev); if (ret)