From patchwork Tue Apr 3 20:30:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 10321735 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7481060318 for ; Tue, 3 Apr 2018 20:32:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D4DC1FF40 for ; Tue, 3 Apr 2018 20:32:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50D4D283ED; Tue, 3 Apr 2018 20:32:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94BE028C2A for ; Tue, 3 Apr 2018 20:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbeDCUa0 (ORCPT ); Tue, 3 Apr 2018 16:30:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:53076 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbeDCUaZ (ORCPT ); Tue, 3 Apr 2018 16:30:25 -0400 Received: by mail-wm0-f68.google.com with SMTP id g8so12282107wmd.2 for ; Tue, 03 Apr 2018 13:30:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=v8E27/P2Avt8sDU87PSdq8umvU1E6I285SJAssMZQgA=; b=uiEa0VgEf2ETk2ZLGtcBROX9Poz+ggDbczreUivvPO/u0GEP8lll2uohB6UMjcGPz3 H37COuYPRIGGE8wXNvDTLJ/oXR5h1Rz2+AwSYMQZ92o70tURe55YEezNGDN13JU5dljX Krs6KaWi1muQ8R5CkNXPPGQxbQXZrcPjcZ0an2JIRKIuM/lraWmNwqrlunAMyCAuetVz dukYKc6GP9Ih4gUO4ttbmiHV2JhOAgG85X32aD/GlZOLe9tmaFB5PWadm55xg29X9yqQ R+gcY8b3a23qj0LurzVa6kjEttsfmZOKNIWEqEUsAS1M9gqmSTL/0zte9duQBbWFwGJR XsBg== X-Gm-Message-State: ALQs6tB6tSiyAB4LA9h7K4x/3Z0HH5VGTia48xJ753qD7+T6td0/CMfs N/3Qg4Kq++8MqOLJ51IBmPCBXjJGKss= X-Google-Smtp-Source: AIpwx4/4MEGP2pW4Z/30SPPfPVCi4Qtaeimq/xar6EAivGXgDidiHP+aWRFqVMmzz+9Q5yEx3rOBUg== X-Received: by 10.28.106.1 with SMTP id f1mr5849106wmc.59.1522787424817; Tue, 03 Apr 2018 13:30:24 -0700 (PDT) Received: from localhost.localdomain ([151.66.2.62]) by smtp.gmail.com with ESMTPSA id a63sm5185773wrc.22.2018.04.03.13.30.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Apr 2018 13:30:24 -0700 (PDT) From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org Subject: [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration Date: Tue, 3 Apr 2018 22:30:19 +0200 Message-Id: <20180403203019.8988-1-lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.16.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value will be properly set according to the usage of an external power amplifier Signed-off-by: Lorenzo Bianconi Acked-by: Felix Fietkau --- Changes since v1: - remove first initialization in order to have the writes to that register grouped together in the same if/else chunk --- drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c index f28c55746cea..42414c5fa01e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c @@ -257,7 +257,6 @@ mt76x2_phy_set_txpower_regs(struct mt76x2_dev *dev, enum nl80211_band band) mt76_wr(dev, MT_TX_ALC_CFG_2, 0x1b0f0400); mt76_wr(dev, MT_TX_ALC_CFG_3, 0x1b0f0476); } - mt76_wr(dev, MT_TX_ALC_CFG_4, 0); if (mt76x2_ext_pa_enabled(dev, band)) pa_mode_adj = 0x04000000;