| Message ID | 20180423201205.20533-4-andresx7@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Mon, Apr 23, 2018 at 04:11:59PM -0400, Andres Rodriguez wrote: > Some basic definitions for the FW_OPT_* values > > v2: Documentation corrections from Luis. Likewise. > Signed-off-by: Andres Rodriguez <andresx7@gmail.com> > --- > drivers/base/firmware_loader/firmware.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > index b252bfa82295..a405d400a925 100644 > --- a/drivers/base/firmware_loader/firmware.h > +++ b/drivers/base/firmware_loader/firmware.h > @@ -11,6 +11,26 @@ > > #include <generated/utsrelease.h> > > +/** > + * enum fw_opt - options to control firmware loading behaviour > + * > + * @FW_OPT_UEVENT: Enables the fallback mechanism to send a kobject uevent > + * when the firmware is not found. Userspace is in charge > + * to load the firmware using the sysfs loading facility. The style here is a bit off. I'll just merge this patch with the last one an change the style a bit to match expectations. Luis > + * @FW_OPT_NOWAIT: Used to describe the firmware request is asynchronous. > + * @FW_OPT_USERHELPER: Enable the fallback mechanism, in case the direct > + * filesystem lookup fails at finding the firmware. > + * For details refer to fw_sysfs_fallback(). > + * @FW_OPT_NO_WARN: Quiet, avoid printing warning messages. > + * @FW_OPT_NOCACHE: Disables firmware caching. Firmware caching is used to > + * cache the firmware upon suspend, so that upon resume > + * races against the firmware file lookup on storage is > + * avoided. Used for calls where the file may be too > + * big, or where the driver takes charge of its own firmware > + * caching mechanism. > + * @FW_OPT_NOFALLBACK: Disable the fallback mechanism. Takes precedence over > + * &FW_OPT_UEVENT and &FW_OPT_USERHELPER. > + */ > enum fw_opt { > FW_OPT_UEVENT = BIT(0), > FW_OPT_NOWAIT = BIT(1), > -- > 2.14.1 > >
diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h index b252bfa82295..a405d400a925 100644 --- a/drivers/base/firmware_loader/firmware.h +++ b/drivers/base/firmware_loader/firmware.h @@ -11,6 +11,26 @@ #include <generated/utsrelease.h> +/** + * enum fw_opt - options to control firmware loading behaviour + * + * @FW_OPT_UEVENT: Enables the fallback mechanism to send a kobject uevent + * when the firmware is not found. Userspace is in charge + * to load the firmware using the sysfs loading facility. + * @FW_OPT_NOWAIT: Used to describe the firmware request is asynchronous. + * @FW_OPT_USERHELPER: Enable the fallback mechanism, in case the direct + * filesystem lookup fails at finding the firmware. + * For details refer to fw_sysfs_fallback(). + * @FW_OPT_NO_WARN: Quiet, avoid printing warning messages. + * @FW_OPT_NOCACHE: Disables firmware caching. Firmware caching is used to + * cache the firmware upon suspend, so that upon resume + * races against the firmware file lookup on storage is + * avoided. Used for calls where the file may be too + * big, or where the driver takes charge of its own firmware + * caching mechanism. + * @FW_OPT_NOFALLBACK: Disable the fallback mechanism. Takes precedence over + * &FW_OPT_UEVENT and &FW_OPT_USERHELPER. + */ enum fw_opt { FW_OPT_UEVENT = BIT(0), FW_OPT_NOWAIT = BIT(1),
Some basic definitions for the FW_OPT_* values v2: Documentation corrections from Luis. Signed-off-by: Andres Rodriguez <andresx7@gmail.com> --- drivers/base/firmware_loader/firmware.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)