From patchwork Mon Apr 23 20:12:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andres Rodriguez X-Patchwork-Id: 10358077 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B318460225 for ; Mon, 23 Apr 2018 20:14:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A413F28C29 for ; Mon, 23 Apr 2018 20:14:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98BA028C2D; Mon, 23 Apr 2018 20:14:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48E0528C29 for ; Mon, 23 Apr 2018 20:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932471AbeDWUOG (ORCPT ); Mon, 23 Apr 2018 16:14:06 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:42501 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932508AbeDWUMX (ORCPT ); Mon, 23 Apr 2018 16:12:23 -0400 Received: by mail-io0-f196.google.com with SMTP id a10-v6so2032050ioc.9; Mon, 23 Apr 2018 13:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=s5Pef7LuaicEN0TmTlnx2c6+OgybEatPtkh1cgbXKQoIrNAO4v0AlGw06yAai/7L7t ffvFCRa7mJMepQ+s1CC6ydzZpGD1TaEf+3zmdpu+1DOKaTrqRX3+DuIx6v2M8KC1hJTI yH74h6WXwbyKqxaUMBiqnPPAhUDzNmGfdqU/ACoAZtYISkEknPt0B+DAB9SVXQq75n88 hfNgdCaZ87wovcLkrq2P5vFUw015zKH3VZFxRnCF/ct1V/E6zukrD9+xwDeBkWlnF1JI NhH1M6qN8pkgBBM+xsva4xEh83YDuYik62rtQsQZN59oDv7GTX8IavVr+j9J1Hom7nwU ZyJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=bUBgilIah6kbYMrfjLOnz67SkRURraDcvJBLhk3ow/EeD2pXust9bZkO56ul+pULF2 lXWzGDQS4EFmnbZX93kGOLGQed8w2ojccxv9mIi32QWtNglus64bCTzxPieWLnTB92yS +EUYD6y2ALtHmEW0HYmHUf+bN8wa/aJDaelYMGLUNsabNB6HLYj/lUTlHlEc0gtAXGDP mwPxh9ZCfsrEPIh1hGX/ItOClbGCu7bxBzu3GzDKyRjLvwfTVhiQ/FtuDAo2dh2BYrZ4 EMF9w9dLZH3IOjiuphCTX5bK/dBG3zIcDdX/V8pt/ZpTLDmr1na1E2TnU5XXtF7uzRKp 00Ug== X-Gm-Message-State: ALQs6tAacYkFLTIprNwQvg4g6qFboGBtEioAm67IHmw475y3DhOtl+PJ Pp3dg1fhq5r83Itfn8Kg13BnfxeBDpw= X-Google-Smtp-Source: AB8JxZpWm6FIadcf1BDCzj2Mtm3K7oYgqNpQQbF2T65WlbHUa3KxF9+uY6CVj8U2CQ7qGAgoC7gZkw== X-Received: by 2002:a6b:697:: with SMTP id f23-v6mr13392298ioi.18.1524514342225; Mon, 23 Apr 2018 13:12:22 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id k130-v6sm1632551itb.0.2018.04.23.13.12.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 13:12:21 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Cc: andresx7@gmail.com, gregkh@linuxfoundation.org, mcgrof@kernel.org, alexdeucher@gmail.com, christian.koenig@amd.com, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com Subject: [PATCH 6/9] firmware: print firmware name on fallback path Date: Mon, 23 Apr 2018 16:12:02 -0400 Message-Id: <20180423201205.20533-7-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423201205.20533-1-andresx7@gmail.com> References: <20180423201205.20533-1-andresx7@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d". However, with the new firmware_request_nowarn() entrypoint, the message outlined above will not always be printed. Therefore, we add the firmware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index e75928458489..1a47ddc70c31 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -669,6 +669,6 @@ int fw_sysfs_fallback(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + dev_warn(device, "Falling back to user helper for %s\n", name); return fw_load_from_user_helper(fw, name, device, opt_flags); }