From patchwork Sun May 6 07:33:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 10382627 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5BC626053A for ; Sun, 6 May 2018 07:34:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A55A28BB0 for ; Sun, 6 May 2018 07:34:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3EFED28E87; Sun, 6 May 2018 07:34:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5BFC28BE9 for ; Sun, 6 May 2018 07:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751305AbeEFHdd (ORCPT ); Sun, 6 May 2018 03:33:33 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38281 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbeEFHdb (ORCPT ); Sun, 6 May 2018 03:33:31 -0400 Received: by mail-wr0-f193.google.com with SMTP id 94-v6so23538784wrf.5; Sun, 06 May 2018 00:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=999d58oNbdrqfNhs/IosSpPigmX16QhE0f437ISXpos=; b=QTEfR/EUUIYKK+MJfpHcZ2luD5jrvR93PdLm9VokYzj07GDZtHtlOusNMHhpfwPhCb eXvd1+LMiFGrmWIU/huB/Ze8ifj/wUwo3OD7XiQr7a+FEBniVev3hOfW9WfpB+fDaP9I xZAdsqZUZ4XaR6ALozWIBepZ3rcVAVzfYsZoHp/FZJhl5ZiYZDI0AwUdeQKZN8u4Qy/T TYvn2LETxok+QACsuRywRoxf0SyfZuWXhk3RFCTfvDTMHjBTs7r1iPKFmvvKICRRt6xG MYGcEjrezqwqcwc1AfosfgWm/mRXveF62WphaTggtWKywzuFXYdsBRW9O1WNjdD/S5H8 WQeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=999d58oNbdrqfNhs/IosSpPigmX16QhE0f437ISXpos=; b=kRL008fAeLJidmj9EIeb++ZEvU7BQDxPzjWT4ACQK5Bnp9IiVy/Nf3TDkaiL3rQLiS D6hziuiD9csJWSnunwMOXPFAbp+7oCz6UXBnrcIWTqoXr2ckiFk515rAzGMe+09JO4VU aYWVhfsEKkviCQStWc4nY7WRwM1o87l6g/Ju2NmPBbJTnjFEJEkKhmQZGKjg2jV64FCw HxJzydVdvbaxI1oSytmFb4VDPbA9fap+RwAPBdrh1zUrBJnjGt3iszG1DtTH56mSALQN W2/02um3BA/KzQ8HC82EYzaMFmFcoNtLE+cswPUiumXUKJwyixBgBOLYYrT7zZBZ0BcH 6HTw== X-Gm-Message-State: ALQs6tDF4eMHgXPp6SNrSJ9MhrxCQjd/fRn6hiUj1gYV4JyI2gsFSXIq C+SjW9KmiV8QCEZfTn8nNzk= X-Google-Smtp-Source: AB8JxZo/qXJjxMVdsK9M5UIzhAjPd/VqoTxYqqUzX30PywT/e/i77iJnjMTK3WHZjmzwjbCj6hHeZA== X-Received: by 2002:adf:b08e:: with SMTP id i14-v6mr27870861wra.9.1525592009928; Sun, 06 May 2018 00:33:29 -0700 (PDT) Received: from flashbox.your-server.de ([2a01:4f8:10b:24a5::2]) by smtp.gmail.com with ESMTPSA id u196-v6sm5180536wmf.30.2018.05.06.00.33.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 May 2018 00:33:28 -0700 (PDT) From: Nathan Chancellor To: devel@driverdev.osuosl.org Cc: Greg Kroah-Hartman , Aditya Shankar , Ganesh Krishna , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor Subject: [PATCH 1/3] staging: wilc1000: Remove unused variables Date: Sun, 6 May 2018 00:33:31 -0700 Message-Id: <20180506073333.3770-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP GCC warns these variables are all set but never used so remove them. Signed-off-by: Nathan Chancellor Reviewed-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 12 ------------ drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 ------ 2 files changed, 18 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 28edd904b33a..3fd4c8e62da6 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -1432,13 +1432,7 @@ static s32 handle_rcvd_gnrl_async_info(struct wilc_vif *vif, { s32 result = 0; u8 msg_type = 0; - u8 msg_id = 0; - u16 msg_len = 0; - u16 wid_id = (u16)WID_NIL; - u8 wid_len = 0; u8 mac_status; - u8 mac_status_reason_code; - u8 mac_status_additional_info; struct host_if_drv *hif_drv = vif->hif_drv; if (!rcvd_info->buffer) { @@ -1472,13 +1466,7 @@ static s32 handle_rcvd_gnrl_async_info(struct wilc_vif *vif, return -EFAULT; } - msg_id = rcvd_info->buffer[1]; - msg_len = MAKE_WORD16(rcvd_info->buffer[2], rcvd_info->buffer[3]); - wid_id = MAKE_WORD16(rcvd_info->buffer[4], rcvd_info->buffer[5]); - wid_len = rcvd_info->buffer[6]; mac_status = rcvd_info->buffer[7]; - mac_status_reason_code = rcvd_info->buffer[8]; - mac_status_additional_info = rcvd_info->buffer[9]; if (hif_drv->hif_state == HOST_IF_WAITING_CONN_RESP) { host_int_parse_assoc_resp_info(vif, mac_status); } else if ((mac_status == MAC_STATUS_DISCONNECTED) && diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index 8be3c4c57579..76b4afaef423 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -917,12 +917,10 @@ static int add_key(struct wiphy *wiphy, struct net_device *netdev, u8 key_index, const u8 *tx_mic = NULL; u8 mode = NO_ENCRYPT; u8 op_mode; - struct wilc *wl; struct wilc_vif *vif; priv = wiphy_priv(wiphy); vif = netdev_priv(netdev); - wl = vif->wilc; switch (params->cipher) { case WLAN_CIPHER_SUITE_WEP40: @@ -1885,12 +1883,10 @@ static int start_ap(struct wiphy *wiphy, struct net_device *dev, struct cfg80211_ap_settings *settings) { struct cfg80211_beacon_data *beacon = &settings->beacon; - struct wilc_priv *priv; s32 ret = 0; struct wilc *wl; struct wilc_vif *vif; - priv = wiphy_priv(wiphy); vif = netdev_priv(dev); wl = vif->wilc; @@ -2016,14 +2012,12 @@ static int change_station(struct wiphy *wiphy, struct net_device *dev, const u8 *mac, struct station_parameters *params) { s32 ret = 0; - struct wilc_priv *priv; struct add_sta_param sta_params = { {0} }; struct wilc_vif *vif; if (!wiphy) return -EFAULT; - priv = wiphy_priv(wiphy); vif = netdev_priv(dev); if (vif->iftype == AP_MODE || vif->iftype == GO_MODE) {