From patchwork Mon Jun 11 18:19:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10458637 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D9D866020F for ; Mon, 11 Jun 2018 18:19:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC31228574 for ; Mon, 11 Jun 2018 18:19:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C10032858D; Mon, 11 Jun 2018 18:19:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7220028574 for ; Mon, 11 Jun 2018 18:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934213AbeFKSTq (ORCPT ); Mon, 11 Jun 2018 14:19:46 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:46172 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933452AbeFKSTp (ORCPT ); Mon, 11 Jun 2018 14:19:45 -0400 Received: by mail-pf0-f196.google.com with SMTP id q1-v6so10660459pff.13 for ; Mon, 11 Jun 2018 11:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=FoqW5kbSQry1ZnHepDpW0njGWC1OzjUWOfc/81TfeoQ=; b=WK/UUfe5baloKX9dn+zKH4Tabs3ICKmaVja5SB1EiXqL+LPnU9XOKGPB/Ht1kXz+/Y APpSPah+IKlzSxOMTlvirD+/GbQKbq/7tUewxD+4w41/y+B+BUBfL45706KMutV+lekJ 5FgZj+lV648SGWg7XJpn7uYgMoDs8fMVpZqQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FoqW5kbSQry1ZnHepDpW0njGWC1OzjUWOfc/81TfeoQ=; b=SsZvAzfwO1Ssjyeg3E4R9uouv8Gd84YWb6/LAZi23nOxEgl3l6zoKbxSSieEKZ1bjX RseEP1d+uYGw8jEpFgr3I9XsAfALAy8SvPgWHlN+QzrL0DQNtgotS3p4cbekgHA2jkvm ROjf0+Jp6sy18A8naC6zQYuvHY5F7bRba70PgI+Cd5cIoq62jgek1XhGtAwVbC31TGvy Zld1nSzNYU8RZvrPr9sHQo45g+488Uv6iQZG1Dt3vNfmNi72l/GBPCYnVGcT8PoyeL9c h3dhVkRVzl+rs8MtDKnSk6uIQPq2XsUFz1TSPtPsQKzGM0CRY81ZjCDjC8+X2t2i2LOe R23g== X-Gm-Message-State: APt69E3x8FdRSPNhemE6roNXDeiuE0htWEB3+prcFabDINjvtYutmsCr Koub5koh9LSI49jKMSelxR4MGA== X-Google-Smtp-Source: ADUXVKJFDLqlQr5upph3MZIYJ0EIEJ9b82ibF3X6vm2MvuB4Al4NeGkuC8n7I4NzEcgATc6YjfIiGQ== X-Received: by 2002:a62:211a:: with SMTP id h26-v6mr250263pfh.133.1528741184923; Mon, 11 Jun 2018 11:19:44 -0700 (PDT) Received: from ban.mtv.corp.google.com ([2620:0:1000:1501:bc2f:3082:9938:5d41]) by smtp.gmail.com with ESMTPSA id q82-v6sm81502560pfg.170.2018.06.11.11.19.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 11:19:43 -0700 (PDT) From: Brian Norris To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, , Brian Norris Subject: [PATCH] ath10k: use crash_dump enum instead of magic numbers Date: Mon, 11 Jun 2018 11:19:35 -0700 Message-Id: <20180611181935.155032-1-briannorris@chromium.org> X-Mailer: git-send-email 2.18.0.rc1.242.g61856ae69a-goog Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The comments are telling you what the enum could tell you instead. Signed-off-by: Brian Norris --- drivers/net/wireless/ath/ath10k/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 4cf54a7ef09a..eae46a04f503 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -41,10 +41,8 @@ static bool uart_print; static bool skip_otp; static bool rawmode; -/* Enable ATH10K_FW_CRASH_DUMP_REGISTERS and ATH10K_FW_CRASH_DUMP_CE_DATA - * by default. - */ -unsigned long ath10k_coredump_mask = 0x3; +unsigned long ath10k_coredump_mask = BIT(ATH10K_FW_CRASH_DUMP_REGISTERS) | + BIT(ATH10K_FW_CRASH_DUMP_CE_DATA); /* FIXME: most of these should be readonly */ module_param_named(debug_mask, ath10k_debug_mask, uint, 0644);