| Message ID | 20180611193540.190255-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0644fef97451908ef1048043b0a60d1324d8a522 |
| Delegated to: | Kalle Valo |
| Headers | show |
Brian Norris <briannorris@chromium.org> writes: > ath10k_snoc_init()/ath10k_snoc_exit() don't add much value; > module_platform_driver() can remove the boilerplate. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > drivers/net/wireless/ath/ath10k/snoc.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > index a3a7042fe13a..ee74e0060504 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -1388,25 +1388,7 @@ static struct platform_driver ath10k_snoc_driver = { > .of_match_table = ath10k_snoc_dt_match, > }, > }; > - > -static int __init ath10k_snoc_init(void) > -{ > - int ret; > - > - ret = platform_driver_register(&ath10k_snoc_driver); > - if (ret) > - pr_err("failed to register ath10k snoc driver: %d\n", > - ret); > - > - return ret; > -} > -module_init(ath10k_snoc_init); > - > -static void __exit ath10k_snoc_exit(void) > -{ > - platform_driver_unregister(&ath10k_snoc_driver); > -} > -module_exit(ath10k_snoc_exit); > +module_platform_driver(ath10k_snoc_driver); Yeah, makes sense. And I also checked that this shouldn't conflict with Govind's qmi patch: https://patchwork.kernel.org/patch/10448183/
Brian Norris <briannorris@chromium.org> wrote: > ath10k_snoc_init()/ath10k_snoc_exit() don't add much value; > module_platform_driver() can remove the boilerplate. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 0644fef97451 ath10k: snoc: use module_platform_driver() macro
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index a3a7042fe13a..ee74e0060504 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1388,25 +1388,7 @@ static struct platform_driver ath10k_snoc_driver = { .of_match_table = ath10k_snoc_dt_match, }, }; - -static int __init ath10k_snoc_init(void) -{ - int ret; - - ret = platform_driver_register(&ath10k_snoc_driver); - if (ret) - pr_err("failed to register ath10k snoc driver: %d\n", - ret); - - return ret; -} -module_init(ath10k_snoc_init); - -static void __exit ath10k_snoc_exit(void) -{ - platform_driver_unregister(&ath10k_snoc_driver); -} -module_exit(ath10k_snoc_exit); +module_platform_driver(ath10k_snoc_driver); MODULE_AUTHOR("Qualcomm"); MODULE_LICENSE("Dual BSD/GPL");
ath10k_snoc_init()/ath10k_snoc_exit() don't add much value; module_platform_driver() can remove the boilerplate. Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/net/wireless/ath/ath10k/snoc.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-)