From patchwork Wed Jun 13 06:48:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Govind Singh X-Patchwork-Id: 10461677 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6766D603B4 for ; Wed, 13 Jun 2018 06:48:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6BF4728696 for ; Wed, 13 Jun 2018 06:48:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BCA92870E; Wed, 13 Jun 2018 06:48:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E876428696 for ; Wed, 13 Jun 2018 06:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754470AbeFMGsN (ORCPT ); Wed, 13 Jun 2018 02:48:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40202 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754398AbeFMGsM (ORCPT ); Wed, 13 Jun 2018 02:48:12 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id BEAE460116; Wed, 13 Jun 2018 06:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1528872491; bh=x++g5P4a2tHcVKV0GEJ3ejORKraZvWq98vHIZl3OKes=; h=From:To:Cc:Subject:Date:From; b=Ju2FvBH0TlftrFsEvPRfinTxjzOPctYpK/l72oFzjs+ixpV8yrIqXflktqunJr/bp qa6tBSVR+zJQpt73Awq+ed7NjYgHxAo4yWdayvQkt5rGUtCjD0nUsWQmUnW0dB2ZS8 N6GTsiiDFAkUB5sk0eZusr+J9pibUc0HV1nvtfWw= Received: from govinds-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: govinds@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3E56460351; Wed, 13 Jun 2018 06:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1528872491; bh=x++g5P4a2tHcVKV0GEJ3ejORKraZvWq98vHIZl3OKes=; h=From:To:Cc:Subject:Date:From; b=Ju2FvBH0TlftrFsEvPRfinTxjzOPctYpK/l72oFzjs+ixpV8yrIqXflktqunJr/bp qa6tBSVR+zJQpt73Awq+ed7NjYgHxAo4yWdayvQkt5rGUtCjD0nUsWQmUnW0dB2ZS8 N6GTsiiDFAkUB5sk0eZusr+J9pibUc0HV1nvtfWw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3E56460351 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=govinds@codeaurora.org From: Govind Singh To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Govind Singh Subject: [PATCH] ath10k: Handle resource init failure case Date: Wed, 13 Jun 2018 12:18:06 +0530 Message-Id: <20180613064806.32286-1-govinds@codeaurora.org> X-Mailer: git-send-email 2.17.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return type of resource init method is not assigned. Handle resource init failures for graceful exit. Signed-off-by: Govind Singh --- drivers/net/wireless/ath/ath10k/snoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index aa8a9b36250e..a0504b8e003c 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1500,13 +1500,13 @@ static int ath10k_snoc_probe(struct platform_device *pdev) ar_snoc->ce.bus_ops = &ath10k_snoc_bus_ops; ar->ce_priv = &ar_snoc->ce; - ath10k_snoc_resource_init(ar); + ret = ath10k_snoc_resource_init(ar); if (ret) { ath10k_warn(ar, "failed to initialize resource: %d\n", ret); goto err_core_destroy; } - ath10k_snoc_setup_resource(ar); + ret = ath10k_snoc_setup_resource(ar); if (ret) { ath10k_warn(ar, "failed to setup resource: %d\n", ret); goto err_core_destroy;