Message ID | 20180623221531.6396-2-colin.king@canonical.com (mailing list archive) |
---|---|
State | Accepted |
Commit | ab8d904654e2bb55b2964588700c31f974382894 |
Delegated to: | Kalle Valo |
Headers | show |
Colin Ian King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function wlc_phy_workarounds_nphy_rev1 is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'wlc_phy_workarounds_nphy_rev1' was not declared. Should it > be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied to wireless-drivers-next.git, thanks. ab8d904654e2 brcmsmac: make function wlc_phy_workarounds_nphy_rev1 static
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index 1a187557982e..bedec1606caa 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -16904,7 +16904,7 @@ static void wlc_phy_workarounds_nphy_rev3(struct brcms_phy *pi) } } -void wlc_phy_workarounds_nphy_rev1(struct brcms_phy *pi) +static void wlc_phy_workarounds_nphy_rev1(struct brcms_phy *pi) { static const u8 rfseq_rx2tx_events[] = { NPHY_RFSEQ_CMD_NOP,